| Message ID | 20240502104800.3030486-3-jisheng.teoh@starfivetech.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add optional reset control for Cadence SPI | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 02/05/2024 12:48, Ji Sheng Teoh wrote: > Document the optional reset control to SPI. > > Signed-off-by: Eng Lee Teh <englee.teh@starfivetech.com> > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> Who is the author here? What are these three SoBs expressing? Rob asked for this last time. Best regards, Krzysztof
> On 02/05/2024 12:48, Ji Sheng Teoh wrote: > > Document the optional reset control to SPI. > > > > Signed-off-by: Eng Lee Teh <englee.teh@starfivetech.com> > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > > Who is the author here? What are these three SoBs expressing? Rob asked for this last time. First SoB was the original author, the subsequent SoB made changes to the original patch. If intend to only keep the author, then please take the first SoB. Sorry for the noise.
On 02/05/2024 14:45, JiSheng Teoh wrote: >> On 02/05/2024 12:48, Ji Sheng Teoh wrote: >>> Document the optional reset control to SPI. >>> >>> Signed-off-by: Eng Lee Teh <englee.teh@starfivetech.com> >>> Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> >>> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> >> >> Who is the author here? What are these three SoBs expressing? Rob asked for this last time. > > First SoB was the original author, the subsequent SoB made changes to the original patch. > If intend to only keep the author, then please take the first SoB. Sorry for the noise. Then you miss Co-developed-by tags. Best regards, Krzysztof
> On 02/05/2024 14:45, JiSheng Teoh wrote: > >> On 02/05/2024 12:48, Ji Sheng Teoh wrote: > >>> Document the optional reset control to SPI. > >>> > >>> Signed-off-by: Eng Lee Teh <englee.teh@starfivetech.com> > >>> Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > >>> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > >> > >> Who is the author here? What are these three SoBs expressing? Rob asked for this last time. > > > > First SoB was the original author, the subsequent SoB made changes to the original patch. > > If intend to only keep the author, then please take the first SoB. Sorry for the noise. > > Then you miss Co-developed-by tags. Thanks, I will fix the tags in the next revision.
On 02/05/2024 12:48, Ji Sheng Teoh wrote: > Document the optional reset control to SPI. > > Signed-off-by: Eng Lee Teh <englee.teh@starfivetech.com> > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml index d4b61b0e8301..8de96abe9da1 100644 --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml @@ -55,6 +55,13 @@ properties: label: description: Descriptive name of the SPI controller. + resets: + maxItems: 1 + + reset-names: + items: + - const: spi + required: - compatible - reg