| Message ID | 20231113155008.2147090-2-peteryin.openbmc@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | hwmon: (pmbus) MPS mp5990 hsc controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote: > Add a device tree bindings for mp5990 device. > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor, > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 7680c8a9b4ad..eb83ab4c02ee 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -123,6 +123,8 @@ properties: > - mps,mp2888 > # Monolithic Power Systems Inc. multi-phase controller mp2975 > - mps,mp2975 > + # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 > + - mps,mp5990 > # Honeywell Humidicon HIH-6130 humidity/temperature sensor > - honeywell,hi6130 > # IBM Common Form Factor Power Supply Versions (all versions) > -- > 2.25.1 >
On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote: > Add a device tree bindings for mp5990 device. > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> What branch is this patch based on ? git fails to apply it. Guenter
Guenter Roeck 於 11/16/23 06:27 寫道: > On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote: >> Add a device tree bindings for mp5990 device. >> >> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > What branch is this patch based on ? git fails to apply it. > > Guenter I think I don't pull the last version. I can rebase it and push the new version. Thanks for your feedback.
On Fri, Nov 17, 2023 at 11:18:47AM +0800, PeterYin wrote: > > > Guenter Roeck 於 11/16/23 06:27 寫道: > > On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote: > > > Add a device tree bindings for mp5990 device. > > > > > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > What branch is this patch based on ? git fails to apply it. > > > > Guenter > I think I don't pull the last version. I can rebase it and push the new > version. Thanks for your feedback. Question is: Last version of what ? Best would be if it was based on mainline. Thanks, Guenter
Guenter Roeck 於 11/17/23 12:16 寫道: > On Fri, Nov 17, 2023 at 11:18:47AM +0800, PeterYin wrote: >> >> >> Guenter Roeck 於 11/16/23 06:27 寫道: >>> On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote: >>>> Add a device tree bindings for mp5990 device. >>>> >>>> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> >>>> Acked-by: Conor Dooley <conor.dooley@microchip.com> >>> >>> What branch is this patch based on ? git fails to apply it. >>> >>> Guenter >> I think I don't pull the last version. I can rebase it and push the new >> version. Thanks for your feedback. > > Question is: Last version of what ? Best would be if it was based > on mainline. > > Thanks, > Guenter It is base on Linux 6.5.4, OpenBMC Kernel tree https://github.com/openbmc/linux/commit/2ba0babe7865cd5f4fac3d76ad15d9b6131bd283 I can regenerate it on mainline. Thanks, Peter.
On 11/16/23 20:52, PeterYin wrote: > > > Guenter Roeck 於 11/17/23 12:16 寫道: >> On Fri, Nov 17, 2023 at 11:18:47AM +0800, PeterYin wrote: >>> >>> >>> Guenter Roeck 於 11/16/23 06:27 寫道: >>>> On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote: >>>>> Add a device tree bindings for mp5990 device. >>>>> >>>>> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> >>>>> Acked-by: Conor Dooley <conor.dooley@microchip.com> >>>> >>>> What branch is this patch based on ? git fails to apply it. >>>> >>>> Guenter >>> I think I don't pull the last version. I can rebase it and push the new >>> version. Thanks for your feedback. >> >> Question is: Last version of what ? Best would be if it was based >> on mainline. >> >> Thanks, >> Guenter > > It is base on Linux 6.5.4, OpenBMC Kernel tree > https://github.com/openbmc/linux/commit/2ba0babe7865cd5f4fac3d76ad15d9b6131bd283 > > I can regenerate it on mainline. > No need; git was able to apply it after I aded the openbmc tree as remote. It would be great if you can base future patches on Linux mainline. Thanks, Guenter
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 7680c8a9b4ad..eb83ab4c02ee 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -123,6 +123,8 @@ properties: - mps,mp2888 # Monolithic Power Systems Inc. multi-phase controller mp2975 - mps,mp2975 + # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 + - mps,mp5990 # Honeywell Humidicon HIH-6130 humidity/temperature sensor - honeywell,hi6130 # IBM Common Form Factor Power Supply Versions (all versions)
Add a device tree bindings for mp5990 device. Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)