| Message ID | 20231023154649.45931-7-Parthiban.Veerasooran@microchip.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, Oct 23, 2023 at 09:16:46PM +0530, Parthiban Veerasooran wrote: > Direct PHY Register Access Capability indicates if PHY registers are > directly accessible within the SPI register memory space. Indirect PHY > Register Access Capability indicates if PHY registers are indirectly > accessible through the MDIO/MDC registers MDIOACCn. > > Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> It is more normal to put all the bindings into one patch. Again, this seems like configuration, not a description of the hardware. Its also not clear to my why you would want to configure it. Andrew
Hi Andrew, On 24/10/23 6:51 am, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, Oct 23, 2023 at 09:16:46PM +0530, Parthiban Veerasooran wrote: >> Direct PHY Register Access Capability indicates if PHY registers are >> directly accessible within the SPI register memory space. Indirect PHY >> Register Access Capability indicates if PHY registers are indirectly >> accessible through the MDIO/MDC registers MDIOACCn. >> >> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> > > It is more normal to put all the bindings into one patch. > > Again, this seems like configuration, not a description of the > hardware. Its also not clear to my why you would want to configure it. Yes, will remove this option from DT binding and will read the capability register (STDCAP) for the support. Best Regards, Parthiban V > > Andrew
diff --git a/Documentation/devicetree/bindings/net/oa-tc6.yaml b/Documentation/devicetree/bindings/net/oa-tc6.yaml index 9f442fa6cace..09f1c11c68b9 100644 --- a/Documentation/devicetree/bindings/net/oa-tc6.yaml +++ b/Documentation/devicetree/bindings/net/oa-tc6.yaml @@ -58,6 +58,18 @@ properties: data written to and read from the MAC-PHY will be transferred with its complement for detection of bit errors. + oa-dprac: + maxItems: 1 + description: + Direct PHY Register Access Capability. Indicates if PHY registers + are directly accessible within the SPI register memory space. + + oa-dprac: + maxItems: 1 + description: + Indirect PHY Register Access Capability. Indicates if PHY registers + are indirectly accessible through the MDIO/MDC registers MDIOACCn. + additionalProperties: true examples: @@ -69,4 +81,6 @@ examples: oa-txcte; oa-rxcte; oa-prote; + oa-dprac; + oa-iprac; };
Direct PHY Register Access Capability indicates if PHY registers are directly accessible within the SPI register memory space. Indirect PHY Register Access Capability indicates if PHY registers are indirectly accessible through the MDIO/MDC registers MDIOACCn. Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> --- Documentation/devicetree/bindings/net/oa-tc6.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)