| Message ID | 20231023154649.45931-10-Parthiban.Veerasooran@microchip.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 23 Oct 2023 21:16:49 +0530, Parthiban Veerasooran wrote: > Add DT bindings for Microchip's LAN865X 10BASE-T1S MACPHY. The LAN8650/1 > combines a Media Access Controller (MAC) and an Ethernet PHY to enable > 10BASE‑T1S networks. The Ethernet Media Access Controller (MAC) module > implements a 10 Mbps half duplex Ethernet MAC, compatible with the IEEE > 802.3 standard and a 10BASE-T1S physical layer transceiver integrated > into the LAN8650/1. The communication between the Host and the MAC-PHY is > specified in the OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6). > > Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> > --- > .../bindings/net/microchip,lan865x.yaml | 101 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 102 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/net/microchip,lan865x.yaml:21:53: [error] syntax error: mapping values are not allowed here (syntax) dtschema/dtc warnings/errors: make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/microchip,lan865x.example.dts' Documentation/devicetree/bindings/net/microchip,lan865x.yaml:21:53: mapping values are not allowed in this context make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/microchip,lan865x.example.dts] Error 1 ./Documentation/devicetree/bindings/net/microchip,lan865x.yaml:21:53: mapping values are not allowed in this context /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan865x.yaml: ignoring, error parsing file doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231023154649.45931-10-Parthiban.Veerasooran@microchip.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 23/10/2023 17:46, Parthiban Veerasooran wrote: > Add DT bindings for Microchip's LAN865X 10BASE-T1S MACPHY. The LAN8650/1 > combines a Media Access Controller (MAC) and an Ethernet PHY to enable > 10BASE‑T1S networks. The Ethernet Media Access Controller (MAC) module > implements a 10 Mbps half duplex Ethernet MAC, compatible with the IEEE > 802.3 standard and a 10BASE-T1S physical layer transceiver integrated > into the LAN8650/1. The communication between the Host and the MAC-PHY is > specified in the OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6). It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. > > Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> > --- > .../bindings/net/microchip,lan865x.yaml | 101 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 102 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan865x.yaml b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml > new file mode 100644 > index 000000000000..974622dd6846 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml > @@ -0,0 +1,101 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/microchip,lan865x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip LAN8650/1 10BASE-T1S MACPHY Ethernet Controllers > + > +maintainers: > + - Parthiban Veerasooran <parthiban.veerasooran@microchip.com> > + > +description: > + The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet > + PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller > + (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible > + with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver > + integrated into the LAN8650/1. The communication between the Host and > + the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial > + Interface (TC6). > + > + Specifications about the LAN8650/1 can be found at: > + https://www.microchip.com/en-us/product/lan8650 > + > +allOf: > + - $ref: ethernet-controller.yaml# > + > +properties: > + compatible: > + const: microchip,lan865x No wildcards in compatibles. > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: > + Interrupt from MAC-PHY asserted in the event of Receive Chunks > + Available, Transmit Chunk Credits Available and Extended Status > + Event. > + maxItems: 1 > + > + local-mac-address: Drop property, not needed. > + description: > + Specifies the MAC address assigned to the network device. > + $ref: /schemas/types.yaml#/definitions/uint8-array > + minItems: 6 > + maxItems: 6 > + > + spi-max-frequency: > + minimum: 15000000 > + maximum: 25000000 > + > + oa-tc6: > + $ref: oa-tc6.yaml# > + unevaluatedProperties: true This must be false. > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - pinctrl-names > + - pinctrl-0 > + - interrupts > + - interrupt-parent > + - local-mac-address > + - spi-max-frequency > + - oa-tc6 > + > +additionalProperties: false Instead: unevaluatedProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet@0 { > + compatible = "microchip,lan865x"; > + reg = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <ð0_pins>; > + interrupt-parent = <&gpio>; > + interrupts = <6 IRQ_TYPE_EDGE_FALLING>; > + local-mac-address = [04 05 06 01 02 03]; > + spi-max-frequency = <15000000>; > + status = "okay"; Drop status. > + oa-tc6 { > + #address-cells = <1>; > + #size-cells = <0>; > + oa-cps = <64>; > + oa-txcte; > + oa_rxcte; > + oa-prote; > + oa-dprac; Again totally mixed up indentation. > + }; > + }; > + }; Best regards, Krzysztof
Hi, On 23/10/23 11:10 pm, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, 23 Oct 2023 21:16:49 +0530, Parthiban Veerasooran wrote: >> Add DT bindings for Microchip's LAN865X 10BASE-T1S MACPHY. The LAN8650/1 >> combines a Media Access Controller (MAC) and an Ethernet PHY to enable >> 10BASE‑T1S networks. The Ethernet Media Access Controller (MAC) module >> implements a 10 Mbps half duplex Ethernet MAC, compatible with the IEEE >> 802.3 standard and a 10BASE-T1S physical layer transceiver integrated >> into the LAN8650/1. The communication between the Host and the MAC-PHY is >> specified in the OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6). >> >> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> >> --- >> .../bindings/net/microchip,lan865x.yaml | 101 ++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 102 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/net/microchip,lan865x.yaml:21:53: [error] syntax error: mapping values are not allowed here (syntax) > > dtschema/dtc warnings/errors: > make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/microchip,lan865x.example.dts' > Documentation/devicetree/bindings/net/microchip,lan865x.yaml:21:53: mapping values are not allowed in this context > make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/microchip,lan865x.example.dts] Error 1 > ./Documentation/devicetree/bindings/net/microchip,lan865x.yaml:21:53: mapping values are not allowed in this context > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan865x.yaml: ignoring, error parsing file > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231023154649.45931-10-Parthiban.Veerasooran@microchip.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. Sorry, somehow I missed doing this check. Will fix this in the next revision. Best Regards, Parthiban V > >
Hi Krzysztof, On 24/10/23 1:33 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 23/10/2023 17:46, Parthiban Veerasooran wrote: >> Add DT bindings for Microchip's LAN865X 10BASE-T1S MACPHY. The LAN8650/1 >> combines a Media Access Controller (MAC) and an Ethernet PHY to enable >> 10BASE‑T1S networks. The Ethernet Media Access Controller (MAC) module >> implements a 10 Mbps half duplex Ethernet MAC, compatible with the IEEE >> 802.3 standard and a 10BASE-T1S physical layer transceiver integrated >> into the LAN8650/1. The communication between the Host and the MAC-PHY is >> specified in the OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6). > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. Sorry, somehow I missed doing this check. Will fix this in the next revision. > >> >> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> >> --- >> .../bindings/net/microchip,lan865x.yaml | 101 ++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 102 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/microchip,lan865x.yaml b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml >> new file mode 100644 >> index 000000000000..974622dd6846 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml >> @@ -0,0 +1,101 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/microchip,lan865x.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Microchip LAN8650/1 10BASE-T1S MACPHY Ethernet Controllers >> + >> +maintainers: >> + - Parthiban Veerasooran <parthiban.veerasooran@microchip.com> >> + >> +description: >> + The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet >> + PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller >> + (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible >> + with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver >> + integrated into the LAN8650/1. The communication between the Host and >> + the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial >> + Interface (TC6). >> + >> + Specifications about the LAN8650/1 can be found at: >> + https://www.microchip.com/en-us/product/lan8650 >> + >> +allOf: >> + - $ref: ethernet-controller.yaml# >> + >> +properties: >> + compatible: >> + const: microchip,lan865x > > No wildcards in compatibles. Ah ok missed it. So it will become like below isn't it? properties: compatible: enum: - microchip,lan8650 - microchip,lan8651 > >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + description: >> + Interrupt from MAC-PHY asserted in the event of Receive Chunks >> + Available, Transmit Chunk Credits Available and Extended Status >> + Event. >> + maxItems: 1 >> + >> + local-mac-address: > > Drop property, not needed. Ok noted. > >> + description: >> + Specifies the MAC address assigned to the network device. >> + $ref: /schemas/types.yaml#/definitions/uint8-array >> + minItems: 6 >> + maxItems: 6 >> + >> + spi-max-frequency: >> + minimum: 15000000 >> + maximum: 25000000 >> + >> + oa-tc6: >> + $ref: oa-tc6.yaml# >> + unevaluatedProperties: true > > This must be false. Ok noted. > >> + >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 0 >> + >> +required: >> + - compatible >> + - reg >> + - pinctrl-names >> + - pinctrl-0 >> + - interrupts >> + - interrupt-parent >> + - local-mac-address >> + - spi-max-frequency >> + - oa-tc6 >> + >> +additionalProperties: false > > Instead: > unevaluatedProperties: false Ok noted. > >> + >> +examples: >> + - | >> + spi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + ethernet@0 { >> + compatible = "microchip,lan865x"; >> + reg = <0>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <ð0_pins>; >> + interrupt-parent = <&gpio>; >> + interrupts = <6 IRQ_TYPE_EDGE_FALLING>; >> + local-mac-address = [04 05 06 01 02 03]; >> + spi-max-frequency = <15000000>; >> + status = "okay"; > > Drop status. Ok noted. > >> + oa-tc6 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + oa-cps = <64>; >> + oa-txcte; >> + oa_rxcte; >> + oa-prote; >> + oa-dprac; > > Again totally mixed up indentation. Sorry, probably in the next revision they will not be anymore. Best Regards, Parthiban V > >> + }; >> + }; >> + }; > > Best regards, > Krzysztof > >
On 30/10/2023 14:16, Parthiban.Veerasooran@microchip.com wrote: > Hi Krzysztof, > > On 24/10/23 1:33 pm, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 23/10/2023 17:46, Parthiban Veerasooran wrote: >>> Add DT bindings for Microchip's LAN865X 10BASE-T1S MACPHY. The LAN8650/1 >>> combines a Media Access Controller (MAC) and an Ethernet PHY to enable >>> 10BASE‑T1S networks. The Ethernet Media Access Controller (MAC) module >>> implements a 10 Mbps half duplex Ethernet MAC, compatible with the IEEE >>> 802.3 standard and a 10BASE-T1S physical layer transceiver integrated >>> into the LAN8650/1. The communication between the Host and the MAC-PHY is >>> specified in the OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6). >> >> It does not look like you tested the bindings, at least after quick >> look. Please run `make dt_binding_check` (see >> Documentation/devicetree/bindings/writing-schema.rst for instructions). >> Maybe you need to update your dtschema and yamllint. > Sorry, somehow I missed doing this check. Will fix this in the next > revision. Please also build your driver. >> >>> >>> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> >>> --- >>> .../bindings/net/microchip,lan865x.yaml | 101 ++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 102 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/net/microchip,lan865x.yaml b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml >>> new file mode 100644 >>> index 000000000000..974622dd6846 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml >>> @@ -0,0 +1,101 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/microchip,lan865x.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Microchip LAN8650/1 10BASE-T1S MACPHY Ethernet Controllers >>> + >>> +maintainers: >>> + - Parthiban Veerasooran <parthiban.veerasooran@microchip.com> >>> + >>> +description: >>> + The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet >>> + PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller >>> + (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible >>> + with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver >>> + integrated into the LAN8650/1. The communication between the Host and >>> + the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial >>> + Interface (TC6). >>> + >>> + Specifications about the LAN8650/1 can be found at: >>> + https://www.microchip.com/en-us/product/lan8650 >>> + >>> +allOf: >>> + - $ref: ethernet-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: microchip,lan865x >> >> No wildcards in compatibles. > Ah ok missed it. So it will become like below isn't it? > > properties: > compatible: > enum: > - microchip,lan8650 > - microchip,lan8651 Rather enum for lan8650 and items for lan8651 with fallback. Aren't they compatible, since you wanted to use wildcard? Best regards, Krzysztof
Hi Krzysztof On 30/10/23 8:15 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 30/10/2023 14:16, Parthiban.Veerasooran@microchip.com wrote: >> Hi Krzysztof, >> >> On 24/10/23 1:33 pm, Krzysztof Kozlowski wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> On 23/10/2023 17:46, Parthiban Veerasooran wrote: >>>> Add DT bindings for Microchip's LAN865X 10BASE-T1S MACPHY. The LAN8650/1 >>>> combines a Media Access Controller (MAC) and an Ethernet PHY to enable >>>> 10BASE‑T1S networks. The Ethernet Media Access Controller (MAC) module >>>> implements a 10 Mbps half duplex Ethernet MAC, compatible with the IEEE >>>> 802.3 standard and a 10BASE-T1S physical layer transceiver integrated >>>> into the LAN8650/1. The communication between the Host and the MAC-PHY is >>>> specified in the OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6). >>> >>> It does not look like you tested the bindings, at least after quick >>> look. Please run `make dt_binding_check` (see >>> Documentation/devicetree/bindings/writing-schema.rst for instructions). >>> Maybe you need to update your dtschema and yamllint. >> Sorry, somehow I missed doing this check. Will fix this in the next >> revision. > > Please also build your driver. Didn't see any error in the driver compilation. > >>> >>>> >>>> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> >>>> --- >>>> .../bindings/net/microchip,lan865x.yaml | 101 ++++++++++++++++++ >>>> MAINTAINERS | 1 + >>>> 2 files changed, 102 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/microchip,lan865x.yaml b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml >>>> new file mode 100644 >>>> index 000000000000..974622dd6846 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml >>>> @@ -0,0 +1,101 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/net/microchip,lan865x.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Microchip LAN8650/1 10BASE-T1S MACPHY Ethernet Controllers >>>> + >>>> +maintainers: >>>> + - Parthiban Veerasooran <parthiban.veerasooran@microchip.com> >>>> + >>>> +description: >>>> + The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet >>>> + PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller >>>> + (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible >>>> + with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver >>>> + integrated into the LAN8650/1. The communication between the Host and >>>> + the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial >>>> + Interface (TC6). >>>> + >>>> + Specifications about the LAN8650/1 can be found at: >>>> + https://www.microchip.com/en-us/product/lan8650 >>>> + >>>> +allOf: >>>> + - $ref: ethernet-controller.yaml# >>>> + >>>> +properties: >>>> + compatible: >>>> + const: microchip,lan865x >>> >>> No wildcards in compatibles. >> Ah ok missed it. So it will become like below isn't it? >> >> properties: >> compatible: >> enum: >> - microchip,lan8650 >> - microchip,lan8651 > > Rather enum for lan8650 and items for lan8651 with fallback. Aren't they > compatible, since you wanted to use wildcard? So do you mean like below? properties: compatible: oneOf: - items: - const: microchip,lan8650 - const: microchip,lan8651 - enum: - microchip,lan8650 Best Regards, Parthiban V > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/net/microchip,lan865x.yaml b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml new file mode 100644 index 000000000000..974622dd6846 --- /dev/null +++ b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml @@ -0,0 +1,101 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/microchip,lan865x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip LAN8650/1 10BASE-T1S MACPHY Ethernet Controllers + +maintainers: + - Parthiban Veerasooran <parthiban.veerasooran@microchip.com> + +description: + The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet + PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller + (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible + with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver + integrated into the LAN8650/1. The communication between the Host and + the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial + Interface (TC6). + + Specifications about the LAN8650/1 can be found at: + https://www.microchip.com/en-us/product/lan8650 + +allOf: + - $ref: ethernet-controller.yaml# + +properties: + compatible: + const: microchip,lan865x + + reg: + maxItems: 1 + + interrupts: + description: + Interrupt from MAC-PHY asserted in the event of Receive Chunks + Available, Transmit Chunk Credits Available and Extended Status + Event. + maxItems: 1 + + local-mac-address: + description: + Specifies the MAC address assigned to the network device. + $ref: /schemas/types.yaml#/definitions/uint8-array + minItems: 6 + maxItems: 6 + + spi-max-frequency: + minimum: 15000000 + maximum: 25000000 + + oa-tc6: + $ref: oa-tc6.yaml# + unevaluatedProperties: true + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +required: + - compatible + - reg + - pinctrl-names + - pinctrl-0 + - interrupts + - interrupt-parent + - local-mac-address + - spi-max-frequency + - oa-tc6 + +additionalProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + ethernet@0 { + compatible = "microchip,lan865x"; + reg = <0>; + pinctrl-names = "default"; + pinctrl-0 = <ð0_pins>; + interrupt-parent = <&gpio>; + interrupts = <6 IRQ_TYPE_EDGE_FALLING>; + local-mac-address = [04 05 06 01 02 03]; + spi-max-frequency = <15000000>; + status = "okay"; + oa-tc6 { + #address-cells = <1>; + #size-cells = <0>; + oa-cps = <64>; + oa-txcte; + oa_rxcte; + oa-prote; + oa-dprac; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 1b1bd3218a2d..d2b3c0e8d97e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14005,6 +14005,7 @@ MICROCHIP LAN8650/1 10BASE-T1S MACPHY ETHERNET DRIVER M: Parthiban Veerasooran <parthiban.veerasooran@microchip.com> L: netdev@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/net/microchip,lan865x.yaml F: drivers/net/ethernet/microchip/lan865x.c MICROCHIP LAN87xx/LAN937x T1 PHY DRIVER
Add DT bindings for Microchip's LAN865X 10BASE-T1S MACPHY. The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver integrated into the LAN8650/1. The communication between the Host and the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6). Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> --- .../bindings/net/microchip,lan865x.yaml | 101 ++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 102 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml