| Message ID | 20231004182043.2309790-1-festevam@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] dt-bindings: watchdog: fsl,scu-wdt: Document imx8dl | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Rob, On Wed, Oct 4, 2023 at 3:21 PM Fabio Estevam <festevam@gmail.com> wrote: > > From: Fabio Estevam <festevam@denx.de> > > imx8dxl also contains the SCU watchdog block. > > Add an entry for 'fsl,imx8dxl-sc-wdt'. > > Cc: Wim Van Sebroeck <wim@linux-watchdog.org> > Cc: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Fabio Estevam <festevam@denx.de> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > Changes since v1: > - Sent it as a standalone patch to the DT folks. > - Collected Conor's ack. Can this go through your tree?
On Thu, Oct 19, 2023 at 11:54:34PM -0300, Fabio Estevam wrote: > Hi Rob, > > On Wed, Oct 4, 2023 at 3:21 PM Fabio Estevam <festevam@gmail.com> wrote: > > > > From: Fabio Estevam <festevam@denx.de> > > > > imx8dxl also contains the SCU watchdog block. > > > > Add an entry for 'fsl,imx8dxl-sc-wdt'. > > > > Cc: Wim Van Sebroeck <wim@linux-watchdog.org> > > Cc: Guenter Roeck <linux@roeck-us.net> > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > Changes since v1: > > - Sent it as a standalone patch to the DT folks. > > - Collected Conor's ack. > > Can this go through your tree? I'm waiting to see if Guenter picks it up, but will if he doesn't. Rob
On 10/4/23 11:20, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > imx8dxl also contains the SCU watchdog block. > > Add an entry for 'fsl,imx8dxl-sc-wdt'. > > Cc: Wim Van Sebroeck <wim@linux-watchdog.org> > Cc: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Fabio Estevam <festevam@denx.de> > Acked-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > Changes since v1: > - Sent it as a standalone patch to the DT folks. > - Collected Conor's ack. > > Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml > index 47701248cd8d..8b7aa922249b 100644 > --- a/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml > @@ -18,7 +18,9 @@ allOf: > properties: > compatible: > items: > - - const: fsl,imx8qxp-sc-wdt > + - enum: > + - fsl,imx8dxl-sc-wdt > + - fsl,imx8qxp-sc-wdt > - const: fsl,imx-sc-wdt > > required:
On 10/22/23 14:15, Rob Herring wrote: > On Thu, Oct 19, 2023 at 11:54:34PM -0300, Fabio Estevam wrote: >> Hi Rob, >> >> On Wed, Oct 4, 2023 at 3:21 PM Fabio Estevam <festevam@gmail.com> wrote: >>> >>> From: Fabio Estevam <festevam@denx.de> >>> >>> imx8dxl also contains the SCU watchdog block. >>> >>> Add an entry for 'fsl,imx8dxl-sc-wdt'. >>> >>> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> >>> Cc: Guenter Roeck <linux@roeck-us.net> >>> Signed-off-by: Fabio Estevam <festevam@denx.de> >>> Acked-by: Conor Dooley <conor.dooley@microchip.com> >>> --- >>> Changes since v1: >>> - Sent it as a standalone patch to the DT folks. >>> - Collected Conor's ack. >> >> Can this go through your tree? > > I'm waiting to see if Guenter picks it up, but will if he doesn't. > > Rob Watchdog patches are picked up by Wim; I only provide Reviewed-by: tags. Guenter
On Wed, 04 Oct 2023 15:20:43 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > imx8dxl also contains the SCU watchdog block. > > Add an entry for 'fsl,imx8dxl-sc-wdt'. > > Cc: Wim Van Sebroeck <wim@linux-watchdog.org> > Cc: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Fabio Estevam <festevam@denx.de> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > Changes since v1: > - Sent it as a standalone patch to the DT folks. > - Collected Conor's ack. > > Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > It seems watchdog bindings aren't getting applied, so I've applied it. Wim, please take watchdog bindings in the future unless noted otherwise. Rob
diff --git a/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml index 47701248cd8d..8b7aa922249b 100644 --- a/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml @@ -18,7 +18,9 @@ allOf: properties: compatible: items: - - const: fsl,imx8qxp-sc-wdt + - enum: + - fsl,imx8dxl-sc-wdt + - fsl,imx8qxp-sc-wdt - const: fsl,imx-sc-wdt required: