Message ID | 20220919104816.4075019-2-piyush.mehta@amd.com |
---|---|
State | Superseded, archived |
Headers | show |
Series | usb: dwc3: core: Enable GUCTL1 bit 10 for fixing crc error after resume | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On 19/09/2022 12:48, Piyush Mehta wrote: > From: Piyush Mehta <piyush.mehta@xilinx.com> > > Add a new 'snps,resume-hs-terminations' DT quirk to dwc3 core to resolved > issue of CRC failed error. > > On the resume path, U3/U2 exit controller fails to send proper CRC checksum > in CRC5 field. As result Transaction Error is generated. Enabling bit 10 of > GUCTL1 will correct this problem. > > When this bit is set to '1', the UTMI/ULPI opmode will be changed to > "normal" along with HS terminations and term/xcvr select signals after EOR. > This option is to support certain legacy UTMI/ULPI PHYs. > > Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com> > Signed-off-by: Piyush Mehta <piyush.mehta@amd.com> Only one SoB is needed for one person. For example switch to amd.com (with ownership of commit) or skip second SoB. > --- > Changes in V2: > - Addressed Krzysztof Kozlowski review comments > - Update the quirk name and No underscores in properties. > - Modified the quirk description. > Link: https://lore.kernel.org/all/e15168ac-b5a1-0c15-cfb3-34fb518e737f@linaro.org/ > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index 1779d08ba1c0..534f5b42e056 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -234,6 +234,13 @@ properties: avoid -EPROTO errors with usbhid on some devices (Hikey 970). type: boolean + snps,resume-hs-terminations: + description: + Fix the issue of HS terminations CRC error on resume by enabling this + quirk. When set, all the termsel, xcvrsel, opmode becomes 0 during end + of resume. This option is to support certain legacy ULPI PHYs. + type: boolean + snps,is-utmi-l1-suspend: description: True when DWC3 asserts output signal utmi_l1_suspend_n, false when