| Message ID | 20210819182544.224121-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] dt-bindings: hwmon: merge max1619 into trivial devices | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 8 lines checked |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote: > Ther Maxim max1619 bindings are trivial, so simply merge it into > trivial-devices.yaml. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Do we have a general guideline on how to handle such trivial bindings ? I normally leave it up to the driver author to decide one way or another. Guenter > --- > Documentation/devicetree/bindings/hwmon/max1619.txt | 12 ------------ > .../devicetree/bindings/trivial-devices.yaml | 2 ++ > 2 files changed, 2 insertions(+), 12 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/hwmon/max1619.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/max1619.txt b/Documentation/devicetree/bindings/hwmon/max1619.txt > deleted file mode 100644 > index c70dbbe1e56f..000000000000 > --- a/Documentation/devicetree/bindings/hwmon/max1619.txt > +++ /dev/null > @@ -1,12 +0,0 @@ > -Bindings for MAX1619 Temperature Sensor > - > -Required properties: > -- compatible : "maxim,max1619" > -- reg : I2C address, one of 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, or > - 0x4d, 0x4e > - > -Example: > - temp@4c { > - compatible = "maxim,max1619"; > - reg = <0x4c>; > - }; > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index fb03febc6616..1e4b3464d734 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -147,6 +147,8 @@ properties: > - maxim,ds1803-100 > # Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs > - maxim,max1237 > + # Temperature Sensor, I2C interface > + - maxim,max1619 > # 10-bit 10 kOhm linear programable voltage divider > - maxim,max5481 > # 10-bit 50 kOhm linear programable voltage divider >
On Fri, Aug 20, 2021 at 9:26 AM Guenter Roeck <linux@roeck-us.net> wrote: > > On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote: > > Ther Maxim max1619 bindings are trivial, so simply merge it into > > trivial-devices.yaml. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > Do we have a general guideline on how to handle such trivial bindings ? Not really. I debate (with myself) just getting rid of it as I suspect lots of bindings are just incomplete. Like should supplies be required? But it's convenient to have and not duplicate a bunch of boilerplate. > I normally leave it up to the driver author to decide one way or another. Me too. This one looks simple enough to be in trivial-devices, so I'll take having a schema over not. Rob
On Thu, 19 Aug 2021 20:25:43 +0200, Krzysztof Kozlowski wrote: > Ther Maxim max1619 bindings are trivial, so simply merge it into > trivial-devices.yaml. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > Documentation/devicetree/bindings/hwmon/max1619.txt | 12 ------------ > .../devicetree/bindings/trivial-devices.yaml | 2 ++ > 2 files changed, 2 insertions(+), 12 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/hwmon/max1619.txt > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/hwmon/max1619.txt b/Documentation/devicetree/bindings/hwmon/max1619.txt deleted file mode 100644 index c70dbbe1e56f..000000000000 --- a/Documentation/devicetree/bindings/hwmon/max1619.txt +++ /dev/null @@ -1,12 +0,0 @@ -Bindings for MAX1619 Temperature Sensor - -Required properties: -- compatible : "maxim,max1619" -- reg : I2C address, one of 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, or - 0x4d, 0x4e - -Example: - temp@4c { - compatible = "maxim,max1619"; - reg = <0x4c>; - }; diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index fb03febc6616..1e4b3464d734 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -147,6 +147,8 @@ properties: - maxim,ds1803-100 # Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs - maxim,max1237 + # Temperature Sensor, I2C interface + - maxim,max1619 # 10-bit 10 kOhm linear programable voltage divider - maxim,max5481 # 10-bit 50 kOhm linear programable voltage divider
Ther Maxim max1619 bindings are trivial, so simply merge it into trivial-devices.yaml. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Documentation/devicetree/bindings/hwmon/max1619.txt | 12 ------------ .../devicetree/bindings/trivial-devices.yaml | 2 ++ 2 files changed, 2 insertions(+), 12 deletions(-) delete mode 100644 Documentation/devicetree/bindings/hwmon/max1619.txt