diff mbox series

[v4,2/3] dt-bindings: eeprom: at25: Add Anvo ANV32E61W

Message ID 20190808172616.11728-2-krzk@kernel.org
State Superseded, archived
Headers show
Series [v4,1/3] dt-bindings: vendor-prefixes: Add Anvo-Systems | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Krzysztof Kozlowski Aug. 8, 2019, 5:26 p.m. UTC 
Document the compatible for ANV32E61W EEPROM chip.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>

---

New patch
---
 Documentation/devicetree/bindings/eeprom/at25.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Frieder Schrempf Aug. 8, 2019, 6:09 p.m. UTC | #1 
On 08.08.19 19:26, Krzysztof Kozlowski wrote:
> Document the compatible for ANV32E61W EEPROM chip.

This chip is actually not an EEPROM, but a SPI nvSRAM. It can be 
interfaced by the at25 driver similar to an EEPROM. This is not the 
ideal solution, but it works until there's a proper driver for such 
chips. Maybe you can add some of these details to the commit message 
here. Also there is more information on this topic here: 
https://patchwork.ozlabs.org/patch/1043950/.

> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> 
> ---
> 
> New patch
> ---
>   Documentation/devicetree/bindings/eeprom/at25.txt | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at25.txt b/Documentation/devicetree/bindings/eeprom/at25.txt
> index b3bde97dc199..42577dd113dd 100644
> --- a/Documentation/devicetree/bindings/eeprom/at25.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at25.txt
> @@ -3,6 +3,7 @@ EEPROMs (SPI) compatible with Atmel at25.
>   Required properties:
>   - compatible : Should be "<vendor>,<type>", and generic value "atmel,at25".
>     Example "<vendor>,<type>" values:
> +    "anvo,anv32e61w"
>       "microchip,25lc040"
>       "st,m95m02"
>       "st,m95256"
>
Krzysztof Kozlowski Aug. 12, 2019, 6:43 a.m. UTC | #2 
On Thu, 8 Aug 2019 at 20:09, Schrempf Frieder
<frieder.schrempf@kontron.de> wrote:
>
> On 08.08.19 19:26, Krzysztof Kozlowski wrote:
> > Document the compatible for ANV32E61W EEPROM chip.
>
> This chip is actually not an EEPROM, but a SPI nvSRAM. It can be
> interfaced by the at25 driver similar to an EEPROM. This is not the
> ideal solution, but it works until there's a proper driver for such
> chips. Maybe you can add some of these details to the commit message
> here. Also there is more information on this topic here:
> https://patchwork.ozlabs.org/patch/1043950/.

Indeed, I'll correct the description of commit.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/eeprom/at25.txt b/Documentation/devicetree/bindings/eeprom/at25.txt
index b3bde97dc199..42577dd113dd 100644
--- a/Documentation/devicetree/bindings/eeprom/at25.txt
+++ b/Documentation/devicetree/bindings/eeprom/at25.txt
@@ -3,6 +3,7 @@  EEPROMs (SPI) compatible with Atmel at25.
 Required properties:
 - compatible : Should be "<vendor>,<type>", and generic value "atmel,at25".
   Example "<vendor>,<type>" values:
+    "anvo,anv32e61w"
     "microchip,25lc040"
     "st,m95m02"
     "st,m95256"