| Message ID | 20171123125600.41562-2-jan.tuerk@emtrion.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add basic support for emtrion emCON-MX6 modules | expand |
Hi Jan, On Thu, Nov 23, 2017 at 10:55 AM, Jan Tuerk <jan.tuerk@emtrion.com> wrote: > The Emerging Display Technology ETM0700G0BDH6 is exactly > the same display as the ETM0700G0DH6, exept the pixelclock > polarity. Therefore re-use the ETM0700G0DH6 modes. It is > used by default on emtrion Avari based development kits. > > Signed-off-by: Jan Tuerk <jan.tuerk@emtrion.com> Please run ./scripts/checkpatch.pl on your patch. Currently it gives: total: 18 errors, 13 warnings, 39 lines checked Please fix and resend. Also, you could try git send-email in the next time. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jan, On Thu, Nov 23, 2017 at 1:18 PM, Türk, Jan <Jan.Tuerk@emtrion.de> wrote: > Hi Fabio, > > I've used git send-email and tested the patches by checkpatch.pl before without any problems. > So it might have been touched by the mail server, so can you send me your checkpatch.pl log (directly)? Take a look at your patch here: https://patchwork.kernel.org/patch/10072765/ Click in the "patch" link and download it. You will notice that all tabs have been converted into spaces. checkpatch will warn about it. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Fabio, (and all others) > Von: Fabio Estevam [mailto:festevam@gmail.com] > Gesendet: Freitag, 24. November 2017 15:22 > Betreff: Re: [PATCH 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6 > > Hi Jan, > > On Thu, Nov 23, 2017 at 1:18 PM, Türk, Jan <Jan.Tuerk@emtrion.de> wrote: > > Hi Fabio, > > > > I've used git send-email and tested the patches by checkpatch.pl before > without any problems. > > So it might have been touched by the mail server, so can you send me your > checkpatch.pl log (directly)? > > Take a look at your patch here: https://patchwork.kernel.org/patch/10072765/ > > Click in the "patch" link and download it. You will notice that all tabs have been > converted into spaces. > > checkpatch will warn about it. thanks for your feedback. Meanwhile I also did some investigation and found out that our SMTP modified the message in the redmond style. I'll resend the patches as soon as the issue has been solved. emtrion GmbH Kreativpark - Alter Schlachthof 45 76131 Karlsruhe GERMANY http://www.emtrion.de _______________________________________ Amtsgericht Mannheim HRB 110 300 Geschäftsführer: Dieter Baur, Ramona Maurer
On Thu, Nov 23, 2017 at 01:55:51PM +0100, Jan Tuerk wrote: > The Emerging Display Technology ETM0700G0BDH6 is exactly > the same display as the ETM0700G0DH6, exept the pixelclock > polarity. Therefore re-use the ETM0700G0DH6 modes. It is > used by default on emtrion Avari based development kits. > > Signed-off-by: Jan Tuerk <jan.tuerk@emtrion.com> > --- > .../bindings/display/panel/edt,etm0700g0bdh6.txt | 9 +++++++++ > drivers/gpu/drm/panel/panel-simple.c | 15 +++++++++++++++ > 2 files changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt b/Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt > new file mode 100644 > index 000000000000..099e30bfa17f > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt > @@ -0,0 +1,9 @@ > +Emerging Display Technology Corp. ETM0700G0BDH6 7.0" WVGA TFT LCD panel > + > +Required properties: > + compatible: "edt,etm0700g0bdh6" > + > +This panel is exactly the same as ETM0700G0DH6 except the pixelclock polarity. Perhaps document them together. > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt b/Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt new file mode 100644 index 000000000000..099e30bfa17f --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt @@ -0,0 +1,9 @@ +Emerging Display Technology Corp. ETM0700G0BDH6 7.0" WVGA TFT LCD panel + +Required properties: + compatible: "edt,etm0700g0bdh6" + +This panel is exactly the same as ETM0700G0DH6 except the pixelclock polarity. + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index b7c4709f7b34..42442034b53e 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -886,6 +886,18 @@ static const struct panel_desc edt_etm0700g0dh6 = { .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE, }; +static const struct panel_desc edt_etm0700g0bdh6 = { + .modes = &edt_etm0700g0dh6_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 152, + .height = 91, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE, +}; + static const struct drm_display_mode foxlink_fl500wvr00_a0t_mode = { .clock = 32260, .hdisplay = 800, @@ -2029,6 +2041,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "edt,etm0700g0dh6", .data = &edt_etm0700g0dh6, }, { + .compatible = "edt,etm0700g0bdh6", + .data = &edt_etm0700g0bdh6, + }, { .compatible = "foxlink,fl500wvr00-a0t", .data = &foxlink_fl500wvr00_a0t, }, {
The Emerging Display Technology ETM0700G0BDH6 is exactly the same display as the ETM0700G0DH6, exept the pixelclock polarity. Therefore re-use the ETM0700G0DH6 modes. It is used by default on emtrion Avari based development kits. Signed-off-by: Jan Tuerk <jan.tuerk@emtrion.com> --- .../bindings/display/panel/edt,etm0700g0bdh6.txt | 9 +++++++++ drivers/gpu/drm/panel/panel-simple.c | 15 +++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt -- 2.11.0 emtrion GmbH Kreativpark - Alter Schlachthof 45 76131 Karlsruhe GERMANY http://www.emtrion.de