| Message ID | 17ba2dfdb3d25bf1b5b4ed9f858b6e28902bedbe.1703127334.git.alkuor@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v4,1/2] dt-bindings: hwmon: (lm75) Add AMS AS6200 temperature sensor | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 23/12/2023 17:21, Abdel Alkuor wrote: > as6200 is a temperature sensor with a range between -40°C to > 125°C degrees and an accuracy of ±0.4°C degree between 0 > and 65°C and ±1°C for the other ranges. > > Signed-off-by: Abdel Alkuor <alkuor@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, Dec 23, 2023 at 11:21:58AM -0500, Abdel Alkuor wrote: > as6200 is a temperature sensor with a range between -40°C to > 125°C degrees and an accuracy of ±0.4°C degree between 0 > and 65°C and ±1°C for the other ranges. > > Signed-off-by: Abdel Alkuor <alkuor@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Applied. Thanks, Guenter
On Sat, Dec 23, 2023 at 11:21:59AM -0500, Abdel Alkuor wrote: > as6200 is a temperature sensor with 0.0625°C resolution and a > range between -40°C to 125°C. > > By default, the driver configures as6200 as following: > - Converstion rate: 8 Hz > - Conversion mode: continuous > - Consecutive fault counts: 4 samples > - Alert state: high polarity > - Alert mode: comparator mode > > Interrupt is supported for the alert pin. > > Datasheet: https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf > Signed-off-by: Abdel Alkuor <alkuor@gmail.com> Applied. Side note below. > + Datasheet: Publicly available at the AMS website > + > + https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf Apparently checkpatch doesn't like this way of pointing to a datasheet anymore and reacts with a warning, demanding the use of Link: or similar. I don't think this is appropriate, so I guess we see the first instance of to-be-ignored checkpatch warnings ins the hwmon subsystem. Guenter
On Sun, Dec 31, 2023 at 10:17:05AM -0800, Guenter Roeck wrote: > On Sat, Dec 23, 2023 at 11:21:59AM -0500, Abdel Alkuor wrote: > > as6200 is a temperature sensor with 0.0625°C resolution and a > > range between -40°C to 125°C. > > > > By default, the driver configures as6200 as following: > > - Converstion rate: 8 Hz > > - Conversion mode: continuous > > - Consecutive fault counts: 4 samples > > - Alert state: high polarity > > - Alert mode: comparator mode > > > > Interrupt is supported for the alert pin. > > > > Datasheet: https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf > > Signed-off-by: Abdel Alkuor <alkuor@gmail.com> > > Applied. Side note below. > > > + Datasheet: Publicly available at the AMS website > > + > > + https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf > > Apparently checkpatch doesn't like this way of pointing to a datasheet anymore > and reacts with a warning, demanding the use of Link: or similar. > I don't think this is appropriate, so I guess we see the first instance of > to-be-ignored checkpatch warnings ins the hwmon subsystem. > Ah, no, this was a tag in the commit message, which is indeeed inappropriate. I dropped it from the commit. Guenter
diff --git a/Documentation/devicetree/bindings/hwmon/lm75.yaml b/Documentation/devicetree/bindings/hwmon/lm75.yaml index 0b69897f0c63..ed269e428a3d 100644 --- a/Documentation/devicetree/bindings/hwmon/lm75.yaml +++ b/Documentation/devicetree/bindings/hwmon/lm75.yaml @@ -14,6 +14,7 @@ properties: compatible: enum: - adi,adt75 + - ams,as6200 - atmel,at30ts74 - dallas,ds1775 - dallas,ds75 @@ -48,10 +49,28 @@ properties: vs-supply: description: phandle to the regulator that provides the +VS supply + interrupts: + maxItems: 1 + required: - compatible - reg +allOf: + - if: + not: + properties: + compatible: + contains: + enum: + - ams,as6200 + - ti,tmp100 + - ti,tmp101 + - ti,tmp112 + then: + properties: + interrupts: false + additionalProperties: false examples: @@ -66,3 +85,17 @@ examples: vs-supply = <&vs>; }; }; + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + temperature-sensor@48 { + compatible = "ams,as6200"; + reg = <0x48>; + vs-supply = <&vs>; + interrupt-parent = <&gpio1>; + interrupts = <17 IRQ_TYPE_EDGE_BOTH>; + }; + };
as6200 is a temperature sensor with a range between -40°C to 125°C degrees and an accuracy of ±0.4°C degree between 0 and 65°C and ±1°C for the other ranges. Signed-off-by: Abdel Alkuor <alkuor@gmail.com> --- Changes in v4: - Add chips that support interrupt Changes in v3: - Enable interrupt property conditionally based on the chips that support it. - Fix alignment for the added example Changes in v2: - Incorporate as6200 into lm75 bindings .../devicetree/bindings/hwmon/lm75.yaml | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+)