| Message ID | 20220909133718.388213-1-Ibrahim.Tilki@analog.com |
|---|---|
| Headers | show |
| Series | hwmon: Add max31760 fan speed controller | expand |
On 9/9/22 06:37, Ibrahim Tilki wrote: > MAX31760 is a precision fan speed controller with nonvolatile lookup table. > Device has one internal and one external temperature sensor support. > Controls two fans and measures their speeds. Generates hardware alerts when > programmable max and critical temperatures are exceeded. > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com> > Reviewed-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com> Since you'll have to resend this anyway to address the devicetree failures: [ ... ] > + > +static int max31760_write(struct device *dev, enum hwmon_sensor_types type, > + u32 attr, int channel, long val) > +{ > + struct max31760_state *state = dev_get_drvdata(dev); > + unsigned int pwm_index; > + unsigned int reg_temp; > + int temp; > + u8 reg_val[2]; > + > + switch (type) { > + case hwmon_temp: > + switch (attr) { > + case hwmon_temp_max: > + reg_temp = REG_TEMP_MAX(channel); > + break; > + case hwmon_temp_crit: > + reg_temp = REG_TEMP_CRIT(channel); > + break; > + default: > + return -EOPNOTSUPP; > + } > + > + temp = TEMP11_TO_REG(val); > + reg_val[0] = temp >> 8; > + reg_val[1] = temp & 0xFF; > + > + return regmap_bulk_write(state->regmap, reg_temp, reg_val, 2); > + case hwmon_fan: > + switch (attr) { > + case hwmon_fan_enable: > + if (val == 0) > + return regmap_clear_bits(state->regmap, REG_CR3, BIT(channel)); > + > + if (val == 1) > + return regmap_set_bits(state->regmap, REG_CR3, BIT(channel)); > + > + return -EOPNOTSUPP; This should return -EINVAL. > + default: > + return -EOPNOTSUPP; > + } > + case hwmon_pwm: > + switch (attr) { > + case hwmon_pwm_input: > + if (val < 0 || val > 255) > + return -EINVAL; > + > + return regmap_write(state->regmap, REG_PWMR, val); > + case hwmon_pwm_enable: > + if (val == 1) > + return regmap_set_bits(state->regmap, REG_CR2, CR2_DFC); > + > + if (val == 2) > + return regmap_clear_bits(state->regmap, REG_CR2, CR2_DFC); > + > + return -EOPNOTSUPP; This should return -EINVAL (the _operation_ is supported, after all, but the written value is invalid). Thanks, Guenter
changes in v8: - use sizeof(*) - use DEFINE_SIMPLE_DEV_PM_OPS - remove __maybe_unused - remove of_match_ptr - dt-bindings: style fixes changes in v7: - make max31760_read_string static changes in v6: - update description of hwmon documentation - add hwmon documentation to index.rst changes in v5: - add dt-bindings documentation - add maintainer changes in v4: - use sysfs_emit instead of sprintf - use kstrtou8 for pwm - use closest match for pwm1_auto_point_temp_hyst changes in v3: - add regmap cache - remove pwm1_auto_point[1-48]_{temp,temp_hyst} attributes - add pwm1_auto_point_temp_hyst attribute changes in v2: - remove pulse_per_rev variable in tach_to_rpm - remove temperature max_hyst and crit_hyst - strict value checking for fan_enable and pwm_enable - do not clamp pwm value for Look-up table - add sysfs_attr_init call - add documentation Ibrahim Tilki (4): drivers: hwmon: Add max31760 fan speed controller driver docs: hwmon: add max31760 documentation dt-bindings: hwmon: Add bindings for max31760 MAINTAINERS: Add maintainer for hwmon/max31760 .../bindings/hwmon/adi,max31760.yaml | 44 ++ Documentation/hwmon/index.rst | 1 + Documentation/hwmon/max31760.rst | 77 +++ MAINTAINERS | 9 + drivers/hwmon/Kconfig | 12 + drivers/hwmon/Makefile | 1 + drivers/hwmon/max31760.c | 596 ++++++++++++++++++ 7 files changed, 740 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31760.yaml create mode 100644 Documentation/hwmon/max31760.rst create mode 100644 drivers/hwmon/max31760.c