mbox series

[v8,0/5] power: supply: MAX17040: Add IRQ for low level and alert SOC changes

Message ID 20191205154410.29462-1-matheus@castello.eng.br
Headers show
Series power: supply: MAX17040: Add IRQ for low level and alert SOC changes | expand

Message

Matheus Castello Dec. 5, 2019, 3:44 p.m. UTC
This series add IRQ handler for low level SOC alert, define a devicetree
binding attribute to configure the alert level threshold and check for
changes in SOC and power supply status for send uevents.

Max17043/17044 have a pin for alert host about low level state of charge and
this alert can be configured in a threshold from 1% up to 32% of SOC.

Thanks Krzysztof Kozlowski, Lee Jones, Rob Herring and Sebastian Reichel for
your time reviewing it.

Changes since v7:
(Suggested by Sebastian Reichel)
- Fix unrelated change
- Use device_property_read_u32() and simplify the code
- Check the irq and of_device_is_compatible in the first patch

Changes since v6:
(Suggested by Lee Jones)
- Use relative paths in documentation

Matheus Castello (5):
  power: supply: max17040: Add IRQ handler for low SOC alert
  dt-bindings: power: supply: Max17040: Add DT bindings for max17040
    fuel gauge
  devicetree: mfd: max14577: Add reference to max14040_battery.txt
    descriptions
  power: supply: max17040: Config alert SOC low level threshold from FDT
  power: supply: max17040: Send uevent in SOC and status change

 .../devicetree/bindings/mfd/max14577.txt      |   2 +
 .../power/supply/max17040_battery.txt         |  33 +++++
 drivers/power/supply/max17040_battery.c       | 130 +++++++++++++++++-
 3 files changed, 161 insertions(+), 4 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max17040_battery.txt

--
2.24.0.rc2

Comments

Krzysztof Kozlowski Dec. 6, 2019, 9:17 a.m. UTC | #1
On Thu, Dec 05, 2019 at 12:44:09PM -0300, Matheus Castello wrote:
> For configuration of fuel gauge alert for a low level state of charge
> interrupt we add a function to config level threshold and a device tree
> binding property to set it in flatned device tree node.
> 
> Now we can use "maxim,alert-low-soc-level" property with the values from
> 1% up to 32% to configure alert interrupt threshold.
> 
> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> ---
>  drivers/power/supply/max17040_battery.c | 52 ++++++++++++++++++++++++-
>  1 file changed, 51 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Sebastian Reichel Dec. 19, 2019, 12:52 a.m. UTC | #2
Hi,

On Thu, Dec 05, 2019 at 12:44:05PM -0300, Matheus Castello wrote:
> This series add IRQ handler for low level SOC alert, define a devicetree
> binding attribute to configure the alert level threshold and check for
> changes in SOC and power supply status for send uevents.
> 
> Max17043/17044 have a pin for alert host about low level state of charge and
> this alert can be configured in a threshold from 1% up to 32% of SOC.
> 
> Thanks Krzysztof Kozlowski, Lee Jones, Rob Herring and Sebastian Reichel for
> your time reviewing it.

Thanks, I queued all but the MFD patch to power-supply's for-next
branch.

-- Sebastian

> Changes since v7:
> (Suggested by Sebastian Reichel)
> - Fix unrelated change
> - Use device_property_read_u32() and simplify the code
> - Check the irq and of_device_is_compatible in the first patch
> 
> Changes since v6:
> (Suggested by Lee Jones)
> - Use relative paths in documentation
> 
> Matheus Castello (5):
>   power: supply: max17040: Add IRQ handler for low SOC alert
>   dt-bindings: power: supply: Max17040: Add DT bindings for max17040
>     fuel gauge
>   devicetree: mfd: max14577: Add reference to max14040_battery.txt
>     descriptions
>   power: supply: max17040: Config alert SOC low level threshold from FDT
>   power: supply: max17040: Send uevent in SOC and status change
> 
>  .../devicetree/bindings/mfd/max14577.txt      |   2 +
>  .../power/supply/max17040_battery.txt         |  33 +++++
>  drivers/power/supply/max17040_battery.c       | 130 +++++++++++++++++-
>  3 files changed, 161 insertions(+), 4 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> 
> --
> 2.24.0.rc2
>