| Message ID | c0265cafc608217fc614887580b08827b04b1c2d.1539598608.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Commit | 18593fa |
| Delegated to: | Joe Hershberger |
| Headers | show |
| Series | [U-Boot,1/2] net: mvpp2: fix polarity of PHY reset signal | expand |
On Mon, Oct 15, 2018 at 5:17 AM Baruch Siach <baruch@tkos.co.il> wrote: > > The default Linux PHY reset delay is 10ms. This is also the requirement > for Marvell 88E151x PHYs, which are likely to be used with this Ethernet > MAC. > > Cc: Stefan Chulski <stefanc@marvell.com> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
On 15.10.18 12:16, Baruch Siach wrote: > The default Linux PHY reset delay is 10ms. This is also the requirement > for Marvell 88E151x PHYs, which are likely to be used with this Ethernet > MAC. > > Cc: Stefan Chulski <stefanc@marvell.com> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > drivers/net/mvpp2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c > index b3b1fe1a0c41..f28b939b17dc 100644 > --- a/drivers/net/mvpp2.c > +++ b/drivers/net/mvpp2.c > @@ -4806,7 +4806,7 @@ static void mvpp2_gpio_init(struct mvpp2_port *port) > { > if (dm_gpio_is_valid(&port->phy_reset_gpio)) { > dm_gpio_set_value(&port->phy_reset_gpio, 1); > - udelay(1000); > + udelay(10000); > dm_gpio_set_value(&port->phy_reset_gpio, 0); > } > > Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan
Hi Baruch, https://patchwork.ozlabs.org/patch/984072/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe
diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c index b3b1fe1a0c41..f28b939b17dc 100644 --- a/drivers/net/mvpp2.c +++ b/drivers/net/mvpp2.c @@ -4806,7 +4806,7 @@ static void mvpp2_gpio_init(struct mvpp2_port *port) { if (dm_gpio_is_valid(&port->phy_reset_gpio)) { dm_gpio_set_value(&port->phy_reset_gpio, 1); - udelay(1000); + udelay(10000); dm_gpio_set_value(&port->phy_reset_gpio, 0); }
The default Linux PHY reset delay is 10ms. This is also the requirement for Marvell 88E151x PHYs, which are likely to be used with this Ethernet MAC. Cc: Stefan Chulski <stefanc@marvell.com> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- drivers/net/mvpp2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)