diff mbox series

[ovs-dev] tc: Change filter error to debug once

Message ID 1523433450-19081-1-git-send-email-roid@mellanox.com
State Accepted
Headers show
Series [ovs-dev] tc: Change filter error to debug once | expand

Commit Message

Roi Dayan April 11, 2018, 7:57 a.m. UTC 
Also update the message to be more correct.
Before this commit if there were tc rules that are not of type
flower the log was getting filled quickyl with errors about it
and always appeared to the user when dumping flows from user space.
This commit moves the error to debug and logs it only once.

Signed-off-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Paul Blakey <paulb@mellanox.com>
---
 lib/tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman April 11, 2018, 9:53 a.m. UTC | #1 
On Wed, Apr 11, 2018 at 10:57:30AM +0300, Roi Dayan wrote:
> Also update the message to be more correct.
> Before this commit if there were tc rules that are not of type
> flower the log was getting filled quickyl with errors about it
> and always appeared to the user when dumping flows from user space.
> This commit moves the error to debug and logs it only once.
> 
> Signed-off-by: Roi Dayan <roid@mellanox.com>
> Reviewed-by: Paul Blakey <paulb@mellanox.com>

Thanks Roi,

applied to master, branch-2.9 and branch-2.8.
diff mbox series

Patch

diff --git a/lib/tc.c b/lib/tc.c
index c446d8407810..8056aeb73385 100644
--- a/lib/tc.c
+++ b/lib/tc.c
@@ -959,7 +959,7 @@  parse_netlink_to_tc_flower(struct ofpbuf *reply, struct tc_flower *flower)
 
     kind = nl_attr_get_string(ta[TCA_KIND]);
     if (strcmp(kind, "flower")) {
-        VLOG_ERR_RL(&error_rl, "failed to parse filter: %s", kind);
+        VLOG_DBG_ONCE("Unsupported filter: %s", kind);
         return EPROTO;
     }