From patchwork Wed Apr 11 07:57:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 897076 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40LbxJ6S7Bz9s3B for ; Wed, 11 Apr 2018 17:57:40 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 41B7D957; Wed, 11 Apr 2018 07:57:39 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 1FDE28FF for ; Wed, 11 Apr 2018 07:57:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 1AF053CC for ; Wed, 11 Apr 2018 07:57:36 +0000 (UTC) Received: from Internal Mail-Server by MTLPINE1 (envelope-from roid@mellanox.com) with ESMTPS (AES256-SHA encrypted); 11 Apr 2018 10:58:42 +0300 Received: from r-vnc11.mtr.labs.mlnx (r-vnc11.mtr.labs.mlnx [10.208.0.123]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w3B7vVfF024633; Wed, 11 Apr 2018 10:57:32 +0300 From: Roi Dayan To: dev@openvswitch.org Date: Wed, 11 Apr 2018 10:57:30 +0300 Message-Id: <1523433450-19081-1-git-send-email-roid@mellanox.com> X-Mailer: git-send-email 2.7.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Simon Horman Subject: [ovs-dev] [PATCH] tc: Change filter error to debug once X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Also update the message to be more correct. Before this commit if there were tc rules that are not of type flower the log was getting filled quickyl with errors about it and always appeared to the user when dumping flows from user space. This commit moves the error to debug and logs it only once. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tc.c b/lib/tc.c index c446d8407810..8056aeb73385 100644 --- a/lib/tc.c +++ b/lib/tc.c @@ -959,7 +959,7 @@ parse_netlink_to_tc_flower(struct ofpbuf *reply, struct tc_flower *flower) kind = nl_attr_get_string(ta[TCA_KIND]); if (strcmp(kind, "flower")) { - VLOG_ERR_RL(&error_rl, "failed to parse filter: %s", kind); + VLOG_DBG_ONCE("Unsupported filter: %s", kind); return EPROTO; }