diff mbox

[OpenWrt-Devel,luci] luci-mod-admin-full: Add option to set anonymous_identity field

Message ID 1460046131-3843-1-git-send-email-kevin@koconnor.net
State Not Applicable
Headers show

Commit Message

Kevin O'Connor April 7, 2016, 4:22 p.m. UTC
Add support for setting the "anonymous_identity" field on EAP type
networks.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
---

I sent a similar request to the openwrt mailing list that adds support
to the hostapd.sh script.

---
 .../luasrc/model/cbi/admin_network/wifi.lua            | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Manuel Munz April 17, 2016, 9:32 a.m. UTC | #1
On 07.04.2016 18:22, Kevin O'Connor wrote:
> Add support for setting the "anonymous_identity" field on EAP type
> networks.
>
> Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
> ---
>

Tested, worked.

Reviewed-By: Manuel Munz <freifunk@somakoma.de>
John Crispin April 25, 2016, 3:37 p.m. UTC | #2
please send this as a PR against the luci tree on github

	John

On 07/04/2016 18:22, Kevin O'Connor wrote:
> Add support for setting the "anonymous_identity" field on EAP type
> networks.
> 
> Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
> ---
> 
> I sent a similar request to the openwrt mailing list that adds support
> to the hostapd.sh script.
> 
> ---
>  .../luasrc/model/cbi/admin_network/wifi.lua            | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua b/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua
> index 945512e..09763e8 100644
> --- a/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua
> +++ b/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua
> @@ -967,6 +967,24 @@ if hwtype == "atheros" or hwtype == "mac80211" or hwtype == "prism2" then
>  	identity:depends({mode="sta-wds", eap_type="tls", encryption="wpa2"})
>  	identity:depends({mode="sta-wds", eap_type="tls", encryption="wpa"})
>  
> +	anonymous_identity = s:taboption("encryption", Value, "anonymous_identity", translate("Anonymous Identity"))
> +	anonymous_identity:depends({mode="sta", eap_type="fast", encryption="wpa2"})
> +	anonymous_identity:depends({mode="sta", eap_type="fast", encryption="wpa"})
> +	anonymous_identity:depends({mode="sta", eap_type="peap", encryption="wpa2"})
> +	anonymous_identity:depends({mode="sta", eap_type="peap", encryption="wpa"})
> +	anonymous_identity:depends({mode="sta", eap_type="ttls", encryption="wpa2"})
> +	anonymous_identity:depends({mode="sta", eap_type="ttls", encryption="wpa"})
> +	anonymous_identity:depends({mode="sta-wds", eap_type="fast", encryption="wpa2"})
> +	anonymous_identity:depends({mode="sta-wds", eap_type="fast", encryption="wpa"})
> +	anonymous_identity:depends({mode="sta-wds", eap_type="peap", encryption="wpa2"})
> +	anonymous_identity:depends({mode="sta-wds", eap_type="peap", encryption="wpa"})
> +	anonymous_identity:depends({mode="sta-wds", eap_type="ttls", encryption="wpa2"})
> +	anonymous_identity:depends({mode="sta-wds", eap_type="ttls", encryption="wpa"})
> +	anonymous_identity:depends({mode="sta", eap_type="tls", encryption="wpa2"})
> +	anonymous_identity:depends({mode="sta", eap_type="tls", encryption="wpa"})
> +	anonymous_identity:depends({mode="sta-wds", eap_type="tls", encryption="wpa2"})
> +	anonymous_identity:depends({mode="sta-wds", eap_type="tls", encryption="wpa"})
> +
>  	password = s:taboption("encryption", Value, "password", translate("Password"))
>  	password:depends({mode="sta", eap_type="fast", encryption="wpa2"})
>  	password:depends({mode="sta", eap_type="fast", encryption="wpa"})
>
diff mbox

Patch

diff --git a/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua b/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua
index 945512e..09763e8 100644
--- a/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua
+++ b/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua
@@ -967,6 +967,24 @@  if hwtype == "atheros" or hwtype == "mac80211" or hwtype == "prism2" then
 	identity:depends({mode="sta-wds", eap_type="tls", encryption="wpa2"})
 	identity:depends({mode="sta-wds", eap_type="tls", encryption="wpa"})
 
+	anonymous_identity = s:taboption("encryption", Value, "anonymous_identity", translate("Anonymous Identity"))
+	anonymous_identity:depends({mode="sta", eap_type="fast", encryption="wpa2"})
+	anonymous_identity:depends({mode="sta", eap_type="fast", encryption="wpa"})
+	anonymous_identity:depends({mode="sta", eap_type="peap", encryption="wpa2"})
+	anonymous_identity:depends({mode="sta", eap_type="peap", encryption="wpa"})
+	anonymous_identity:depends({mode="sta", eap_type="ttls", encryption="wpa2"})
+	anonymous_identity:depends({mode="sta", eap_type="ttls", encryption="wpa"})
+	anonymous_identity:depends({mode="sta-wds", eap_type="fast", encryption="wpa2"})
+	anonymous_identity:depends({mode="sta-wds", eap_type="fast", encryption="wpa"})
+	anonymous_identity:depends({mode="sta-wds", eap_type="peap", encryption="wpa2"})
+	anonymous_identity:depends({mode="sta-wds", eap_type="peap", encryption="wpa"})
+	anonymous_identity:depends({mode="sta-wds", eap_type="ttls", encryption="wpa2"})
+	anonymous_identity:depends({mode="sta-wds", eap_type="ttls", encryption="wpa"})
+	anonymous_identity:depends({mode="sta", eap_type="tls", encryption="wpa2"})
+	anonymous_identity:depends({mode="sta", eap_type="tls", encryption="wpa"})
+	anonymous_identity:depends({mode="sta-wds", eap_type="tls", encryption="wpa2"})
+	anonymous_identity:depends({mode="sta-wds", eap_type="tls", encryption="wpa"})
+
 	password = s:taboption("encryption", Value, "password", translate("Password"))
 	password:depends({mode="sta", eap_type="fast", encryption="wpa2"})
 	password:depends({mode="sta", eap_type="fast", encryption="wpa"})