diff mbox

[U-Boot,3/3] sandbox: Introduce dummy remoteproc nodes

Message ID 1440437317-5178-4-git-send-email-nm@ti.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Nishanth Menon Aug. 24, 2015, 5:28 p.m. UTC
Introduce dummy devices for sandbox remoteproc device and enable it by
default

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/sandbox/dts/test.dts | 13 +++++++++++++
 configs/sandbox_defconfig |  2 ++
 2 files changed, 15 insertions(+)

Comments

Simon Glass Aug. 25, 2015, 5:04 a.m. UTC | #1
Hi Nishanth,

On 24 August 2015 at 11:28, Nishanth Menon <nm@ti.com> wrote:
> Introduce dummy devices for sandbox remoteproc device and enable it by
> default
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/sandbox/dts/test.dts | 13 +++++++++++++
>  configs/sandbox_defconfig |  2 ++
>  2 files changed, 15 insertions(+)
>
> diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
> index c948df8c864b..df9b71310dbe 100644
> --- a/arch/sandbox/dts/test.dts
> +++ b/arch/sandbox/dts/test.dts
> @@ -25,6 +25,8 @@
>                 usb0 = &usb_0;
>                 usb1 = &usb_1;
>                 usb2 = &usb_2;
> +               remoteproc1 = &rproc_1;
> +               remoteproc2 = &rproc_2;

Can you please put these in alpha order?

>         };
>
>         a-test {
> @@ -296,6 +298,17 @@
>                 status = "disabled";
>         };
>
> +
> +       rproc_1: rproc@1 {
> +               compatible = "sandbox,test-processor";
> +               remoteproc-name = "remoteproc-test-dev1";
> +       };
> +
> +       rproc_2: rproc@2 {
> +               compatible = "sandbox,test-processor";
> +               internal-memory-mapped;
> +               remoteproc-name = "remoteproc-test-dev2";
> +       };

And these should go after reset {} I think.

>  };
>
>  #include "sandbox_pmic.dtsi"
> diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
> index 874a26b572aa..4a2750c154bc 100644
> --- a/configs/sandbox_defconfig
> +++ b/configs/sandbox_defconfig
> @@ -54,3 +54,5 @@ CONFIG_LED_GPIO=y
>  CONFIG_SYSCON=y
>  CONFIG_REGMAP=y
>  CONFIG_DEVRES=y
> +CONFIG_DM_TESTPROC_SANDBOX=y

CONFIG_TESTPROC_SANDBOX

> +CONFIG_CMD_REMOTEPROC=y
> --
> 2.1.4
>

Regards,
Simon
Nishanth Menon Aug. 25, 2015, 3:47 p.m. UTC | #2
On 08/25/2015 12:04 AM, Simon Glass wrote:
> Hi Nishanth,
> 
> On 24 August 2015 at 11:28, Nishanth Menon <nm@ti.com> wrote:
>> Introduce dummy devices for sandbox remoteproc device and enable it by
>> default
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>>  arch/sandbox/dts/test.dts | 13 +++++++++++++
>>  configs/sandbox_defconfig |  2 ++
>>  2 files changed, 15 insertions(+)
>>
>> diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
>> index c948df8c864b..df9b71310dbe 100644
>> --- a/arch/sandbox/dts/test.dts
>> +++ b/arch/sandbox/dts/test.dts
>> @@ -25,6 +25,8 @@
>>                 usb0 = &usb_0;
>>                 usb1 = &usb_1;
>>                 usb2 = &usb_2;
>> +               remoteproc1 = &rproc_1;
>> +               remoteproc2 = &rproc_2;
> 
> Can you please put these in alpha order?

OK. will do.

> 
>>         };
>>
>>         a-test {
>> @@ -296,6 +298,17 @@
>>                 status = "disabled";
>>         };
>>
>> +
>> +       rproc_1: rproc@1 {
>> +               compatible = "sandbox,test-processor";
>> +               remoteproc-name = "remoteproc-test-dev1";
>> +       };
>> +
>> +       rproc_2: rproc@2 {
>> +               compatible = "sandbox,test-processor";
>> +               internal-memory-mapped;
>> +               remoteproc-name = "remoteproc-test-dev2";
>> +       };
> 
> And these should go after reset {} I think.

Ack.

> 
>>  };
>>
>>  #include "sandbox_pmic.dtsi"
>> diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
>> index 874a26b572aa..4a2750c154bc 100644
>> --- a/configs/sandbox_defconfig
>> +++ b/configs/sandbox_defconfig
>> @@ -54,3 +54,5 @@ CONFIG_LED_GPIO=y
>>  CONFIG_SYSCON=y
>>  CONFIG_REGMAP=y
>>  CONFIG_DEVRES=y
>> +CONFIG_DM_TESTPROC_SANDBOX=y
> 
> CONFIG_TESTPROC_SANDBOX

Ack.

[...]
diff mbox

Patch

diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index c948df8c864b..df9b71310dbe 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -25,6 +25,8 @@ 
 		usb0 = &usb_0;
 		usb1 = &usb_1;
 		usb2 = &usb_2;
+		remoteproc1 = &rproc_1;
+		remoteproc2 = &rproc_2;
 	};
 
 	a-test {
@@ -296,6 +298,17 @@ 
 		status = "disabled";
 	};
 
+
+	rproc_1: rproc@1 {
+		compatible = "sandbox,test-processor";
+		remoteproc-name = "remoteproc-test-dev1";
+	};
+
+	rproc_2: rproc@2 {
+		compatible = "sandbox,test-processor";
+		internal-memory-mapped;
+		remoteproc-name = "remoteproc-test-dev2";
+	};
 };
 
 #include "sandbox_pmic.dtsi"
diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index 874a26b572aa..4a2750c154bc 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -54,3 +54,5 @@  CONFIG_LED_GPIO=y
 CONFIG_SYSCON=y
 CONFIG_REGMAP=y
 CONFIG_DEVRES=y
+CONFIG_DM_TESTPROC_SANDBOX=y
+CONFIG_CMD_REMOTEPROC=y