| Message ID | 20230508131045.9399-7-Zeynep.Arslanbenzer@analog.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add MAX77643/MAX77654/MAX77658/MAX77659 PMIC Support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 08 May 2023 16:10:44 +0300, Zeynep Arslanbenzer wrote: > Add ADI MAX77658 devicetree document. > > Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > --- > .../devicetree/bindings/mfd/adi,max77658.yaml | 160 ++++++++++++++++++ > 1 file changed, 160 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/adi,max77658.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/mfd/adi,max77658.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/power/supply/adi,max77658-charger.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/adi,max77658.example.dtb: pmic@48: charger: False schema does not allow {'compatible': ['adi,max77658-charger'], 'monitored-battery': [[2]], 'adi,input-current-limit-microamp': [[475000]]} From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/adi,max77658.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/adi,max77658.example.dtb: pmic@48: fuel-gauge: False schema does not allow {'compatible': ['adi,max77658-battery'], 'monitored-battery': [[2]], 'adi,valrt-min-microvolt': [[0]], 'adi,valrt-max-microvolt': [[5100000]], 'adi,ialrt-min-microamp': [[4294962296]], 'adi,ialrt-max-microamp': [[5000]]} From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/adi,max77658.yaml Documentation/devicetree/bindings/mfd/adi,max77658.example.dtb: /example-0/i2c/pmic@48/charger: failed to match any schema with compatible: ['adi,max77658-charger'] Documentation/devicetree/bindings/mfd/adi,max77658.example.dtb: /example-0/i2c/pmic@48/fuel-gauge: failed to match any schema with compatible: ['adi,max77658-battery'] /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/adi,max77658.example.dtb: pmic@40: charger: False schema does not allow {'compatible': ['adi,max77659-charger'], 'monitored-battery': [[2]]} From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/adi,max77658.yaml Documentation/devicetree/bindings/mfd/adi,max77658.example.dtb: /example-1/i2c/pmic@40/charger: failed to match any schema with compatible: ['adi,max77659-charger'] See https://patchwork.ozlabs.org/patch/1778414 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 08/05/2023 15:10, Zeynep Arslanbenzer wrote: > Add ADI MAX77658 devicetree document. > > Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > --- > .../devicetree/bindings/mfd/adi,max77658.yaml | 160 ++++++++++++++++++ > 1 file changed, 160 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/adi,max77658.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/adi,max77658.yaml b/Documentation/devicetree/bindings/mfd/adi,max77658.yaml > new file mode 100644 > index 000000000000..4d6d87cd4b52 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/adi,max77658.yaml > @@ -0,0 +1,160 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/adi,max77658.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MAX77643/54/58/59 PMIC from ADI > + > +maintainers: > + - Nurettin Bolucu <Nurettin.Bolucu@analog.com> > + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > + > +description: | > + MAX77643, MAX77654, MAX77658 and MAX77659 devices are a family of ADI PMICs > + providing battery charging and power supply solutions for > + low-power applications. > + > + MAX77643 is a Power Management IC with 1 LDO regulator. > + > + MAX77654 is a Power Management IC with 2 LDO regulators and 1 charger. > + > + MAX77658 is a Power Management IC with 2 LDO regulators, 1 charger > + and 1 fuel gauge. > + > + MAX77659 is a Power Management IC with 1 LDO regulator and 1 charger. > + > +properties: > + compatible: > + enum: > + - adi,max77643 > + - adi,max77654 > + - adi,max77658 > + - adi,max77659 > + > + reg: > + items: > + - enum: [0x40, 0x48] > + > + interrupts: > + maxItems: 1 > + > + charger: > + $ref: /schemas/power/supply/adi,max77658-charger.yaml > + > + fuel-gauge: > + $ref: /schemas/power/supply/adi,max77658-battery.yaml > + > + regulators: > + type: object > + > + description: > + The regulators is represented as a sub-node of the PMIC node on the device tree. > + > + patternProperties: > + "^LDO[01]$": lowercase > + type: object > + $ref: /schemas/regulator/regulator.yaml > + additionalProperties: false > + description: > + LDO regulator > + > + properties: > + regulator-always-on: true > + regulator-boot-on: true Why nothing else is allowed? You have different voltages, so how can you configure their constraints if you do not allow them to be configured? Drop all properties and use unevaluatedProperties.. > + > + additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - adi,max77643 > + - adi,max77654 > + - adi,max77658 > + > + then: > + properties: > + reg: > + items: > + - const: 0x48 > + > + else: > + properties: > + reg: > + items: > + - const: 0x40 - if: ... then: properties: regulators: properties: LDO1: false > + > +required: > + - compatible > + - reg > + - interrupts Put required before allOf. > + > +additionalProperties: false > + > +examples: > + - | > + battery: battery-cell { > + compatible = "simple-battery"; > + alert-celsius = <0 100>; > + constant-charge-current-max-microamp = <15000>; > + }; > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + pmic@48 { > + compatible = "adi,max77658"; > + reg = <0x48>; > + interrupt-parent = <&gpio>; > + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; > + charger { > + compatible = "adi,max77658-charger"; > + monitored-battery = <&battery>; > + adi,input-current-limit-microamp = <475000>; > + }; > + regulators { > + LDO0 { > + regulator-boot-on; > + regulator-always-on; > + }; > + LDO1 { > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + fuel-gauge { > + compatible = "adi,max77658-battery"; > + monitored-battery = <&battery>; > + adi,valrt-min-microvolt = <0>; > + adi,valrt-max-microvolt = <5100000>; > + adi,ialrt-min-microamp = <(-5000)>; > + adi,ialrt-max-microamp = <5000>; > + }; > + }; > + }; > + > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + pmic@40 { > + compatible = "adi,max77659"; > + reg = <0x40>; > + interrupt-parent = <&gpio>; > + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; > + charger { > + compatible = "adi,max77659-charger"; > + monitored-battery = <&battery>; > + }; > + regulators { > + LDO0 { > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + }; > + }; Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/adi,max77658.yaml b/Documentation/devicetree/bindings/mfd/adi,max77658.yaml new file mode 100644 index 000000000000..4d6d87cd4b52 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/adi,max77658.yaml @@ -0,0 +1,160 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/adi,max77658.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MAX77643/54/58/59 PMIC from ADI + +maintainers: + - Nurettin Bolucu <Nurettin.Bolucu@analog.com> + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> + +description: | + MAX77643, MAX77654, MAX77658 and MAX77659 devices are a family of ADI PMICs + providing battery charging and power supply solutions for + low-power applications. + + MAX77643 is a Power Management IC with 1 LDO regulator. + + MAX77654 is a Power Management IC with 2 LDO regulators and 1 charger. + + MAX77658 is a Power Management IC with 2 LDO regulators, 1 charger + and 1 fuel gauge. + + MAX77659 is a Power Management IC with 1 LDO regulator and 1 charger. + +properties: + compatible: + enum: + - adi,max77643 + - adi,max77654 + - adi,max77658 + - adi,max77659 + + reg: + items: + - enum: [0x40, 0x48] + + interrupts: + maxItems: 1 + + charger: + $ref: /schemas/power/supply/adi,max77658-charger.yaml + + fuel-gauge: + $ref: /schemas/power/supply/adi,max77658-battery.yaml + + regulators: + type: object + + description: + The regulators is represented as a sub-node of the PMIC node on the device tree. + + patternProperties: + "^LDO[01]$": + type: object + $ref: /schemas/regulator/regulator.yaml + additionalProperties: false + description: + LDO regulator + + properties: + regulator-always-on: true + regulator-boot-on: true + + additionalProperties: false + +allOf: + - if: + properties: + compatible: + contains: + enum: + - adi,max77643 + - adi,max77654 + - adi,max77658 + + then: + properties: + reg: + items: + - const: 0x48 + + else: + properties: + reg: + items: + - const: 0x40 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + battery: battery-cell { + compatible = "simple-battery"; + alert-celsius = <0 100>; + constant-charge-current-max-microamp = <15000>; + }; + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + pmic@48 { + compatible = "adi,max77658"; + reg = <0x48>; + interrupt-parent = <&gpio>; + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; + charger { + compatible = "adi,max77658-charger"; + monitored-battery = <&battery>; + adi,input-current-limit-microamp = <475000>; + }; + regulators { + LDO0 { + regulator-boot-on; + regulator-always-on; + }; + LDO1 { + regulator-boot-on; + regulator-always-on; + }; + }; + fuel-gauge { + compatible = "adi,max77658-battery"; + monitored-battery = <&battery>; + adi,valrt-min-microvolt = <0>; + adi,valrt-max-microvolt = <5100000>; + adi,ialrt-min-microamp = <(-5000)>; + adi,ialrt-max-microamp = <5000>; + }; + }; + }; + + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + pmic@40 { + compatible = "adi,max77659"; + reg = <0x40>; + interrupt-parent = <&gpio>; + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; + charger { + compatible = "adi,max77659-charger"; + monitored-battery = <&battery>; + }; + regulators { + LDO0 { + regulator-boot-on; + regulator-always-on; + }; + }; + }; + };