Message ID | 20230508131045.9399-5-Zeynep.Arslanbenzer@analog.com |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | Add MAX77643/MAX77654/MAX77658/MAX77659 PMIC Support | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dt-meta-schema | fail | build log |
On Mon, 08 May 2023 16:10:42 +0300, Zeynep Arslanbenzer wrote: > Add ADI MAX77658 power supply devicetree document. > > Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > --- > .../power/supply/adi,max77658-battery.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/adi,max77658-battery.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: doc reference errors (make refcheckdocs): Documentation/devicetree/bindings/power/supply/adi,max77658-battery.yaml: Documentation/devicetree/bindings/mfd/adi,max77658.yaml See https://patchwork.ozlabs.org/patch/1778410 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 08/05/2023 15:10, Zeynep Arslanbenzer wrote: > Add ADI MAX77658 power supply devicetree document. > > Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > --- > .../power/supply/adi,max77658-battery.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/adi,max77658-battery.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/adi,max77658-battery.yaml b/Documentation/devicetree/bindings/power/supply/adi,max77658-battery.yaml > new file mode 100644 > index 000000000000..112296d2b1f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/adi,max77658-battery.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/adi,max77658-battery.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Battery for MAX77658 PMICs family from ADI > + > +maintainers: > + - Nurettin Bolucu <Nurettin.Bolucu@analog.com> > + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > + > +description: | > + This module is part of the MAX77658 MFD device. For more details > + see Documentation/devicetree/bindings/mfd/adi,max77658.yaml. > + > + The fuel gauge is represented as a sub-node of the PMIC node on the device tree. > + > +properties: > + compatible: > + const: adi,max77658-battery > + > + adi,valrt-min-microvolt: > + description: alert when battery voltage is lower than this value > + > + adi,valrt-max-microvolt: > + description: alert when battery voltage is higher than this value Use the same approach/solution as battery.yaml. > + > + adi,ialrt-min-microamp: > + description: alert when battery current is lower than this value > + > + adi,ialrt-max-microamp: > + description: alert when battery current is higher than this value Also here. > + > + monitored-battery: > + description: > > + This property must be a phandle to a node using the format described > + in battery.yaml, with the following properties being required: > + - alert-celsius > + > +required: > + - compatible > + - monitored-battery > + > +additionalProperties: false > + > +... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/supply/adi,max77658-battery.yaml b/Documentation/devicetree/bindings/power/supply/adi,max77658-battery.yaml new file mode 100644 index 000000000000..112296d2b1f4 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/adi,max77658-battery.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/adi,max77658-battery.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Battery for MAX77658 PMICs family from ADI + +maintainers: + - Nurettin Bolucu <Nurettin.Bolucu@analog.com> + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> + +description: | + This module is part of the MAX77658 MFD device. For more details + see Documentation/devicetree/bindings/mfd/adi,max77658.yaml. + + The fuel gauge is represented as a sub-node of the PMIC node on the device tree. + +properties: + compatible: + const: adi,max77658-battery + + adi,valrt-min-microvolt: + description: alert when battery voltage is lower than this value + + adi,valrt-max-microvolt: + description: alert when battery voltage is higher than this value + + adi,ialrt-min-microamp: + description: alert when battery current is lower than this value + + adi,ialrt-max-microamp: + description: alert when battery current is higher than this value + + monitored-battery: + description: > + This property must be a phandle to a node using the format described + in battery.yaml, with the following properties being required: + - alert-celsius + +required: + - compatible + - monitored-battery + +additionalProperties: false + +...