| Message ID | 1631872087-24416-2-git-send-email-rajpat@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add QSPI and QUPv3 DT nodes for SC7280 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, 17 Sep 2021 15:18:00 +0530, Rajesh Patil wrote: > Add compatible for sc7280 SoC. > > Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> > --- > Changes in V8: > - As per Doug's comments, added "qcom,sc7280-qspi" compatible > > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1529304 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi, On Fri, Sep 17, 2021 at 2:49 AM Rajesh Patil <rajpat@codeaurora.org> wrote: > > Add compatible for sc7280 SoC. > > Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> > --- > Changes in V8: > - As per Doug's comments, added "qcom,sc7280-qspi" compatible > > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > index ef5698f..31711fe 100644 > --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > @@ -21,7 +21,10 @@ allOf: > properties: > compatible: > items: > - - const: qcom,sdm845-qspi > + - enum: > + - qcom,sdm845-qspi > + - qcom,sc7280-qspi Other than the fact that the indentation is wrong (as Rob's bot found), this looks good to me. Feel free to add my Reviewed-by when you fix the indentation. In theory you could also be nice and add the sc7180-qspi at the same time, I think. -Doug
On 2021-09-18 01:32, Doug Anderson wrote: > Hi, > > On Fri, Sep 17, 2021 at 2:49 AM Rajesh Patil <rajpat@codeaurora.org> > wrote: >> >> Add compatible for sc7280 SoC. >> >> Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> >> --- >> Changes in V8: >> - As per Doug's comments, added "qcom,sc7280-qspi" compatible >> >> Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 >> ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> index ef5698f..31711fe 100644 >> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> @@ -21,7 +21,10 @@ allOf: >> properties: >> compatible: >> items: >> - - const: qcom,sdm845-qspi >> + - enum: >> + - qcom,sdm845-qspi >> + - qcom,sc7280-qspi > > Other than the fact that the indentation is wrong (as Rob's bot > found), this looks good to me. Feel free to add my Reviewed-by when > you fix the indentation. In theory you could also be nice and add the > sc7180-qspi at the same time, I think. > > -Doug Okay
On 2021-09-18 01:32, Doug Anderson wrote: > Hi, > > On Fri, Sep 17, 2021 at 2:49 AM Rajesh Patil <rajpat@codeaurora.org> > wrote: >> >> Add compatible for sc7280 SoC. >> >> Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> >> --- >> Changes in V8: >> - As per Doug's comments, added "qcom,sc7280-qspi" compatible >> >> Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 >> ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> index ef5698f..31711fe 100644 >> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> @@ -21,7 +21,10 @@ allOf: >> properties: >> compatible: >> items: >> - - const: qcom,sdm845-qspi >> + - enum: >> + - qcom,sdm845-qspi >> + - qcom,sc7280-qspi > > Other than the fact that the indentation is wrong (as Rob's bot > found), this looks good to me. Feel free to add my Reviewed-by when > you fix the indentation. In theory you could also be nice and add the > sc7180-qspi at the same time, I think. > > -Doug Adding dt-bindings for sc7180 will send in the follow-up patches.
diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml index ef5698f..31711fe 100644 --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml @@ -21,7 +21,10 @@ allOf: properties: compatible: items: - - const: qcom,sdm845-qspi + - enum: + - qcom,sdm845-qspi + - qcom,sc7280-qspi + - const: qcom,qspi-v1 reg:
Add compatible for sc7280 SoC. Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> --- Changes in V8: - As per Doug's comments, added "qcom,sc7280-qspi" compatible Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)