diff mbox series

[U-Boot,2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage

Message ID 20191107111122.13136-2-smoch@web.de
State Accepted
Commit f210cbc1f3d4f84baa595d83933369b4d6a529ea
Delegated to: Kever Yang
Headers show
Series [U-Boot,1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel | expand

Commit Message

Sören Moch Nov. 7, 2019, 11:11 a.m. UTC
The rk3399 VD_CENTER voltage domain is not subject to dynamic voltage
scaling. So the regulator reset voltage of 0.9V is used on this board.
Let u-boot initialize the center voltage to 0.95V as it is done for the
VD_LOGIC domain. This avoids instability and occasional linux kernel
Opses on this board.

Signed-off-by: Soeren Moch <smoch@web.de>
---
Cc: Kever Yang <kever.yang@rock-chips.com>
Cc: u-boot@lists.denx.de
---
 arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

--
2.17.1

Comments

Kever Yang Nov. 8, 2019, 3:23 a.m. UTC | #1
On 2019/11/7 下午7:11, Soeren Moch wrote:
> The rk3399 VD_CENTER voltage domain is not subject to dynamic voltage
> scaling. So the regulator reset voltage of 0.9V is used on this board.
> Let u-boot initialize the center voltage to 0.95V as it is done for the
> VD_LOGIC domain. This avoids instability and occasional linux kernel
> Opses on this board.
>
> Signed-off-by: Soeren Moch <smoch@web.de>
> =2D--
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: u-boot@lists.denx.de
> =2D--
>   arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 5 +++++

Reviewed-by: Kever Yang<kever.yang@rock-chips.com>

Thanks,
- Kever
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk33=
> 99-rockpro64-u-boot.dtsi
> index a073ea25f5..4648513ea9 100644
> =2D-- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> @@ -11,6 +11,11 @@
>   	};
>   };
>
> +&vdd_center {
> +	regulator-min-microvolt =3D <950000>;
> +	regulator-max-microvolt =3D <950000>;
> +};
> +
>   &vdd_log {
>   	regulator-init-microvolt =3D <950000>;
>   };
> =2D-
> 2.17.1
>
>
Kever Yang Nov. 18, 2019, 2:55 a.m. UTC | #2
On 2019/11/8 上午11:23, Kever Yang wrote:
>
> On 2019/11/7 下午7:11, Soeren Moch wrote:
>> The rk3399 VD_CENTER voltage domain is not subject to dynamic voltage
>> scaling. So the regulator reset voltage of 0.9V is used on this board.
>> Let u-boot initialize the center voltage to 0.95V as it is done for the
>> VD_LOGIC domain. This avoids instability and occasional linux kernel
>> Opses on this board.
>>
>> Signed-off-by: Soeren Moch <smoch@web.de>
>> =2D--
>> Cc: Kever Yang <kever.yang@rock-chips.com>
>> Cc: u-boot@lists.denx.de
>> =2D--
>>   arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 5 +++++
>
> Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
>
Applied to u-boot-rockchip master .

Thanks,
- Kever
> Thanks,
> - Kever
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
>> b/arch/arm/dts/rk33=
>> 99-rockpro64-u-boot.dtsi
>> index a073ea25f5..4648513ea9 100644
>> =2D-- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
>> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
>> @@ -11,6 +11,11 @@
>>       };
>>   };
>>
>> +&vdd_center {
>> +    regulator-min-microvolt =3D <950000>;
>> +    regulator-max-microvolt =3D <950000>;
>> +};
>> +
>>   &vdd_log {
>>       regulator-init-microvolt =3D <950000>;
>>   };
>> =2D-
>> 2.17.1
>>
>>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
index a073ea25f5..4648513ea9 100644
--- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
@@ -11,6 +11,11 @@ 
 	};
 };

+&vdd_center {
+	regulator-min-microvolt = <950000>;
+	regulator-max-microvolt = <950000>;
+};
+
 &vdd_log {
 	regulator-init-microvolt = <950000>;
 };