| Message ID | 20190909100646.24105-1-lukma@denx.de |
|---|---|
| State | Accepted |
| Commit | f18845c27ad86e118b074ce545ce685cb9a97561 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] spl: Introduce SPL_DM_SPI Kconfig define | expand |
Dear Tom, > This define indicates if DM_SPI shall be supported in SPL. This allows > proper operation of DM converted SPI drivers in SPL, which use > #if !CONFIG_IS_ENABLED(DM_SPI) to also support not yet DM/DTS > converted boards. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Tom, are there any issues preventing this patch from being applied to -master? > > --- > > Applied on top of -master branch: > SHA1: 448f11f7503995746a7b71e5e3b3a831c4651be9 > > This patch is a first step for converting SPI #defines to Kconfig. > It was a part of "CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*" patch: > https://patchwork.ozlabs.org/patch/1158141/ > > which in spite of not introducing the apparent build breaks, was > responsible for some deltas in SPL and U-Boot proper sizes (some > parts of SPI code was not compiled in). To fix those board/SoC access > to real HW is necessary as well as deep understanding of SPL SPI > requirements. > > --- > common/spl/Kconfig | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > index 7c3391cabe..183ecf6264 100644 > --- a/common/spl/Kconfig > +++ b/common/spl/Kconfig > @@ -683,6 +683,13 @@ config SPL_UBI > Enable support for loading payloads from UBI. See > README.ubispl for more info. > > +if SPL_DM > +config SPL_DM_SPI > + bool "Support SPI DM drivers in SPL" > + help > + Enable support for SPI DM drivers in SPL. > + > +endif > if SPL_UBI > config SPL_UBI_LOAD_BY_VOLNAME > bool "Support loading volumes by name" Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Mon, Sep 09, 2019 at 12:06:46PM +0200, Lukasz Majewski wrote: > This define indicates if DM_SPI shall be supported in SPL. This allows > proper operation of DM converted SPI drivers in SPL, which use > #if !CONFIG_IS_ENABLED(DM_SPI) to also support not yet DM/DTS converted > boards. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Applied to u-boot/master, thanks!
diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 7c3391cabe..183ecf6264 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -683,6 +683,13 @@ config SPL_UBI Enable support for loading payloads from UBI. See README.ubispl for more info. +if SPL_DM +config SPL_DM_SPI + bool "Support SPI DM drivers in SPL" + help + Enable support for SPI DM drivers in SPL. + +endif if SPL_UBI config SPL_UBI_LOAD_BY_VOLNAME bool "Support loading volumes by name"
This define indicates if DM_SPI shall be supported in SPL. This allows proper operation of DM converted SPI drivers in SPL, which use #if !CONFIG_IS_ENABLED(DM_SPI) to also support not yet DM/DTS converted boards. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- Applied on top of -master branch: SHA1: 448f11f7503995746a7b71e5e3b3a831c4651be9 This patch is a first step for converting SPI #defines to Kconfig. It was a part of "CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*" patch: https://patchwork.ozlabs.org/patch/1158141/ which in spite of not introducing the apparent build breaks, was responsible for some deltas in SPL and U-Boot proper sizes (some parts of SPI code was not compiled in). To fix those board/SoC access to real HW is necessary as well as deep understanding of SPL SPI requirements. --- common/spl/Kconfig | 7 +++++++ 1 file changed, 7 insertions(+)