diff mbox series

[U-Boot,v2] imx: Use a convenient default value for SYS_MALLOC_F_LEN

Message ID 20190503170504.4870-1-festevam@gmail.com
State Accepted
Commit 08919d381cf3d2adb2c2c15b9598767720ad3c7b
Delegated to: Stefano Babic
Headers show
Series [U-Boot,v2] imx: Use a convenient default value for SYS_MALLOC_F_LEN | expand

Commit Message

Fabio Estevam May 3, 2019, 5:05 p.m. UTC 
Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
simple-bus driver") causes some i.MX boards that were converted
to DM, such as warp7, to fail to boot.

As explained by Lukas Auer:

"With the patch, U-Boot probes the drivers for devices under simple-bus
device tree nodes in the pre-relocation device model. The default value
of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to
do this, causing it to hang."

Fix this problem by providing a convenient default value for
CONFIG_SYS_MALLOC_F_LEN.

Reported-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Suggested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Move the default setting to the main Kconfig and make it depend
on i.MX

 Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Pierre-Jean Texier May 3, 2019, 5:19 p.m. UTC | #1 
Hi Fabio,

Le 03/05/2019 à 19:05, Fabio Estevam a écrit :
> Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver") causes some i.MX boards that were converted
> to DM, such as warp7, to fail to boot.
>
> As explained by Lukas Auer:
>
> "With the patch, U-Boot probes the drivers for devices under simple-bus
> device tree nodes in the pre-relocation device model. The default value
> of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to
> do this, causing it to hang."
>
> Fix this problem by providing a convenient default value for
> CONFIG_SYS_MALLOC_F_LEN.
>
> Reported-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Suggested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Move the default setting to the main Kconfig and make it depend
> on i.MX
>
>   Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/Kconfig b/Kconfig
> index 7a5491bd67..fd4ff42c17 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -138,6 +138,8 @@ config SYS_MALLOC_F_LEN
>   	depends on SYS_MALLOC_F
>   	default 0x1000 if AM33XX
>   	default 0x2800 if SANDBOX
> +	default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
> +			   ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
>   	default 0x400
>   	help
>   	  Before relocation, memory is very limited on many platforms. Still,


Tested-by: Pierre-Jean Texier <pjtexier@koncepto.io>


Thanks

Pierre-Jean
Joris OFFOUGA May 3, 2019, 5:27 p.m. UTC | #2 
Hi Fabio,

Tested-by Joris Offouga <offougajoris@gmail.com>

BR,

Joris


Le ven. 3 mai 2019 à 19:20, Pierre-Jean Texier <pjtexier@koncepto.io> a
écrit :

> Hi Fabio,
>
> Le 03/05/2019 à 19:05, Fabio Estevam a écrit :
> > Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> > simple-bus driver") causes some i.MX boards that were converted
> > to DM, such as warp7, to fail to boot.
> >
> > As explained by Lukas Auer:
> >
> > "With the patch, U-Boot probes the drivers for devices under simple-bus
> > device tree nodes in the pre-relocation device model. The default value
> > of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory
> to
> > do this, causing it to hang."
> >
> > Fix this problem by providing a convenient default value for
> > CONFIG_SYS_MALLOC_F_LEN.
> >
> > Reported-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> > Suggested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> > Changes since v1:
> > - Move the default setting to the main Kconfig and make it depend
> > on i.MX
> >
> >   Kconfig | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/Kconfig b/Kconfig
> > index 7a5491bd67..fd4ff42c17 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -138,6 +138,8 @@ config SYS_MALLOC_F_LEN
> >       depends on SYS_MALLOC_F
> >       default 0x1000 if AM33XX
> >       default 0x2800 if SANDBOX
> > +     default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
> > +                        ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
> >       default 0x400
> >       help
> >         Before relocation, memory is very limited on many platforms.
> Still,
>
>
> Tested-by: Pierre-Jean Texier <pjtexier@koncepto.io>
>
>
> Thanks
>
> Pierre-Jean
>
>
Joris OFFOUGA May 3, 2019, 5:28 p.m. UTC | #3 
Hi Fabio

Tested-by Joris Offouga <offougajoris@gmail.com >

BR

Joris

Le ven. 3 mai 2019 à 19:05, Fabio Estevam <festevam@gmail.com> a écrit :

> Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver") causes some i.MX boards that were converted
> to DM, such as warp7, to fail to boot.
>
> As explained by Lukas Auer:
>
> "With the patch, U-Boot probes the drivers for devices under simple-bus
> device tree nodes in the pre-relocation device model. The default value
> of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to
> do this, causing it to hang."
>
> Fix this problem by providing a convenient default value for
> CONFIG_SYS_MALLOC_F_LEN.
>
> Reported-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Suggested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Move the default setting to the main Kconfig and make it depend
> on i.MX
>
>  Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Kconfig b/Kconfig
> index 7a5491bd67..fd4ff42c17 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -138,6 +138,8 @@ config SYS_MALLOC_F_LEN
>         depends on SYS_MALLOC_F
>         default 0x1000 if AM33XX
>         default 0x2800 if SANDBOX
> +       default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
> +                          ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
>         default 0x400
>         help
>           Before relocation, memory is very limited on many platforms.
> Still,
> --
> 2.17.1
>
>
Bryan O'Donoghue May 3, 2019, 6:09 p.m. UTC | #4 
On 03/05/2019 18:05, Fabio Estevam wrote:
> Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver") causes some i.MX boards that were converted
> to DM, such as warp7, to fail to boot.
> 
> As explained by Lukas Auer:
> 
> "With the patch, U-Boot probes the drivers for devices under simple-bus
> device tree nodes in the pre-relocation device model. The default value
> of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to
> do this, causing it to hang."
> 
> Fix this problem by providing a convenient default value for
> CONFIG_SYS_MALLOC_F_LEN.
> 
> Reported-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Suggested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Good work.

Tested: warp7_bl33, warp7

Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Lukas Auer May 3, 2019, 9:52 p.m. UTC | #5 
On Fri, 2019-05-03 at 14:05 -0300, Fabio Estevam wrote:
> Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver") causes some i.MX boards that were converted
> to DM, such as warp7, to fail to boot.
> 
> As explained by Lukas Auer:
> 
> "With the patch, U-Boot probes the drivers for devices under simple-bus
> device tree nodes in the pre-relocation device model. The default value
> of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to
> do this, causing it to hang."
> 
> Fix this problem by providing a convenient default value for
> CONFIG_SYS_MALLOC_F_LEN.
> 
> Reported-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Suggested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Move the default setting to the main Kconfig and make it depend
> on i.MX
> 
>  Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 

Thank you for sending the patch!

Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
Peng Fan May 5, 2019, 4:12 a.m. UTC | #6 
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: 2019年5月4日 1:05
> To: sbabic@denx.de
> Cc: dl-uboot-imx <uboot-imx@nxp.com>; u-boot@lists.denx.de;
> pjtexier@koncepto.io; lukas.auer@aisec.fraunhofer.de;
> offougajoris@gmail.com; trini@konsulko.com; Fabio Estevam
> <festevam@gmail.com>
> Subject: [PATCH v2] imx: Use a convenient default value for
> SYS_MALLOC_F_LEN
> 
> Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver") causes some i.MX boards that were converted to DM, such
> as warp7, to fail to boot.
> 
> As explained by Lukas Auer:
> 
> "With the patch, U-Boot probes the drivers for devices under simple-bus
> device tree nodes in the pre-relocation device model. The default value of
> CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough
> memory to do this, causing it to hang."
> 
> Fix this problem by providing a convenient default value for
> CONFIG_SYS_MALLOC_F_LEN.
> 
> Reported-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Suggested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Move the default setting to the main Kconfig and make it depend on i.MX
> 
>  Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Kconfig b/Kconfig
> index 7a5491bd67..fd4ff42c17 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -138,6 +138,8 @@ config SYS_MALLOC_F_LEN
>  	depends on SYS_MALLOC_F
>  	default 0x1000 if AM33XX
>  	default 0x2800 if SANDBOX
> +	default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
> +			   ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
>  	default 0x400
>  	help
>  	  Before relocation, memory is very limited on many platforms. Still,

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> --
> 2.17.1
Heiko Schocher May 6, 2019, 12:55 p.m. UTC | #7 
Hello Fabio,

Am 03.05.2019 um 19:05 schrieb Fabio Estevam:
> Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver") causes some i.MX boards that were converted
> to DM, such as warp7, to fail to boot.
> 
> As explained by Lukas Auer:
> 
> "With the patch, U-Boot probes the drivers for devices under simple-bus
> device tree nodes in the pre-relocation device model. The default value
> of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to
> do this, causing it to hang."
> 
> Fix this problem by providing a convenient default value for
> CONFIG_SYS_MALLOC_F_LEN.
> 
> Reported-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Suggested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Move the default setting to the main Kconfig and make it depend
> on i.MX
> 
>   Kconfig | 2 ++
>   1 file changed, 2 insertions(+)

Thanks for this fix! This solves my issue with patch
[PATCH] simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver

on a not yet mainlined imx6ull based board.

Tested-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
Stefano Babic June 10, 2019, 9:49 a.m. UTC | #8 
> Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to
> simple-bus driver") causes some i.MX boards that were converted
> to DM, such as warp7, to fail to boot.
> As explained by Lukas Auer:
> "With the patch, U-Boot probes the drivers for devices under simple-bus
> device tree nodes in the pre-relocation device model. The default value
> of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to
> do this, causing it to hang."
> Fix this problem by providing a convenient default value for
> CONFIG_SYS_MALLOC_F_LEN.
> Reported-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Suggested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Tested-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Tested-by: Heiko Schocher <hs@denx.de>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/Kconfig b/Kconfig
index 7a5491bd67..fd4ff42c17 100644
--- a/Kconfig
+++ b/Kconfig
@@ -138,6 +138,8 @@  config SYS_MALLOC_F_LEN
 	depends on SYS_MALLOC_F
 	default 0x1000 if AM33XX
 	default 0x2800 if SANDBOX
+	default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
+			   ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5)
 	default 0x400
 	help
 	  Before relocation, memory is very limited on many platforms. Still,