| Message ID | 20190321105647.29488-1-i.maximets@samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ovs-vsctl: Add datapath_type column to show command. | expand |
On 21 Mar 2019, at 11:56, Ilya Maximets wrote: > Sometimes it's unclear which datapath type is in use by particular > bridge. For example, if all the interfaces supported by both system > and netdev datapaths it needs a DB query or log analysis to find out > which 'datapath_type' is in use. > Another case is that it's hard to figure out if patch ports are really > connected to each other. They are definitely not connected if datapath > types of their bridges differs. > > With this change non-default 'datapath_type's will be exposed to > 'ovs-vsctl show' command, so it'll be easier to spot misconfiguration. > > $ ovs-vsctl show > ... > Bridge "br0" > datapath_type: netdev > Port "br0" > Interface "br0" > type: internal > ... > > Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Acked-by: Eelco Chaudron <echaudro@redhat.com>
On Thu, Mar 21, 2019 at 01:56:47PM +0300, Ilya Maximets wrote: > Sometimes it's unclear which datapath type is in use by particular > bridge. For example, if all the interfaces supported by both system > and netdev datapaths it needs a DB query or log analysis to find out > which 'datapath_type' is in use. > Another case is that it's hard to figure out if patch ports are really > connected to each other. They are definitely not connected if datapath > types of their bridges differs. > > With this change non-default 'datapath_type's will be exposed to > 'ovs-vsctl show' command, so it'll be easier to spot misconfiguration. > > $ ovs-vsctl show > ... > Bridge "br0" > datapath_type: netdev > Port "br0" > Interface "br0" > type: internal > ... > > Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Thanks, applied to master.
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index a36905186..4948137ef 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -1001,6 +1001,7 @@ static struct cmd_show_table cmd_show_tables[] = { &ovsrec_bridge_col_name, {&ovsrec_bridge_col_controller, &ovsrec_bridge_col_fail_mode, + &ovsrec_bridge_col_datapath_type, &ovsrec_bridge_col_ports}, {NULL, NULL, NULL} },
Sometimes it's unclear which datapath type is in use by particular bridge. For example, if all the interfaces supported by both system and netdev datapaths it needs a DB query or log analysis to find out which 'datapath_type' is in use. Another case is that it's hard to figure out if patch ports are really connected to each other. They are definitely not connected if datapath types of their bridges differs. With this change non-default 'datapath_type's will be exposed to 'ovs-vsctl show' command, so it'll be easier to spot misconfiguration. $ ovs-vsctl show ... Bridge "br0" datapath_type: netdev Port "br0" Interface "br0" type: internal ... Signed-off-by: Ilya Maximets <i.maximets@samsung.com> --- utilities/ovs-vsctl.c | 1 + 1 file changed, 1 insertion(+)