From patchwork Thu Mar 21 10:56:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1059987 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="fcQGnF9N"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44Q3dX3GHBz9sR2 for ; Thu, 21 Mar 2019 21:57:02 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 032B826FD; Thu, 21 Mar 2019 10:56:58 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id AC8DB26E8 for ; Thu, 21 Mar 2019 10:56:56 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id F19A7D3 for ; Thu, 21 Mar 2019 10:56:55 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190321105653euoutp02a525c481ede91dabae428512b03f80f3~N9BQoodEt1330813308euoutp02f for ; Thu, 21 Mar 2019 10:56:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190321105653euoutp02a525c481ede91dabae428512b03f80f3~N9BQoodEt1330813308euoutp02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1553165813; bh=/7VkeYsHgPe4iLJoXLLC/LLErwzkbz5Gyglqnkxo/iQ=; h=From:To:Cc:Subject:Date:References:From; b=fcQGnF9NvKIXj/QBYHvkGhJ0ne64/Gbk0yu74rFLbGIYemjg2RTPEkjyHa7samEA6 7E900W9RvS0py4thyRcarUjksdgjTFL/lnUXvPGQe+y0OxGBFAKUj3ArNivFG75LVU LiJXjs985NJbJpGym42ZWLl8AxAmtJocuQUAK6Ik= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190321105653eucas1p1a7e33355b6cf494a9712b9bb122dcfd9~N9BQM2MFe2593825938eucas1p1F; Thu, 21 Mar 2019 10:56:53 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id A0.A6.04806.5FD639C5; Thu, 21 Mar 2019 10:56:53 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190321105652eucas1p29f43feb012d89cbd1283f551e3e4caba~N9BPfMcs40478104781eucas1p2y; Thu, 21 Mar 2019 10:56:52 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190321105652eusmtrp2f702766ee9e6f9f848d6e174a2a3c65f~N9BPUq62J1344813448eusmtrp2n; Thu, 21 Mar 2019 10:56:52 +0000 (GMT) X-AuditID: cbfec7f5-367ff700000012c6-60-5c936df5108a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 83.3C.04284.4FD639C5; Thu, 21 Mar 2019 10:56:52 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190321105652eusmtip15652890e2e8f854346a8c2e6e4c9150e~N9BO_hNoF2520925209eusmtip13; Thu, 21 Mar 2019 10:56:52 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org, Ben Pfaff Date: Thu, 21 Mar 2019 13:56:47 +0300 Message-Id: <20190321105647.29488-1-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsWy7djPc7pfcyfHGPRPYLd4NbmB0eLOlZ9s Flfaf7JbzP30nNGBxePZzf+MHs+v9bB4vN93lc2jb8sqxgCWKC6blNSczLLUIn27BK6Mrj+L GAvWcFVsWfWdrYHxF3sXIyeHhICJxOwXfUA2F4eQwApGiVV906GcL4wSxze1sEE4nxklXs7Y zgrT0rb7I1TVckaJH19nQjk/GCWWNrazgFSxCehInFp9hBHEFgHqWDb1GxuIzSwQJPFy5T+w 5cICrhKnVvYxgdgsAqoST27OBbN5BawlpjdOZ4bYJi+xesMBKHsHm8SXmTUQtovEwXVHoOLC Eq+Ob4F6SEbi/875TBB2vcT9lpeMIMdJCHQwSkw/9A8qYS+x5fU5oAYOoIM0Jdbv0gcxJQQc JdYfLYIw+SRuvBWEuJhPYtI2kGtAwrwSHW1CEDNUJH4fXA51gJTEzXefoQ7wkFjx+hrYbCGB WIkz3VkTGOVmIWxawMi4ilE8tbQ4Nz212DgvtVyvODG3uDQvXS85P3cTIzDCT/87/nUH474/ SYcYBTgYlXh4IxwmxQixJpYVV+YeYpTgYFYS4d0VPTlGiDclsbIqtSg/vqg0J7X4EKM0B4uS OG81w4NoIYH0xJLU7NTUgtQimCwTB6dUA2N28IeTEn2P2X9zzbtQaJXJN6tV+nWo7qysFZPf 2xyYaXp2fryQymejVOkPhVMu/Xln3m4uztPewpGzLIm/fPYLkYs2UbvLexwj36Q9Pi+Y1b16 zgz1Lf4dTRLmNmW/HHMkd2kzl0WWsFyustw165mQxstOrXInzVlHeo5qMt7dM/lEhNi6LiWW 4oxEQy3mouJEACT9vfzsAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrILMWRmVeSWpSXmKPExsVy+t/xu7pfcifHGKy6LmfxanIDo8WdKz/Z LK60/2S3mPvpOaMDi8ezm/8ZPZ5f62HxeL/vKptH35ZVjAEsUXo2RfmlJakKGfnFJbZK0YYW RnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2CXoZXX8WMRas4arYsuo7WwPjL/YuRk4O CQETibbdH4FsLg4hgaWMEm9W/2eGSEhJ/Ph1gRXCFpb4c62LDaLoG6PEtdkrwLrZBHQkTq0+ wtjFyMEhImAmseWfJUiYWSBIouHqRhYQW1jAVeLUyj4mEJtFQFXiyc25YDavgLXE9MbpULvk JVZvOMA8gZFnASPDKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMDg2nbs5+YdjJc2Bh9iFOBg VOLhXWAyKUaINbGsuDL3EKMEB7OSCO+u6MkxQrwpiZVVqUX58UWlOanFhxhNgZZPZJYSTc4H Bn5eSbyhqaG5haWhubG5sZmFkjjveYPKKCGB9MSS1OzU1ILUIpg+Jg5OqQbGmILMt9vqdr52 vCIp0l5yvdtOePqld9lqHwxje+av2pl5nW/xF07ehzzl767qdbffXViv1dK8lZFTYNZ5Tc7g NQs2eEje1/T5zRG89q/b/aQZVZs/VKRovxbL+XHf+uyWi8UCwemzi11b78x9cH9lM9tl978b ZySwd0wozuAsCevZ81/5+KwCJZbijERDLeai4kQAjKHt/kQCAAA= X-CMS-MailID: 20190321105652eucas1p29f43feb012d89cbd1283f551e3e4caba X-Msg-Generator: CA X-RootMTR: 20190321105652eucas1p29f43feb012d89cbd1283f551e3e4caba X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190321105652eucas1p29f43feb012d89cbd1283f551e3e4caba References: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets Subject: [ovs-dev] [PATCH] ovs-vsctl: Add datapath_type column to show command. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Sometimes it's unclear which datapath type is in use by particular bridge. For example, if all the interfaces supported by both system and netdev datapaths it needs a DB query or log analysis to find out which 'datapath_type' is in use. Another case is that it's hard to figure out if patch ports are really connected to each other. They are definitely not connected if datapath types of their bridges differs. With this change non-default 'datapath_type's will be exposed to 'ovs-vsctl show' command, so it'll be easier to spot misconfiguration. $ ovs-vsctl show ... Bridge "br0" datapath_type: netdev Port "br0" Interface "br0" type: internal ... Signed-off-by: Ilya Maximets Acked-by: Eelco Chaudron --- utilities/ovs-vsctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index a36905186..4948137ef 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -1001,6 +1001,7 @@ static struct cmd_show_table cmd_show_tables[] = { &ovsrec_bridge_col_name, {&ovsrec_bridge_col_controller, &ovsrec_bridge_col_fail_mode, + &ovsrec_bridge_col_datapath_type, &ovsrec_bridge_col_ports}, {NULL, NULL, NULL} },