| Message ID | 20190209121543.25946-3-jagan@amarulasolutions.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot,1/3] spi: Kconfig: Mark CONFIG_SPI as Legacy spi support | expand |
On 09/02/19 5:45 PM, Jagan Teki wrote: > DM_SPI_FLASH should require spi flash interface code for dm > version, so select SPI_FLASH core by default if any board > enabled DM_SPI_FLASH. > > This overcome the explicit enablement of CONFIG_SPI_FLASH on > respective boards when DM_SPI_FLASH being used. > > Cc: Vignesh R <vigneshr@ti.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/mtd/spi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig > index 605f60c713..43f597ec29 100644 > --- a/drivers/mtd/spi/Kconfig > +++ b/drivers/mtd/spi/Kconfig > @@ -3,6 +3,7 @@ menu "SPI Flash Support" > config DM_SPI_FLASH > bool "Enable Driver Model for SPI flash" > depends on DM && DM_SPI > + select SPI_FLASH How about imply instead of select since there is no compile time dependency? > help > Enable driver model for SPI flash. This SPI flash interface > (spi_flash_probe(), spi_flash_write(), etc.) is then >
On Tue, Feb 12, 2019 at 1:27 PM Vignesh R <vigneshr@ti.com> wrote: > > > > On 09/02/19 5:45 PM, Jagan Teki wrote: > > DM_SPI_FLASH should require spi flash interface code for dm > > version, so select SPI_FLASH core by default if any board > > enabled DM_SPI_FLASH. > > > > This overcome the explicit enablement of CONFIG_SPI_FLASH on > > respective boards when DM_SPI_FLASH being used. > > > Cc: Vignesh R <vigneshr@ti.com> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > drivers/mtd/spi/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig > > index 605f60c713..43f597ec29 100644 > > --- a/drivers/mtd/spi/Kconfig > > +++ b/drivers/mtd/spi/Kconfig > > @@ -3,6 +3,7 @@ menu "SPI Flash Support" > > config DM_SPI_FLASH > > bool "Enable Driver Model for SPI flash" > > depends on DM && DM_SPI > > + select SPI_FLASH > > How about imply instead of select since there is no compile time dependency? Yes we can, since DM_SPI_FLASH by default require SPI_FLASH I have used select.
diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig index 605f60c713..43f597ec29 100644 --- a/drivers/mtd/spi/Kconfig +++ b/drivers/mtd/spi/Kconfig @@ -3,6 +3,7 @@ menu "SPI Flash Support" config DM_SPI_FLASH bool "Enable Driver Model for SPI flash" depends on DM && DM_SPI + select SPI_FLASH help Enable driver model for SPI flash. This SPI flash interface (spi_flash_probe(), spi_flash_write(), etc.) is then
DM_SPI_FLASH should require spi flash interface code for dm version, so select SPI_FLASH core by default if any board enabled DM_SPI_FLASH. This overcome the explicit enablement of CONFIG_SPI_FLASH on respective boards when DM_SPI_FLASH being used. Cc: Vignesh R <vigneshr@ti.com> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- drivers/mtd/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)