mbox series

[U-Boot] Please pull u-boot-dm

Message ID CAPnjgZ20BMJE4dJODqaNg7937C7w8U_qMueEZt4z-QSLbVkSeg@mail.gmail.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series [U-Boot] Please pull u-boot-dm | expand

Pull-request

git://git.denx.de/u-boot-dm.git tags/pull-29nov18

Message

Simon Glass Nov. 29, 2018, 8:55 p.m. UTC 
Hi Tom,

The following changes since commit e16c888fab5014b022d5781dc534f204460a073b:

  Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500)

are available in the Git repository at:

  git://git.denx.de/u-boot-dm.git tags/pull-29nov18

for you to fetch changes up to 5ca3927deff30458f5d5b384f6699f70b9509315:

  core: ofnode: Add ofnode_get_addr_size_index (2018-11-29 09:30:06 -0700)

Results here:

https://travis-ci.org/sglass68/u-boot/builds/461363284

----------------------------------------------------------------
Fix sound on sandbox
Convert TPM fully to DM
Tidy up sandbox I2C emulation
Add a 'make qcheck' target for faster testing
A few other misc things

----------------------------------------------------------------
Baruch Siach (1):
      ofnode: fix comment typo

Heiko Schocher (1):
      cmd, fdt: add subcommand "get" to fdt header

Keerthy (2):
      core: ofnode: Fix ofnode_get_addr_index function
      core: ofnode: Add ofnode_get_addr_size_index

Simon Glass (17):
      malloc_simple: Add logging of allocations
      power: pmic: Correct debug/error output
      test: Add a 'make qcheck' target for quicker testing
      dm: core: Export uclass_find_device_by_phandle()
      dm: core: Add a few more specific child-finding functions
      dm: core: Put UCLASS_SIMPLE_BUS in order
      dm: sandbox: i2c: Add a new 'emulation parent' uclass
      dm: sandbox: i2c: Use new emulator parent uclass
      rtc: Allow child drivers
      sound: Correct data output in sound_create_square_wave()
      sound: Add sample rate as a parameter for square wave
      sound: sandbox: Use the correct frequency
      sandbox: Enable sound
      sandbox: Use memmove() to move overlapping regions
      tpm: Add a constant for the minimum supported digest size
      tpm: Export the open/close functions
      tpm: Convert to use a device parameter

 Makefile                              |   6 +-
 arch/sandbox/cpu/os.c                 |   5 +-
 arch/sandbox/cpu/sdl.c                |  30 ++----
 arch/sandbox/dts/sandbox.dts          |  25 +++--
 arch/sandbox/dts/sandbox64.dts        |  21 ++--
 arch/sandbox/dts/sandbox_pmic.dtsi    |  71 +++++++------
 arch/sandbox/dts/test.dts             |  28 +++--
 board/gdsys/a38x/controlcenterdc.c    |  25 ++++-
 board/gdsys/a38x/hre.c                |  66 +++++++-----
 board/gdsys/a38x/hre.h                |   2 +-
 board/gdsys/a38x/keyprogram.c         |  12 ++-
 board/gdsys/a38x/keyprogram.h         |   4 +-
 board/gdsys/p1022/controlcenterd-id.c | 117 +++++++++++++--------
 cmd/fdt.c                             |  40 ++++++-
 cmd/tpm-common.c                      |   8 +-
 cmd/tpm-v1.c                          | 140 ++++++++++++++++++++----
 cmd/tpm-v2.c                          |  78 +++++++++++---
 cmd/tpm_test.c                        | 327
++++++++++++++++++++++++++++++---------------------------
 common/malloc_simple.c                |  58 ++++++----
 drivers/core/device.c                 |  34 ++++++
 drivers/core/ofnode.c                 |  25 +++--
 drivers/core/uclass.c                 |   6 +-
 drivers/i2c/i2c-emul-uclass.c         |  77 ++++++++++++++
 drivers/i2c/sandbox_i2c.c             |  20 +---
 drivers/power/pmic/act8846.c          |   2 +-
 drivers/power/pmic/as3722.c           |  14 +--
 drivers/power/pmic/as3722_gpio.c      |  11 +-
 drivers/power/pmic/i2c_pmic_emul.c    |   2 +-
 drivers/power/pmic/lp873x.c           |   6 +-
 drivers/power/pmic/lp87565.c          |   6 +-
 drivers/power/pmic/max77686.c         |   8 +-
 drivers/power/pmic/max8997.c          |   4 +-
 drivers/power/pmic/max8998.c          |   4 +-
 drivers/power/pmic/mc34708.c          |   4 +-
 drivers/power/pmic/palmas.c           |   8 +-
 drivers/power/pmic/pfuze100.c         |   6 +-
 drivers/power/pmic/rk8xx.c            |   6 +-
 drivers/power/pmic/rn5t567.c          |   4 +-
 drivers/power/pmic/s2mps11.c          |   8 +-
 drivers/power/pmic/s5m8767.c          |   6 +-
 drivers/power/pmic/sandbox.c          |   4 +-
 drivers/power/pmic/stpmu1.c           |   2 +-
 drivers/power/pmic/tps65090.c         |   8 +-
 drivers/rtc/rtc-uclass.c              |   1 +
 drivers/sound/sound-i2s.c             |   3 +-
 drivers/sound/sound.c                 |   8 +-
 drivers/tpm/tpm_tis_lpc.c             |  47 +++++----
 include/dm/device.h                   |  25 +++++
 include/dm/ofnode.h                   |  16 ++-
 include/dm/uclass-id.h                |   3 +-
 include/dm/uclass-internal.h          |  17 +++
 include/i2c.h                         |  21 ++++
 include/log.h                         |   2 +-
 include/malloc.h                      |   1 +
 include/sound.h                       |   4 +-
 include/tpm-common.h                  |  36 ++++++-
 include/tpm-v1.h                      |  97 +++++++++++------
 include/tpm-v2.h                      |  49 ++++++---
 lib/tpm-common.c                      |  16 +--
 lib/tpm-utils.h                       |  21 +---
 lib/tpm-v1.c                          | 142 +++++++++++++------------
 lib/tpm-v2.c                          |  60 ++++++-----
 test/README                           |   6 +-
 test/dm/i2c.c                         |   2 +-
 test/dm/rtc.c                         |   9 +-
 test/dm/test-fdt.c                    |  47 +++++++++
 test/py/tests/test_fs/test_basic.py   |   1 +
 test/py/tests/test_fs/test_ext.py     |   1 +
 test/py/tests/test_fs/test_mkdir.py   |   1 +
 test/py/tests/test_fs/test_unlink.py  |   1 +
 test/run                              |  10 +-
 71 files changed, 1305 insertions(+), 680 deletions(-)

Regards,
Simon

Comments

Tom Rini Nov. 30, 2018, 2:55 p.m. UTC | #1 
On Thu, Nov 29, 2018 at 01:55:14PM -0700, Simon Glass wrote:

> Hi Tom,
> 
> The following changes since commit e16c888fab5014b022d5781dc534f204460a073b:
> 
>   Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-dm.git tags/pull-29nov18
> 
> for you to fetch changes up to 5ca3927deff30458f5d5b384f6699f70b9509315:
> 
>   core: ofnode: Add ofnode_get_addr_size_index (2018-11-29 09:30:06 -0700)
> 
> Results here:
> 
> https://travis-ci.org/sglass68/u-boot/builds/461363284

NAK.  I don't know _why_ but I can confirm that both within travis:
https://travis-ci.org/trini/u-boot/jobs/461494951
and then locally when I installed clang-7.0 from https://apt.llvm.org/ I
see that:
5ca3927deff30458f5d5b384f6699f70b9509315 is the first bad commit
commit 5ca3927deff30458f5d5b384f6699f70b9509315
Author: Keerthy <j-keerthy@ti.com>
Date:   Mon Nov 19 11:44:48 2018 +0530

    core: ofnode: Add ofnode_get_addr_size_index

is totally breaking test.py on sandbox.  It still starts and I don't see
the obvious whats wrong, but I've bisected twice to this same commit.
J, KEERTHY Dec. 5, 2018, 4:10 a.m. UTC | #2 
On Friday 30 November 2018 08:25 PM, Tom Rini wrote:
> On Thu, Nov 29, 2018 at 01:55:14PM -0700, Simon Glass wrote:
> 
>> Hi Tom,
>>
>> The following changes since commit e16c888fab5014b022d5781dc534f204460a073b:
>>
>>   Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500)
>>
>> are available in the Git repository at:
>>
>>   git://git.denx.de/u-boot-dm.git tags/pull-29nov18
>>
>> for you to fetch changes up to 5ca3927deff30458f5d5b384f6699f70b9509315:
>>
>>   core: ofnode: Add ofnode_get_addr_size_index (2018-11-29 09:30:06 -0700)
>>
>> Results here:
>>
>> https://travis-ci.org/sglass68/u-boot/builds/461363284
> 
> NAK.  I don't know _why_ but I can confirm that both within travis:
> https://travis-ci.org/trini/u-boot/jobs/461494951
> and then locally when I installed clang-7.0 from https://apt.llvm.org/ I
> see that:
> 5ca3927deff30458f5d5b384f6699f70b9509315 is the first bad commit
> commit 5ca3927deff30458f5d5b384f6699f70b9509315
> Author: Keerthy <j-keerthy@ti.com>
> Date:   Mon Nov 19 11:44:48 2018 +0530
> 
>     core: ofnode: Add ofnode_get_addr_size_index
> 
> is totally breaking test.py on sandbox.  It still starts and I don't see
> the obvious whats wrong, but I've bisected twice to this same commit.
> 

Okay i am not sure either what is going wrong there. I will take a look at this.

Thanks,
Keerthy
Simon Glass Dec. 11, 2018, 1:04 a.m. UTC | #3 
Hi,

On Tue, 4 Dec 2018 at 21:10, Keerthy <j-keerthy@ti.com> wrote:
>
>
>
> On Friday 30 November 2018 08:25 PM, Tom Rini wrote:
> > On Thu, Nov 29, 2018 at 01:55:14PM -0700, Simon Glass wrote:
> >
> >> Hi Tom,
> >>
> >> The following changes since commit e16c888fab5014b022d5781dc534f204460a073b:
> >>
> >>   Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500)
> >>
> >> are available in the Git repository at:
> >>
> >>   git://git.denx.de/u-boot-dm.git tags/pull-29nov18
> >>
> >> for you to fetch changes up to 5ca3927deff30458f5d5b384f6699f70b9509315:
> >>
> >>   core: ofnode: Add ofnode_get_addr_size_index (2018-11-29 09:30:06 -0700)
> >>
> >> Results here:
> >>
> >> https://travis-ci.org/sglass68/u-boot/builds/461363284
> >
> > NAK.  I don't know _why_ but I can confirm that both within travis:
> > https://travis-ci.org/trini/u-boot/jobs/461494951
> > and then locally when I installed clang-7.0 from https://apt.llvm.org/ I
> > see that:
> > 5ca3927deff30458f5d5b384f6699f70b9509315 is the first bad commit
> > commit 5ca3927deff30458f5d5b384f6699f70b9509315
> > Author: Keerthy <j-keerthy@ti.com>
> > Date:   Mon Nov 19 11:44:48 2018 +0530
> >
> >     core: ofnode: Add ofnode_get_addr_size_index
> >
> > is totally breaking test.py on sandbox.  It still starts and I don't see
> > the obvious whats wrong, but I've bisected twice to this same commit.
> >
>
> Okay i am not sure either what is going wrong there. I will take a look at this.

I am worried that this might be a unicode problem.

- build outputs error messages with backquotes, UTF-8, etc.
- pipe from builder thread to buildman breaks things into 4KB chunks
- sometimes a UTF-8 char break across a 4KB boundary
- I/O error results

I suspect this because buildman's unicode handling is actually a bit
broken - see how quotes come through in messages on some machines.

But it might be something else entirely.

Regards,
Simon
J, KEERTHY Dec. 11, 2018, 4:01 a.m. UTC | #4 
On Tuesday 11 December 2018 06:34 AM, Simon Glass wrote:
> Hi,
> 
> On Tue, 4 Dec 2018 at 21:10, Keerthy <j-keerthy@ti.com> wrote:
>>
>>
>>
>> On Friday 30 November 2018 08:25 PM, Tom Rini wrote:
>>> On Thu, Nov 29, 2018 at 01:55:14PM -0700, Simon Glass wrote:
>>>
>>>> Hi Tom,
>>>>
>>>> The following changes since commit e16c888fab5014b022d5781dc534f204460a073b:
>>>>
>>>>   Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>   git://git.denx.de/u-boot-dm.git tags/pull-29nov18
>>>>
>>>> for you to fetch changes up to 5ca3927deff30458f5d5b384f6699f70b9509315:
>>>>
>>>>   core: ofnode: Add ofnode_get_addr_size_index (2018-11-29 09:30:06 -0700)
>>>>
>>>> Results here:
>>>>
>>>> https://travis-ci.org/sglass68/u-boot/builds/461363284
>>>
>>> NAK.  I don't know _why_ but I can confirm that both within travis:
>>> https://travis-ci.org/trini/u-boot/jobs/461494951
>>> and then locally when I installed clang-7.0 from https://apt.llvm.org/ I
>>> see that:
>>> 5ca3927deff30458f5d5b384f6699f70b9509315 is the first bad commit
>>> commit 5ca3927deff30458f5d5b384f6699f70b9509315
>>> Author: Keerthy <j-keerthy@ti.com>
>>> Date:   Mon Nov 19 11:44:48 2018 +0530
>>>
>>>     core: ofnode: Add ofnode_get_addr_size_index
>>>
>>> is totally breaking test.py on sandbox.  It still starts and I don't see
>>> the obvious whats wrong, but I've bisected twice to this same commit.
>>>
>>
>> Okay i am not sure either what is going wrong there. I will take a look at this.
> 
> I am worried that this might be a unicode problem.
> 
> - build outputs error messages with backquotes, UTF-8, etc.
> - pipe from builder thread to buildman breaks things into 4KB chunks
> - sometimes a UTF-8 char break across a 4KB boundary
> - I/O error results
> 
> I suspect this because buildman's unicode handling is actually a bit
> broken - see how quotes come through in messages on some machines.
> 
> But it might be something else entirely.

Adding Lokesh

Hey Lokesh,

I am yet to dig into this. Seems my patch is breaking test.py on sandbox and
hence it was not pulled.

Regards,
Keerthy
> 
> Regards,
> Simon
>