| Message ID | 20190523153223.18185-1-erosca@de.adit-jv.com |
|---|---|
| Headers | show |
| Series | Add 'bcb' command to read/modify/write Android BCB | expand |
For the whole series: Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> Thank you for handling this, Eugeniu! On Thu, May 23, 2019 at 6:33 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote: > > The motivation behind the 'bcb' command is explained in the > second ("cmd: Add 'bcb' command *") patch. > > The first patch does the necessary fixing and polishing of > include/android_bootloader_message.h and is a hard prerequisite > for this series. > > The third patch relocates the Android README to doc/android and creates > a brand new doc/android/bcb.txt covering the purpose/usage of 'bcb'. > > v3: > - [Simon Glass] Lots of review comments handled in cmd/bcb.c. > - [Simon Glass, Sam Protsenko] Renamed and enriched android docs. > - Placed detailed stats in each patch. > > v2: > - [Heinrich Schuchardt] Implement sub-commands via U_BOOT_CMD_MKENT. > - Polished the code. Ensured no warnings returned by sparse, smatch, > `cppcheck --force --enable=all --inconclusive`, make W=1. > - Tested on R-Car-H3-ES20 ULCB-KF. > > v1: > - https://patchwork.ozlabs.org/cover/1080393/ > > Eugeniu Rosca (3): > include: android_bootloader_message.h: Minimize the diff to AOSP > cmd: Add 'bcb' command to read/modify/write BCB fields > doc: relocate/rename Android README and add BCB overview > > cmd/Kconfig | 17 + > cmd/Makefile | 1 + > cmd/bcb.c | 340 ++++++++++++++++++ > doc/{README.avb2 => android/avb2.txt} | 0 > doc/android/bcb.txt | 89 +++++ > .../fastboot.txt} | 0 > include/android_bootloader_message.h | 126 ++++--- > 7 files changed, 515 insertions(+), 58 deletions(-) > create mode 100644 cmd/bcb.c > rename doc/{README.avb2 => android/avb2.txt} (100%) > create mode 100644 doc/android/bcb.txt > rename doc/{README.android-fastboot => android/fastboot.txt} (100%) > > -- > 2.21.0 >
Hi Sam, On Fri, May 24, 2019 at 01:58:18AM +0300, Sam Protsenko wrote: > For the whole series: > > Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > > Thank you for handling this, Eugeniu! Thanks for your support. Assuming there will be little to no changes in the 'bcb' command (which still awaits Simon's Ack), I think you are unblocked with the A/B patches. Looking forward to seeing them.
Hi Tom, Simon, This one has been hanging here for a while. If there is no concerns, can we please merge it? It's really wanted feature for Android boot... Thanks! On Mon, May 27, 2019 at 6:26 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote: > > Hi Sam, > > On Fri, May 24, 2019 at 01:58:18AM +0300, Sam Protsenko wrote: > > For the whole series: > > > > Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > > > > Thank you for handling this, Eugeniu! > > Thanks for your support. Assuming there will be little to no changes in > the 'bcb' command (which still awaits Simon's Ack), I think you are > unblocked with the A/B patches. Looking forward to seeing them. > > -- > Best Regards, > Eugeniu.
On Tue, Jun 04, 2019 at 03:36:21PM +0300, Sam Protsenko wrote: > Hi Tom, Simon, > > This one has been hanging here for a while. If there is no concerns, > can we please merge it? It's really wanted feature for Android boot... I'd appreciate it if you can confirm the patchwork state of the various Android-related patches. At this point in the schedule, I'm inclined to grab everything else for post-v2019.07, thanks! > > Thanks! > > On Mon, May 27, 2019 at 6:26 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote: > > > > Hi Sam, > > > > On Fri, May 24, 2019 at 01:58:18AM +0300, Sam Protsenko wrote: > > > For the whole series: > > > > > > Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > > > > > > Thank you for handling this, Eugeniu! > > > > Thanks for your support. Assuming there will be little to no changes in > > the 'bcb' command (which still awaits Simon's Ack), I think you are > > unblocked with the A/B patches. Looking forward to seeing them. > > > > -- > > Best Regards, > > Eugeniu.
The motivation behind the 'bcb' command is explained in the second ("cmd: Add 'bcb' command *") patch. The first patch does the necessary fixing and polishing of include/android_bootloader_message.h and is a hard prerequisite for this series. The third patch relocates the Android README to doc/android and creates a brand new doc/android/bcb.txt covering the purpose/usage of 'bcb'. v3: - [Simon Glass] Lots of review comments handled in cmd/bcb.c. - [Simon Glass, Sam Protsenko] Renamed and enriched android docs. - Placed detailed stats in each patch. v2: - [Heinrich Schuchardt] Implement sub-commands via U_BOOT_CMD_MKENT. - Polished the code. Ensured no warnings returned by sparse, smatch, `cppcheck --force --enable=all --inconclusive`, make W=1. - Tested on R-Car-H3-ES20 ULCB-KF. v1: - https://patchwork.ozlabs.org/cover/1080393/ Eugeniu Rosca (3): include: android_bootloader_message.h: Minimize the diff to AOSP cmd: Add 'bcb' command to read/modify/write BCB fields doc: relocate/rename Android README and add BCB overview cmd/Kconfig | 17 + cmd/Makefile | 1 + cmd/bcb.c | 340 ++++++++++++++++++ doc/{README.avb2 => android/avb2.txt} | 0 doc/android/bcb.txt | 89 +++++ .../fastboot.txt} | 0 include/android_bootloader_message.h | 126 ++++--- 7 files changed, 515 insertions(+), 58 deletions(-) create mode 100644 cmd/bcb.c rename doc/{README.avb2 => android/avb2.txt} (100%) create mode 100644 doc/android/bcb.txt rename doc/{README.android-fastboot => android/fastboot.txt} (100%)