| Message ID | CAEG7qUzedb8HsZmiS=280yGq-_XOL1RzTLu-_R8LVDXEGiy0EA@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Nov 24, 2014 at 1:36 PM, Sterling Augustine <saugustine@google.com> wrote: > On Mon, Nov 24, 2014 at 10:50 AM, H.J. Lu <hjl.tools@gmail.com> wrote: >> Plain ENTRY is preferred if it works. > > I see no regressions on a "make check" using ENTRY and END. Assuming > that is adequate testing, OK for trunk? > > 2014-11-24 Sterling Augustine <saugustine@google.com> > > * sysdeps/x86_64/start.S (_start): Use ENTRY and END macros. > > > > diff --git a/sysdeps/x86_64/start.S b/sysdeps/x86_64/start.S > index e3d4ff8..97e972e 100644 > --- a/sysdeps/x86_64/start.S > +++ b/sysdeps/x86_64/start.S > @@ -55,11 +55,7 @@ > > #include <sysdep.h> > > - .text > - .globl _start > - .type _start,@function > -_start: > - cfi_startproc > +ENTRY (_start) > /* Clearing frame pointer is insufficient, use CFI. */ > cfi_undefined (rip) > /* Clear the frame pointer. The ABI suggests this be done, to mark > @@ -123,7 +119,7 @@ _start: > #endif > > hlt /* Crash if somehow `exit' does return. */ > - cfi_endproc > +END (_start) > > /* Define a symbol for the first piece of initialized data. */ > .data Looks good to me. Thanks.
diff --git a/sysdeps/x86_64/start.S b/sysdeps/x86_64/start.S index e3d4ff8..97e972e 100644 --- a/sysdeps/x86_64/start.S +++ b/sysdeps/x86_64/start.S @@ -55,11 +55,7 @@ #include <sysdep.h> - .text - .globl _start - .type _start,@function -_start: - cfi_startproc +ENTRY (_start) /* Clearing frame pointer is insufficient, use CFI. */ cfi_undefined (rip) /* Clear the frame pointer. The ABI suggests this be done, to mark @@ -123,7 +119,7 @@ _start: #endif hlt /* Crash if somehow `exit' does return. */ - cfi_endproc +END (_start) /* Define a symbol for the first piece of initialized data. */ .data
On Mon, Nov 24, 2014 at 10:50 AM, H.J. Lu <hjl.tools@gmail.com> wrote: > Plain ENTRY is preferred if it works. I see no regressions on a "make check" using ENTRY and END. Assuming that is adequate testing, OK for trunk? 2014-11-24 Sterling Augustine <saugustine@google.com> * sysdeps/x86_64/start.S (_start): Use ENTRY and END macros.