diff mbox

[for-2.2,1/2] QMP/input-send-event: update document of union InputEvent

Message ID 1415335285-1579-1-git-send-email-akong@redhat.com
State New
Headers show

Commit Message

Amos Kong Nov. 7, 2014, 4:41 a.m. UTC
Signed-off-by: Amos Kong <akong@redhat.com>
---
 qapi-schema.json | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Eric Blake Nov. 7, 2014, 8:49 a.m. UTC | #1
On 11/07/2014 05:41 AM, Amos Kong wrote:
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
>  qapi-schema.json | 5 +++++
>  1 file changed, 5 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 24379ab..a1573d8 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3231,6 +3231,11 @@
>  #
>  # Input event union.
>  #
> +# @key: Input event of Keyboard
> +# @btn: Input event of pointer bottons
> +# @rel: Input event of relative pointer motion
> +# @abs: Input event of absolute pointer motion
> +#
>  # Since: 2.0
>  ##
>  { 'union' : 'InputEvent',
>
Eric Blake Nov. 7, 2014, 8:50 a.m. UTC | #2
On 11/07/2014 09:49 AM, Eric Blake wrote:
> On 11/07/2014 05:41 AM, Amos Kong wrote:
>> Signed-off-by: Amos Kong <akong@redhat.com>
>> ---
>>  qapi-schema.json | 5 +++++
>>  1 file changed, 5 insertions(+)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Shoot - I hit "send" too soon.

> 
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 24379ab..a1573d8 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -3231,6 +3231,11 @@
>>  #
>>  # Input event union.
>>  #
>> +# @key: Input event of Keyboard
>> +# @btn: Input event of pointer bottons

s/bottons/buttons/ before my R-b applies (maintainer could opt to do
this without needing a v2)

>> +# @rel: Input event of relative pointer motion
>> +# @abs: Input event of absolute pointer motion
>> +#
>>  # Since: 2.0
>>  ##
>>  { 'union' : 'InputEvent',
>>
>
Gerd Hoffmann Nov. 13, 2014, 10:27 a.m. UTC | #3
> >> +# @btn: Input event of pointer bottons
> 
> s/bottons/buttons/ before my R-b applies (maintainer could opt to do
> this without needing a v2)

Fixed up, queued, pull req sent.

thanks,
  Gerd
diff mbox

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index 24379ab..a1573d8 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3231,6 +3231,11 @@ 
 #
 # Input event union.
 #
+# @key: Input event of Keyboard
+# @btn: Input event of pointer bottons
+# @rel: Input event of relative pointer motion
+# @abs: Input event of absolute pointer motion
+#
 # Since: 2.0
 ##
 { 'union' : 'InputEvent',