diff mbox

[2/2] tegra: Enable pre-console putc() for Tegra boards

Message ID 1331261577-21099-2-git-send-email-sjg@chromium.org
State Not Applicable, archived
Headers show

Commit Message

Simon Glass March 9, 2012, 2:52 a.m. UTC
This is used to display panic messages before the console is active.


Signed-off-by: Simon Glass <sjg@chromium.org>
---
 include/configs/tegra2-common.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

Comments

Olof Johansson March 9, 2012, 8:48 a.m. UTC | #1
Hi,

On Thu, Mar 8, 2012 at 6:52 PM, Simon Glass <sjg@chromium.org> wrote:
> This is used to display panic messages before the console is active.
>
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Please don't send u-boot patches to linux-tegra.


Thanks,

-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren March 9, 2012, 4:57 p.m. UTC | #2
On 03/08/2012 07:52 PM, Simon Glass wrote:
> This is used to display panic messages before the console is active.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

I applied both these patches on top of u-boot-tegra/master, built for
Ventana, and loaded/ran u-boot.bin, and don't see any useful serial
output; there's a bit of periodic binary spew. u-boot-dtb.bin works as
expected.

So, these patches don't appear to solve the problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Glass March 9, 2012, 6:24 p.m. UTC | #3
Hi Stephen,

On Fri, Mar 9, 2012 at 8:57 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 03/08/2012 07:52 PM, Simon Glass wrote:
>> This is used to display panic messages before the console is active.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>
> I applied both these patches on top of u-boot-tegra/master, built for
> Ventana, and loaded/ran u-boot.bin, and don't see any useful serial
> output; there's a bit of periodic binary spew. u-boot-dtb.bin works as
> expected.

I don't have a ventana but I think Seaboard is equivalent. I will test
on that and figure out what piece is missing.

>
> So, these patches don't appear to solve the problem.

They do in our tree, but I will take a look.

Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/configs/tegra2-common.h b/include/configs/tegra2-common.h
index e6f385f..6ced617 100644
--- a/include/configs/tegra2-common.h
+++ b/include/configs/tegra2-common.h
@@ -68,11 +68,18 @@ 
  */
 #define V_NS16550_CLK			216000000	/* 216MHz (pllp_out0) */
 
+/* Default serial clock and multiplier */
+#define CONFIG_DEFAULT_NS16550_CLK	V_NS16550_CLK
+#define CONFIG_DEFAULT_NS16550_MULT	16
+
 #define CONFIG_SYS_NS16550
 #define CONFIG_SYS_NS16550_SERIAL
 #define CONFIG_SYS_NS16550_REG_SIZE	(-4)
 #define CONFIG_SYS_NS16550_CLK		V_NS16550_CLK
 
+/* We use this for a warning message when no device tree is present */
+#define CONFIG_PRE_CONSOLE_PUTC
+
 /*
  * select serial console configuration
  */