diff mbox series

[V2,05/10] include: Create err.h header file

Message ID 20220315124914.51569-6-clombard@linux.vnet.ibm.com
State Superseded
Headers show
Series Import external libraries for MCTP/PLDM protocols | expand

Commit Message

Christophe Lombard March 15, 2022, 12:49 p.m. UTC
This file is used by the external library: libmctp.

Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
---
 libc/include/err.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 libc/include/err.h

Comments

Frederic Barrat March 31, 2023, 1:22 p.m. UTC | #1
On 15/03/2022 13:49, Christophe Lombard wrote:
> This file is used by the external library: libmctp.
> 
> Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
> ---
>   libc/include/err.h | 16 ++++++++++++++++


So that file is empty and remains empty once all the PLDM series are 
applied. It's only included once, from libmctp/astlpc.c. Couldn't we 
just remove the inclusion there? Or better: remove it from that file in 
the upstream libmctp? A quick check indicates it might be doable.

   Fred


>   1 file changed, 16 insertions(+)
>   create mode 100644 libc/include/err.h
> 
> diff --git a/libc/include/err.h b/libc/include/err.h
> new file mode 100644
> index 00000000..c923dc09
> --- /dev/null
> +++ b/libc/include/err.h
> @@ -0,0 +1,16 @@
> +/******************************************************************************
> + * Copyright (c) 2022 IBM Corporation
> + * All rights reserved.
> + * This program and the accompanying materials
> + * are made available under the terms of the BSD License
> + * which accompanies this distribution, and is available at
> + * http://www.opensource.org/licenses/bsd-license.php
> + *
> + * Contributors:
> + *     IBM Corporation - initial implementation
> + *****************************************************************************/
> +
> +#ifndef _ERR_H
> +#define _ERR_H
> +
> +#endif
diff mbox series

Patch

diff --git a/libc/include/err.h b/libc/include/err.h
new file mode 100644
index 00000000..c923dc09
--- /dev/null
+++ b/libc/include/err.h
@@ -0,0 +1,16 @@ 
+/******************************************************************************
+ * Copyright (c) 2022 IBM Corporation
+ * All rights reserved.
+ * This program and the accompanying materials
+ * are made available under the terms of the BSD License
+ * which accompanies this distribution, and is available at
+ * http://www.opensource.org/licenses/bsd-license.php
+ *
+ * Contributors:
+ *     IBM Corporation - initial implementation
+ *****************************************************************************/
+
+#ifndef _ERR_H
+#define _ERR_H
+
+#endif