| Message ID | 20230320125202.1721775-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [v2] soc: fsl: qe: remove unused qe_ic_from_irq function | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
Le 20/03/2023 à 13:52, Tom Rix a écrit : > clang with W=1 reports > drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function > 'qe_ic_from_irq' [-Werror,-Wunused-function] > static inline struct qe_ic *qe_ic_from_irq(unsigned int virq) > ^ > The use of this function was removed with > commit d7c2878cfcfa ("soc: fsl: qe: remove unused qe_ic_set_* functions") > > This function is not used, so remove it. > > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > v2: Add to commit log when the use was removed. > > --- > drivers/soc/fsl/qe/qe_ic.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c > index bbae3d39c7be..c0b4f865fba9 100644 > --- a/drivers/soc/fsl/qe/qe_ic.c > +++ b/drivers/soc/fsl/qe/qe_ic.c > @@ -232,11 +232,6 @@ static inline void qe_ic_write(__be32 __iomem *base, unsigned int reg, > iowrite32be(value, base + (reg >> 2)); > } > > -static inline struct qe_ic *qe_ic_from_irq(unsigned int virq) > -{ > - return irq_get_chip_data(virq); > -} > - > static inline struct qe_ic *qe_ic_from_irq_data(struct irq_data *d) > { > return irq_data_get_irq_chip_data(d);
diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c index bbae3d39c7be..c0b4f865fba9 100644 --- a/drivers/soc/fsl/qe/qe_ic.c +++ b/drivers/soc/fsl/qe/qe_ic.c @@ -232,11 +232,6 @@ static inline void qe_ic_write(__be32 __iomem *base, unsigned int reg, iowrite32be(value, base + (reg >> 2)); } -static inline struct qe_ic *qe_ic_from_irq(unsigned int virq) -{ - return irq_get_chip_data(virq); -} - static inline struct qe_ic *qe_ic_from_irq_data(struct irq_data *d) { return irq_data_get_irq_chip_data(d);
clang with W=1 reports drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function 'qe_ic_from_irq' [-Werror,-Wunused-function] static inline struct qe_ic *qe_ic_from_irq(unsigned int virq) ^ The use of this function was removed with commit d7c2878cfcfa ("soc: fsl: qe: remove unused qe_ic_set_* functions") This function is not used, so remove it. Signed-off-by: Tom Rix <trix@redhat.com> --- v2: Add to commit log when the use was removed. --- drivers/soc/fsl/qe/qe_ic.c | 5 ----- 1 file changed, 5 deletions(-)