| Message ID | 20230203140501.67659-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [ovs-dev,v1,1/3] string_helpers: Move string_is_valid() to the header | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/intel-ovs-compilation | fail | test: fail |
On Fri, Feb 03, 2023 at 04:04:59PM +0200, Andy Shevchenko wrote: > Move string_is_valid() to the header for wider use. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> For networking patches, the target tree, in this case net-next, should appear in the patch subject: [PATCH v1 net-next 1/3] string_helpers: Move string_is_valid() That notwithstanding, Reviewed-by: Simon Horman <simon.horman@corigine.com>
diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h index 88fb8e1d0421..01c9a432865a 100644 --- a/include/linux/string_helpers.h +++ b/include/linux/string_helpers.h @@ -12,6 +12,11 @@ struct device; struct file; struct task_struct; +static inline bool string_is_valid(const char *s, int len) +{ + return memchr(s, '\0', len) ? true : false; +} + /* Descriptions of the types of units to * print in */ enum string_size_units { diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index dfea27a906f2..75186cd551a0 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -39,6 +39,7 @@ #include "node.h" #include "net.h" #include <net/genetlink.h> +#include <linux/string_helpers.h> #include <linux/tipc_config.h> /* The legacy API had an artificial message length limit called @@ -173,11 +174,6 @@ static struct sk_buff *tipc_get_err_tlv(char *str) return buf; } -static inline bool string_is_valid(char *s, int len) -{ - return memchr(s, '\0', len) ? true : false; -} - static int __tipc_nl_compat_dumpit(struct tipc_nl_compat_cmd_dump *cmd, struct tipc_nl_compat_msg *msg, struct sk_buff *arg)
Move string_is_valid() to the header for wider use. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/string_helpers.h | 5 +++++ net/tipc/netlink_compat.c | 6 +----- 2 files changed, 6 insertions(+), 5 deletions(-)