| Message ID | 20221229012445.16169-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: nomadik: fix build when DEBUG_FS is not set | expand |
On Wed, Dec 28, 2022 at 05:24:45PM -0800, Randy Dunlap wrote: > Fix build when DEBUG_FS is not set/enabled by moving the #include > directive. > > ../drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip': > ../drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration] > 1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank, > > Fixes: e5530adc17a7 ("pinctrl: Clean up headers") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> I had sent https://lore.kernel.org/linux-gpio/20221228084310.85210-1-andriy.shevchenko@linux.intel.com/T/#u But now I see how I can amend it.
diff -- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -17,6 +17,7 @@ #include <linux/gpio/driver.h> #include <linux/spinlock.h> #include <linux/interrupt.h> +#include <linux/seq_file.h> #include <linux/slab.h> #include <linux/of_device.h> #include <linux/of_address.h> @@ -907,8 +908,6 @@ static int nmk_gpio_get_mode(struct nmk_ return (afunc ? NMK_GPIO_ALT_A : 0) | (bfunc ? NMK_GPIO_ALT_B : 0); } -#include <linux/seq_file.h> - static void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev, struct gpio_chip *chip, unsigned offset, unsigned gpio)
Fix build when DEBUG_FS is not set/enabled by moving the #include directive. ../drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip': ../drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration] 1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank, Fixes: e5530adc17a7 ("pinctrl: Clean up headers") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> --- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)