| Message ID | 20220822152224.507497-4-jean-philippe@linaro.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dt-bindings: Some schema fixes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, 22 Aug 2022 16:22:24 +0100, Jean-Philippe Brucker <jean-philippe@linaro.org> wrote: > > It should be valid for a GICv2m node, child of a GICv2 node, to use two > cells per reg address and size. The QEMU virt device-tree currently > fails validation because the schema imposes a single address and size > cell. Amend the rule. > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> Acked-by: Marc Zyngier <maz@kernel.org> M.
On Mon, Aug 22, 2022 at 2:46 PM Marc Zyngier <maz@kernel.org> wrote: > > On Mon, 22 Aug 2022 16:22:24 +0100, > Jean-Philippe Brucker <jean-philippe@linaro.org> wrote: > > > > It should be valid for a GICv2m node, child of a GICv2 node, to use two > > cells per reg address and size. The QEMU virt device-tree currently > > fails validation because the schema imposes a single address and size > > cell. Amend the rule. > > > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > > Acked-by: Marc Zyngier <maz@kernel.org> Did you want me to pick these up? If not: Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, 22 Aug 2022 20:50:16 +0100, Rob Herring <robh+dt@kernel.org> wrote: > > On Mon, Aug 22, 2022 at 2:46 PM Marc Zyngier <maz@kernel.org> wrote: > > > > On Mon, 22 Aug 2022 16:22:24 +0100, > > Jean-Philippe Brucker <jean-philippe@linaro.org> wrote: > > > > > > It should be valid for a GICv2m node, child of a GICv2 node, to use two > > > cells per reg address and size. The QEMU virt device-tree currently > > > fails validation because the schema imposes a single address and size > > > cell. Amend the rule. > > > > > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > > > > Acked-by: Marc Zyngier <maz@kernel.org> > > Did you want me to pick these up? If not: > > Reviewed-by: Rob Herring <robh@kernel.org> Yes, please. M.
On Mon, 22 Aug 2022 16:22:24 +0100, Jean-Philippe Brucker wrote: > It should be valid for a GICv2m node, child of a GICv2 node, to use two > cells per reg address and size. The QEMU virt device-tree currently > fails validation because the schema imposes a single address and size > cell. Amend the rule. > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > --- > .../devicetree/bindings/interrupt-controller/arm,gic.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml index 62219a5c21c5..220256907461 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml @@ -64,9 +64,9 @@ properties: interrupt-controller: true "#address-cells": - enum: [ 0, 1 ] + enum: [ 0, 1, 2 ] "#size-cells": - const: 1 + enum: [ 1, 2 ] "#interrupt-cells": const: 3
It should be valid for a GICv2m node, child of a GICv2 node, to use two cells per reg address and size. The QEMU virt device-tree currently fails validation because the schema imposes a single address and size cell. Amend the rule. Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> --- .../devicetree/bindings/interrupt-controller/arm,gic.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)