Message ID | 20220702031832.13282-1-jianbol@nvidia.com |
---|---|
Headers | show |
Series | Add support for ovs metering with tc offload | expand |
On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > This series is to add support for tc offloading of ovs metering, and > enhance OVS to use new kernel feature which offload tc police action to > hardware. > To do the offloading, new APIs for meter are added in netdev-offload, > and OVS meters are mapped to tc police actions with one-to-one > relationship for dpif-netlink. Just completed the review of v6 and sent out some minor comments. If you could quickly send a v7, I’ll review and ack them as I’ll keep my test setup ready. //Eelco
On Thu, 2022-07-07 at 13:54 +0200, Eelco Chaudron wrote: > > > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > > > This series is to add support for tc offloading of ovs metering, > > and > > enhance OVS to use new kernel feature which offload tc police > > action to > > hardware. > > To do the offloading, new APIs for meter are added in netdev- > > offload, > > and OVS meters are mapped to tc police actions with one-to-one > > relationship for dpif-netlink. > > Just completed the review of v6 and sent out some minor comments. > If you could quickly send a v7, I’ll review and ack them as I’ll keep > my test setup ready. > Sorry I missed your email yesterday because I got off work (we are in different time zone). Hope you still keep the setup. I will send v7 soon, and you can test as sson as you start working. Thanks! > //Eelco >
On 8 Jul 2022, at 4:25, Jianbo Liu wrote: > On Thu, 2022-07-07 at 13:54 +0200, Eelco Chaudron wrote: >> >> >> On 2 Jul 2022, at 5:18, Jianbo Liu wrote: >> >>> This series is to add support for tc offloading of ovs metering, >>> and >>> enhance OVS to use new kernel feature which offload tc police >>> action to >>> hardware. >>> To do the offloading, new APIs for meter are added in netdev- >>> offload, >>> and OVS meters are mapped to tc police actions with one-to-one >>> relationship for dpif-netlink. >> >> Just completed the review of v6 and sent out some minor comments. >> If you could quickly send a v7, I’ll review and ack them as I’ll keep >> my test setup ready. >> > > Sorry I missed your email yesterday because I got off work (we are in > different time zone). Hope you still keep the setup. > I will send v7 soon, and you can test as sson as you start working. > Thanks! No problem, I kept the setup ready and your v7 works fine. I have one small nit/change request but the rest looks good. If you sent out a v8 with this change, to me the series is ok for merge. //Eelco
On Fri, 2022-07-08 at 11:32 +0200, Eelco Chaudron wrote: > > > On 8 Jul 2022, at 4:25, Jianbo Liu wrote: > > > On Thu, 2022-07-07 at 13:54 +0200, Eelco Chaudron wrote: > > > > > > > > > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > > > > > > > This series is to add support for tc offloading of ovs > > > > metering, > > > > and > > > > enhance OVS to use new kernel feature which offload tc police > > > > action to > > > > hardware. > > > > To do the offloading, new APIs for meter are added in netdev- > > > > offload, > > > > and OVS meters are mapped to tc police actions with one-to-one > > > > relationship for dpif-netlink. > > > > > > Just completed the review of v6 and sent out some minor comments. > > > If you could quickly send a v7, I’ll review and ack them as I’ll > > > keep > > > my test setup ready. > > > > > > > Sorry I missed your email yesterday because I got off work (we are > > in > > different time zone). Hope you still keep the setup. > > I will send v7 soon, and you can test as sson as you start working. > > Thanks! > > No problem, I kept the setup ready and your v7 works fine. I have one > small nit/change request but the rest looks good. If you sent out a > v8 with this change, to me the series is ok for merge. > Done. Thank you very much. :) > //Eelco >
On 8 Jul 2022, at 11:58, Jianbo Liu wrote: > On Fri, 2022-07-08 at 11:32 +0200, Eelco Chaudron wrote: >> >> >> On 8 Jul 2022, at 4:25, Jianbo Liu wrote: >> >>> On Thu, 2022-07-07 at 13:54 +0200, Eelco Chaudron wrote: >>>> >>>> >>>> On 2 Jul 2022, at 5:18, Jianbo Liu wrote: >>>> >>>>> This series is to add support for tc offloading of ovs >>>>> metering, >>>>> and >>>>> enhance OVS to use new kernel feature which offload tc police >>>>> action to >>>>> hardware. >>>>> To do the offloading, new APIs for meter are added in netdev- >>>>> offload, >>>>> and OVS meters are mapped to tc police actions with one-to-one >>>>> relationship for dpif-netlink. >>>> >>>> Just completed the review of v6 and sent out some minor comments. >>>> If you could quickly send a v7, I’ll review and ack them as I’ll >>>> keep >>>> my test setup ready. >>>> >>> >>> Sorry I missed your email yesterday because I got off work (we are >>> in >>> different time zone). Hope you still keep the setup. >>> I will send v7 soon, and you can test as sson as you start working. >>> Thanks! >> >> No problem, I kept the setup ready and your v7 works fine. I have one >> small nit/change request but the rest looks good. If you sent out a >> v8 with this change, to me the series is ok for merge. >> > > Done. Thank you very much. :) Thank you! I’ve explicitly ACKed patch 4, so it’s clear I’m done with the review and happy! Time for weekend ;) //Eelco