| Message ID | 20220513033450.7038-2-kflin@nuvoton.com |
|---|---|
| State | New |
| Headers | show |
| Series | Support Nuvoton NPCM Video Capture/Encode Engine | expand |
Dear Marvin, Thank you for the patch. Am 13.05.22 um 05:34 schrieb Marvin Lin: > Add node for Video Capture/Differentiation Engine (VCD) and Encoding > Compression Engine (ECE) present on Nuvoton NPCM SoCs. Could you please add the datasheet name and revision to the commit message? What board did you test this on? > Signed-off-by: Marvin Lin <kflin@nuvoton.com> As you sent this from your Google Mail account, that address is going to be used in the author field. Is your Nuvoton address configured for git? git config user.email Then I would have thought, that that address is also in the files generated by `git format-patch`. Kind regards, Paul > --- > arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > index 3696980a3da1..0d2df74974bf 100644 > --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > @@ -178,6 +178,19 @@ > status = "disabled"; > }; > > + video: video@f0810000 { > + compatible = "nuvoton,npcm750-video"; > + reg = <0xf0810000 0x10000>, <0xf0820000 0x2000>; > + reg-names = "vcd", "ece"; > + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; > + resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_VCD>, > + <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_ECE>; > + reset-names = "vcd", "ece"; > + nuvoton,syscon-gcr = <&gcr>; > + nuvoton,syscon-gfxi = <&gfxi>; > + status = "disabled"; > + }; > + > apb { > #address-cells = <1>; > #size-cells = <1>; > @@ -553,6 +566,12 @@ > pinctrl-0 = <&smb15_pins>; > status = "disabled"; > }; > + > + gfxi: gfxi@e000 { > + compatible = "nuvoton,npcm750-gfxi", "syscon", > + "simple-mfd"; > + reg = <0xe000 0x100>; > + }; > }; > }; >
Dear Paul, Thanks for your review and comments. > Could you please add the datasheet name and revision to the commit message? It may not be appropriate since the datasheet is not public. > What board did you test this on? I tested on Nuvoton NPCM750 evaluation board. > > > Signed-off-by: Marvin Lin <kflin@nuvoton.com> > > As you sent this from your Google Mail account, that address is going to > be used in the author field. Is your Nuvoton address configured for git? > > git config user.email > > Then I would have thought, that that address is also in the files > generated by `git format-patch`. Thanks for the reminder. I'll change the address configuration. Regards, Marvin
diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi index 3696980a3da1..0d2df74974bf 100644 --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi @@ -178,6 +178,19 @@ status = "disabled"; }; + video: video@f0810000 { + compatible = "nuvoton,npcm750-video"; + reg = <0xf0810000 0x10000>, <0xf0820000 0x2000>; + reg-names = "vcd", "ece"; + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; + resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_VCD>, + <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_ECE>; + reset-names = "vcd", "ece"; + nuvoton,syscon-gcr = <&gcr>; + nuvoton,syscon-gfxi = <&gfxi>; + status = "disabled"; + }; + apb { #address-cells = <1>; #size-cells = <1>; @@ -553,6 +566,12 @@ pinctrl-0 = <&smb15_pins>; status = "disabled"; }; + + gfxi: gfxi@e000 { + compatible = "nuvoton,npcm750-gfxi", "syscon", + "simple-mfd"; + reg = <0xe000 0x100>; + }; }; };
Add node for Video Capture/Differentiation Engine (VCD) and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs. Signed-off-by: Marvin Lin <kflin@nuvoton.com> --- arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)