diff mbox series

gcc.dg/weak/typeof-2: arm may use constant pool

Message ID orv8vxllwv.fsf@lxoliva.fsfla.org
State New
Headers show
Series gcc.dg/weak/typeof-2: arm may use constant pool | expand

Commit Message

Alexandre Oliva March 28, 2022, 11:03 p.m. UTC
Some ARM configurations, such as with -mlong-calls, load the call
target from the constant pool, breaking the expectation of the test as
on several other targets.

Tested on an affected target.  Ok to install?


for  gcc/testsuite/ChangeLog

	* gcc.dg/weak/typeof-2.c: Add arm*-*-* to targets that may
	place the call target in a constant pool.
---
 gcc/testsuite/gcc.dg/weak/typeof-2.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Richard Biener March 29, 2022, 7:12 a.m. UTC | #1
On Tue, Mar 29, 2022 at 1:04 AM Alexandre Oliva via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> Some ARM configurations, such as with -mlong-calls, load the call
> target from the constant pool, breaking the expectation of the test as
> on several other targets.
>
> Tested on an affected target.  Ok to install?

OK

>
> for  gcc/testsuite/ChangeLog
>
>         * gcc.dg/weak/typeof-2.c: Add arm*-*-* to targets that may
>         place the call target in a constant pool.
> ---
>  gcc/testsuite/gcc.dg/weak/typeof-2.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.dg/weak/typeof-2.c b/gcc/testsuite/gcc.dg/weak/typeof-2.c
> index afce17f53cb09..c6e45624810aa 100644
> --- a/gcc/testsuite/gcc.dg/weak/typeof-2.c
> +++ b/gcc/testsuite/gcc.dg/weak/typeof-2.c
> @@ -40,6 +40,8 @@ int bar3 (int x)
>  // { dg-final { if [string match {sh[elb1-9]*-*-*} $target_triplet ] {return} } }
>  // Likewise for S/390 targets
>  // { dg-final { if [string match s390*-*-* $target_triplet ] {return} } }
> +// Likewise for ARM targets
> +// { dg-final { if [string match arm*-*-* $target_triplet ] {return} } }
>  // Likewise for CRIS targets.
>  // { dg-final { if [string match cris-*-* $target_triplet ] {return} } }
>  // Likewise for m68k targets.
>
>
> --
> Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
>    Free Software Activist                       GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts.  Ask me about <https://stallmansupport.org>
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/weak/typeof-2.c b/gcc/testsuite/gcc.dg/weak/typeof-2.c
index afce17f53cb09..c6e45624810aa 100644
--- a/gcc/testsuite/gcc.dg/weak/typeof-2.c
+++ b/gcc/testsuite/gcc.dg/weak/typeof-2.c
@@ -40,6 +40,8 @@  int bar3 (int x)
 // { dg-final { if [string match {sh[elb1-9]*-*-*} $target_triplet ] {return} } }
 // Likewise for S/390 targets
 // { dg-final { if [string match s390*-*-* $target_triplet ] {return} } }
+// Likewise for ARM targets
+// { dg-final { if [string match arm*-*-* $target_triplet ] {return} } }
 // Likewise for CRIS targets.
 // { dg-final { if [string match cris-*-* $target_triplet ] {return} } }
 // Likewise for m68k targets.