| Message ID | 20220107154930.505075-1-sw@weilnetz.de |
|---|---|
| State | New |
| Headers | show |
| Series | libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM) | expand |
Am 07.01.22 um 16:49 schrieb Stefan Weil: > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > > LGTM has some more alerts which need attention: > https://lgtm.com/projects/g/qemu/qemu/ > > Regards, > Stefan > > subprojects/libvhost-user/libvhost-user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c > index 787f4d2d4f..6eb72c4200 100644 > --- a/subprojects/libvhost-user/libvhost-user.c > +++ b/subprojects/libvhost-user/libvhost-user.c > @@ -651,7 +651,7 @@ generate_faults(VuDev *dev) { > > if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER, ®_struct)) { > vu_panic(dev, "%s: Failed to userfault region %d " > - "@%p + size:%zx offset: %zx: (ufd=%d)%s\n", > + "@%" PRIx64 " + size:%zx offset: %zx: (ufd=%d)%s\n", > __func__, i, > dev_region->mmap_addr, > dev_region->size, dev_region->mmap_offset, Up to now I did not see any response to this patch, and it is also still missing in the latest code. dev_region->mmap_addr is an uint64_t value, so the current format string "%p" won't work on any platform where pointers are not 64 bit value. Stefan
On 24/2/22 22:22, Stefan Weil wrote: > Am 07.01.22 um 16:49 schrieb Stefan Weil: > >> Signed-off-by: Stefan Weil <sw@weilnetz.de> >> --- >> >> LGTM has some more alerts which need attention: >> https://lgtm.com/projects/g/qemu/qemu/ >> >> Regards, >> Stefan >> >> subprojects/libvhost-user/libvhost-user.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/subprojects/libvhost-user/libvhost-user.c >> b/subprojects/libvhost-user/libvhost-user.c >> index 787f4d2d4f..6eb72c4200 100644 >> --- a/subprojects/libvhost-user/libvhost-user.c >> +++ b/subprojects/libvhost-user/libvhost-user.c >> @@ -651,7 +651,7 @@ generate_faults(VuDev *dev) { >> if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER, ®_struct)) { >> vu_panic(dev, "%s: Failed to userfault region %d " >> - "@%p + size:%zx offset: %zx: (ufd=%d)%s\n", >> + "@%" PRIx64 " + size:%zx offset: %zx: >> (ufd=%d)%s\n", >> __func__, i, >> dev_region->mmap_addr, >> dev_region->size, dev_region->mmap_offset, > > > Up to now I did not see any response to this patch, and it is also still > missing in the latest code. > > dev_region->mmap_addr is an uint64_t value, so the current format string > "%p" won't work on any platform where pointers are not 64 bit value. > > Stefan > > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c index 787f4d2d4f..6eb72c4200 100644 --- a/subprojects/libvhost-user/libvhost-user.c +++ b/subprojects/libvhost-user/libvhost-user.c @@ -651,7 +651,7 @@ generate_faults(VuDev *dev) { if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER, ®_struct)) { vu_panic(dev, "%s: Failed to userfault region %d " - "@%p + size:%zx offset: %zx: (ufd=%d)%s\n", + "@%" PRIx64 " + size:%zx offset: %zx: (ufd=%d)%s\n", __func__, i, dev_region->mmap_addr, dev_region->size, dev_region->mmap_offset,
Signed-off-by: Stefan Weil <sw@weilnetz.de> --- LGTM has some more alerts which need attention: https://lgtm.com/projects/g/qemu/qemu/ Regards, Stefan subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)