| Message ID | 20210615172024.856360-1-robh@kernel.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dt-bindings: spmi: Correct 'reg' schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Tue, 15 Jun 2021 11:20:24 -0600, Rob Herring wrote: > 'reg' is defined to be N address entries of M cells each. For SPMI, N is 1 > and M is 1 or 2. The schema fails to define the number of entries as it > only specifies the inner cell(s). To fix, add an outer items list with 1 > entry. > > Cc: Stephen Boyd <sboyd@kernel.org> > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/spmi/spmi.yaml | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/spmi/spmi.yaml b/Documentation/devicetree/bindings/spmi/spmi.yaml index 173940930719..1d243faef2f8 100644 --- a/Documentation/devicetree/bindings/spmi/spmi.yaml +++ b/Documentation/devicetree/bindings/spmi/spmi.yaml @@ -40,14 +40,15 @@ patternProperties: properties: reg: - minItems: 1 - maxItems: 2 items: - - minimum: 0 - maximum: 0xf - - enum: [ 0 ] - description: | - 0 means user ID address. 1 is reserved for group ID address. + - minItems: 1 + items: + - minimum: 0 + maximum: 0xf + - enum: [ 0 ] + description: + 0 means user ID address. 1 is reserved for group ID + address. required: - reg
'reg' is defined to be N address entries of M cells each. For SPMI, N is 1 and M is 1 or 2. The schema fails to define the number of entries as it only specifies the inner cell(s). To fix, add an outer items list with 1 entry. Cc: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/spmi/spmi.yaml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)