diff mbox series

[v3] network/sit01.sh: Replace tst_res with tst_brk

Message ID 20210429022839.24503-1-zhaogongyi@huawei.com
State Accepted
Headers show
Series [v3] network/sit01.sh: Replace tst_res with tst_brk | expand

Commit Message

Zhao Gongyi April 29, 2021, 2:28 a.m. UTC
We need replace tst_res with tst_brk to terminate the test
immediately since there is no sence to go on.

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
v2->v3: split into two separate commits
 testcases/network/virt/sit01.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1

Comments

Petr Vorel April 29, 2021, 6:56 a.m. UTC | #1
Hi,

> We need replace tst_res with tst_brk to terminate the test
> immediately since there is no sence to go on.

> +++ b/testcases/network/virt/sit01.sh
>  do_setup()
>  {
> -	[ -n "$TST_IPV6" ] && tst_res TBROK "invalid option '-6' for sit tunnel"
> +	[ -n "$TST_IPV6" ] && tst_brk TBROK "invalid option '-6' for sit tunnel"

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr
Petr Vorel April 29, 2021, 5:12 p.m. UTC | #2
Hi,

> +++ b/testcases/network/virt/sit01.sh
> -	[ -n "$TST_IPV6" ] && tst_res TBROK "invalid option '-6' for sit tunnel"
> +	[ -n "$TST_IPV6" ] && tst_brk TBROK "invalid option '-6' for sit tunnel"

Merged, thanks!

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/network/virt/sit01.sh b/testcases/network/virt/sit01.sh
index 4ecc1f8c0..27fa0ee77 100755
--- a/testcases/network/virt/sit01.sh
+++ b/testcases/network/virt/sit01.sh
@@ -11,7 +11,7 @@  virt_type="sit"

 do_setup()
 {
-	[ -n "$TST_IPV6" ] && tst_res TBROK "invalid option '-6' for sit tunnel"
+	[ -n "$TST_IPV6" ] && tst_brk TBROK "invalid option '-6' for sit tunnel"

 	virt_lib_setup