diff mbox series

rs6000: Fix check_effective_target_sqrt_insn (PR99352)

Message ID fc76f029357430220d9d9181ac6b36bb136b81ad.1615309270.git.segher@kernel.crashing.org
State New
Headers show
Series rs6000: Fix check_effective_target_sqrt_insn (PR99352) | expand

Commit Message

Segher Boessenkool March 9, 2021, 5:08 p.m. UTC 
The previous version returned true for all PowerPC.  This is incorrect.
We only support floating point square root instructions if a) we support
floating point instructions at all, and b) we have _ARCH_PPCSQ defined.

2020-03-09  Segher Boessenkool  <segher@kernel.crashing.org>

	* testsuite/lib/target-supports.exp
	(check_effective_target_powerpc_sqrt): New.
	(check_effective_target_sqrt_insn): Use it.
---
 gcc/testsuite/lib/target-supports.exp | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Comments

Alexandre Oliva March 10, 2021, 5:06 a.m. UTC | #1 
On Mar  9, 2021, Segher Boessenkool <segher@kernel.crashing.org> wrote:

> +    return [check_no_compiler_messages powerpc_sqrt object {

I don't think you really need to assemble this.  s/object/assembly/
would do.  Even preprocessing alone would do, but I don't think
check_compiler can do that.
Segher Boessenkool March 12, 2021, 2:37 a.m. UTC | #2 
On Wed, Mar 10, 2021 at 02:06:24AM -0300, Alexandre Oliva wrote:
> On Mar  9, 2021, Segher Boessenkool <segher@kernel.crashing.org> wrote:
> 
> > +    return [check_no_compiler_messages powerpc_sqrt object {
> 
> I don't think you really need to assemble this.  s/object/assembly/
> would do.  Even preprocessing alone would do, but I don't think
> check_compiler can do that.

We use object in all similar tests.  It helps to check if the assembler
is set up for the options used.  That doesn't matter for this test of
course, but making things more tricky for no win is a bad tradeoff.

Also, I didn't even bother to consider not assembling it :-)


Segher
diff mbox series

Patch

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 570d5d3de00c..52d3d036d3c5 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -5887,6 +5887,21 @@  proc check_effective_target_powerpc_hard_double { } {
     }
 }
 
+# Return 1 if this is a PowerPC target with hardware floating point sqrt.
+
+proc check_effective_target_powerpc_sqrt { } {
+    # We need to be PowerPC, and we need to have hardware fp enabled.
+    if {![check_effective_target_powerpc_fprs]} {
+      return 0;
+    }
+
+    return [check_no_compiler_messages powerpc_sqrt object {
+	#ifndef _ARCH_PPCSQ
+	#error _ARCH_PPCSQ is not defined
+	#endif
+    } {}]
+}
+
 # Return 1 if this is a PowerPC target supporting -maltivec.
 
 proc check_effective_target_powerpc_altivec_ok { } {
@@ -7581,7 +7596,7 @@  proc check_effective_target_vect_call_copysignf { } {
 proc check_effective_target_sqrt_insn { } {
     return [check_cached_effective_target sqrt_insn {
       expr { [istarget i?86-*-*] || [istarget x86_64-*-*]
-	     || [istarget powerpc*-*-*]
+	     || [check_effective_target_powerpc_sqrt]
 	     || [istarget aarch64*-*-*]
 	     || ([istarget arm*-*-*] && [check_effective_target_arm_vfp_ok])
 	     || ([istarget s390*-*-*]