diff mbox series

Fix typo in arm_mve.h __arm_vcmpneq_s8 return type

Message ID 1611236198-16546-1-git-send-email-christophe.lyon@linaro.org
State New
Headers show
Series Fix typo in arm_mve.h __arm_vcmpneq_s8 return type | expand

Commit Message

Christophe Lyon Jan. 21, 2021, 1:36 p.m. UTC
Like all vcmp intrinsics, __arm_vcmpneq_s8 should return a mve_pred16_t.

2021-01-21  Christophe Lyon  <christophe.lyon@linaro.org>

	gcc/
	* config/arm/arm_mve.h (__arm_vcmpneq_s8): Fix return type.
---
 gcc/config/arm/arm_mve.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kyrylo Tkachov Jan. 21, 2021, 1:39 p.m. UTC | #1
> -----Original Message-----
> From: Gcc-patches <gcc-patches-bounces@gcc.gnu.org> On Behalf Of
> Christophe Lyon via Gcc-patches
> Sent: 21 January 2021 13:37
> To: gcc-patches@gcc.gnu.org
> Subject: [PATCH] Fix typo in arm_mve.h __arm_vcmpneq_s8 return type
> 
> Like all vcmp intrinsics, __arm_vcmpneq_s8 should return a mve_pred16_t.
> 

Ok. I think it also needs a backport to GCC 10
Thanks,
Kyrill

> 2021-01-21  Christophe Lyon  <christophe.lyon@linaro.org>
> 
> 	gcc/
> 	* config/arm/arm_mve.h (__arm_vcmpneq_s8): Fix return type.
> ---
>  gcc/config/arm/arm_mve.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
> index f27f6cd..3a40c6e 100644
> --- a/gcc/config/arm/arm_mve.h
> +++ b/gcc/config/arm/arm_mve.h
> @@ -3670,7 +3670,7 @@ __arm_vaddlvq_p_u32 (uint32x4_t __a,
> mve_pred16_t __p)
>    return __builtin_mve_vaddlvq_p_uv4si (__a, __p);
>  }
> 
> -__extension__ extern __inline int32_t
> +__extension__ extern __inline mve_pred16_t
>  __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
>  __arm_vcmpneq_s8 (int8x16_t __a, int8x16_t __b)
>  {
> --
> 2.7.4
Christophe Lyon Jan. 21, 2021, 1:52 p.m. UTC | #2
On Thu, 21 Jan 2021 at 14:39, Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Gcc-patches <gcc-patches-bounces@gcc.gnu.org> On Behalf Of
> > Christophe Lyon via Gcc-patches
> > Sent: 21 January 2021 13:37
> > To: gcc-patches@gcc.gnu.org
> > Subject: [PATCH] Fix typo in arm_mve.h __arm_vcmpneq_s8 return type
> >
> > Like all vcmp intrinsics, __arm_vcmpneq_s8 should return a mve_pred16_t.
> >
>
> Ok. I think it also needs a backport to GCC 10
> Thanks,
> Kyrill
>

Indeed.
Pushed to trunk and gcc-10.

Thanks

Christophe

> > 2021-01-21  Christophe Lyon  <christophe.lyon@linaro.org>
> >
> >       gcc/
> >       * config/arm/arm_mve.h (__arm_vcmpneq_s8): Fix return type.
> > ---
> >  gcc/config/arm/arm_mve.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
> > index f27f6cd..3a40c6e 100644
> > --- a/gcc/config/arm/arm_mve.h
> > +++ b/gcc/config/arm/arm_mve.h
> > @@ -3670,7 +3670,7 @@ __arm_vaddlvq_p_u32 (uint32x4_t __a,
> > mve_pred16_t __p)
> >    return __builtin_mve_vaddlvq_p_uv4si (__a, __p);
> >  }
> >
> > -__extension__ extern __inline int32_t
> > +__extension__ extern __inline mve_pred16_t
> >  __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> >  __arm_vcmpneq_s8 (int8x16_t __a, int8x16_t __b)
> >  {
> > --
> > 2.7.4
>
diff mbox series

Patch

diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
index f27f6cd..3a40c6e 100644
--- a/gcc/config/arm/arm_mve.h
+++ b/gcc/config/arm/arm_mve.h
@@ -3670,7 +3670,7 @@  __arm_vaddlvq_p_u32 (uint32x4_t __a, mve_pred16_t __p)
   return __builtin_mve_vaddlvq_p_uv4si (__a, __p);
 }
 
-__extension__ extern __inline int32_t
+__extension__ extern __inline mve_pred16_t
 __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
 __arm_vcmpneq_s8 (int8x16_t __a, int8x16_t __b)
 {