| Message ID | 20200915013336.678405-2-rosenp@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] fs/cifs: update module dependencies | expand |
On 9/15/20 3:33 AM, Rosen Penev wrote: > CIFS_ALLOW_INSECURE_LEGACY is only relevant for mounting shares that > are provided by old CIFS servers. It is not relevant to the Samba or > ksmbd package that provide a server. There are many old SMB servers running which do not support SMB 2.1 or later. By looking at the code it does not look like we save much space by deactivating CONFIG_CIFS_ALLOW_INSECURE_LEGACY. I would prefer to kee CONFIG_CIFS_ALLOW_INSECURE_LEGACY activated. > CIFS_STATS is a debugging option. It is not really useful for end users > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > --- > target/linux/generic/config-4.19 | 4 ++-- > target/linux/generic/config-5.4 | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/linux/generic/config-4.19 b/target/linux/generic/config-4.19 > index d4a942f9aa..e9c6306307 100644 > --- a/target/linux/generic/config-4.19 > +++ b/target/linux/generic/config-4.19 > @@ -776,14 +776,14 @@ CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y > # CONFIG_CICADA_PHY is not set > # CONFIG_CIFS is not set > # CONFIG_CIFS_ACL is not set > -CONFIG_CIFS_ALLOW_INSECURE_LEGACY=y > +# CONFIG_CIFS_ALLOW_INSECURE_LEGACY is not set > # CONFIG_CIFS_DEBUG is not set > # CONFIG_CIFS_DEBUG2 is not set
On Sat, Oct 10, 2020 at 2:04 PM Hauke Mehrtens <hauke@hauke-m.de> wrote: > > On 9/15/20 3:33 AM, Rosen Penev wrote: > > CIFS_ALLOW_INSECURE_LEGACY is only relevant for mounting shares that > > are provided by old CIFS servers. It is not relevant to the Samba or > > ksmbd package that provide a server. > > There are many old SMB servers running which do not support SMB 2.1 or > later. By looking at the code it does not look like we save much space > by deactivating CONFIG_CIFS_ALLOW_INSECURE_LEGACY. I would prefer to kee > CONFIG_CIFS_ALLOW_INSECURE_LEGACY activated. OK. > > > > CIFS_STATS is a debugging option. It is not really useful for end users > > > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > > --- > > target/linux/generic/config-4.19 | 4 ++-- > > target/linux/generic/config-5.4 | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/target/linux/generic/config-4.19 b/target/linux/generic/config-4.19 > > index d4a942f9aa..e9c6306307 100644 > > --- a/target/linux/generic/config-4.19 > > +++ b/target/linux/generic/config-4.19 > > @@ -776,14 +776,14 @@ CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y > > # CONFIG_CICADA_PHY is not set > > # CONFIG_CIFS is not set > > # CONFIG_CIFS_ACL is not set > > -CONFIG_CIFS_ALLOW_INSECURE_LEGACY=y > > +# CONFIG_CIFS_ALLOW_INSECURE_LEGACY is not set > > # CONFIG_CIFS_DEBUG is not set > > # CONFIG_CIFS_DEBUG2 is not set
diff --git a/target/linux/generic/config-4.19 b/target/linux/generic/config-4.19 index d4a942f9aa..e9c6306307 100644 --- a/target/linux/generic/config-4.19 +++ b/target/linux/generic/config-4.19 @@ -776,14 +776,14 @@ CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y # CONFIG_CICADA_PHY is not set # CONFIG_CIFS is not set # CONFIG_CIFS_ACL is not set -CONFIG_CIFS_ALLOW_INSECURE_LEGACY=y +# CONFIG_CIFS_ALLOW_INSECURE_LEGACY is not set # CONFIG_CIFS_DEBUG is not set # CONFIG_CIFS_DEBUG2 is not set # CONFIG_CIFS_FSCACHE is not set # CONFIG_CIFS_NFSD_EXPORT is not set CONFIG_CIFS_POSIX=y # CONFIG_CIFS_SMB2 is not set -CONFIG_CIFS_STATS=y +# CONFIG_CIFS_STATS is not set # CONFIG_CIFS_STATS2 is not set # CONFIG_CIFS_WEAK_PW_HASH is not set # CONFIG_CIFS_XATTR is not set diff --git a/target/linux/generic/config-5.4 b/target/linux/generic/config-5.4 index 6f63b8c5dd..b8d214349c 100644 --- a/target/linux/generic/config-5.4 +++ b/target/linux/generic/config-5.4 @@ -826,14 +826,14 @@ CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y # CONFIG_CICADA_PHY is not set # CONFIG_CIFS is not set # CONFIG_CIFS_ACL is not set -CONFIG_CIFS_ALLOW_INSECURE_LEGACY=y +# CONFIG_CIFS_ALLOW_INSECURE_LEGACY is not set # CONFIG_CIFS_DEBUG is not set # CONFIG_CIFS_DEBUG2 is not set # CONFIG_CIFS_FSCACHE is not set # CONFIG_CIFS_NFSD_EXPORT is not set CONFIG_CIFS_POSIX=y # CONFIG_CIFS_SMB2 is not set -CONFIG_CIFS_STATS=y +# CONFIG_CIFS_STATS is not set # CONFIG_CIFS_STATS2 is not set # CONFIG_CIFS_WEAK_PW_HASH is not set # CONFIG_CIFS_XATTR is not set
CIFS_ALLOW_INSECURE_LEGACY is only relevant for mounting shares that are provided by old CIFS servers. It is not relevant to the Samba or ksmbd package that provide a server. CIFS_STATS is a debugging option. It is not really useful for end users Signed-off-by: Rosen Penev <rosenp@gmail.com> --- target/linux/generic/config-4.19 | 4 ++-- target/linux/generic/config-5.4 | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)