| Message ID | 20200910074900.26472-1-dingxiaoxiong@huawei.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev] ofproto:ipv6 mld report error send to fports | expand |
I missed this one, but the comments to the previous patch remains the same here. fbl On Thu, Sep 10, 2020 at 03:49:00PM +0800, XiaoXiong Ding wrote: > when mld report come(same as mld done), will do funciton > xlate_normal_mcast_send_rports, and because of no return, > will doforwarding to group base ports logic,and if > other_config:mcast-snooping-flood is set on a port, will do > xlate_normal_mcast_send_fports. so mld report will be reveived > when xlate_normal_mcast_send_fports is set on a port,whether > xlate_normal_mcast_send_fports is set or not. > but ipv4 is ok. > > Signed-off-by: XiaoXiong Ding <dingxiaoxiong@huawei.com> > --- > ofproto/ofproto-dpif-xlate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > index e0ede2cab..47571e790 100644 > --- a/ofproto/ofproto-dpif-xlate.c > +++ b/ofproto/ofproto-dpif-xlate.c > @@ -3100,6 +3100,7 @@ xlate_normal(struct xlate_ctx *ctx) > xlate_report(ctx, OFT_DETAIL, "MLD query, flooding"); > xlate_normal_flood(ctx, in_xbundle, &xvlan); > } > + return; > } else { > if (is_ip_local_multicast(flow, wc)) { > /* RFC4541: section 2.1.2, item 2: Packets with a dst IP > -- > 2.14.1.windows.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index e0ede2cab..47571e790 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -3100,6 +3100,7 @@ xlate_normal(struct xlate_ctx *ctx) xlate_report(ctx, OFT_DETAIL, "MLD query, flooding"); xlate_normal_flood(ctx, in_xbundle, &xvlan); } + return; } else { if (is_ip_local_multicast(flow, wc)) { /* RFC4541: section 2.1.2, item 2: Packets with a dst IP
when mld report come(same as mld done), will do funciton xlate_normal_mcast_send_rports, and because of no return, will doforwarding to group base ports logic,and if other_config:mcast-snooping-flood is set on a port, will do xlate_normal_mcast_send_fports. so mld report will be reveived when xlate_normal_mcast_send_fports is set on a port,whether xlate_normal_mcast_send_fports is set or not. but ipv4 is ok. Signed-off-by: XiaoXiong Ding <dingxiaoxiong@huawei.com> --- ofproto/ofproto-dpif-xlate.c | 1 + 1 file changed, 1 insertion(+)