| Message ID | 20200803132338.221961-1-roid@mellanox.com |
|---|---|
| State | Accepted |
| Delegated to: | Michal Kubecek |
| Headers | show |
| Series | [ethtool] ethtool.spec: Add bash completion script | expand |
On Mon, Aug 03, 2020 at 04:23:38PM +0300, Roi Dayan wrote: > After the additon of the bash completion script, packaging > using the default spec file fails for installed but not packaged > error. so package it. > > Fixes: 9b802643d7bd ("ethtool: Add bash-completion script") > Signed-off-by: Roi Dayan <roid@mellanox.com> Applied, thank you. We are using a heavily modified specfile in openSUSE so I never noticed. Added rpmbuild to my check script now. Michal > --- > ethtool.spec.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ethtool.spec.in b/ethtool.spec.in > index 9c01b07abf2b..75f9be6aafa6 100644 > --- a/ethtool.spec.in > +++ b/ethtool.spec.in > @@ -34,6 +34,7 @@ make install DESTDIR=${RPM_BUILD_ROOT} > %defattr(-,root,root) > %{_sbindir}/ethtool > %{_mandir}/man8/ethtool.8* > +%{_datadir}/bash-completion/completions/ethtool > %doc AUTHORS COPYING NEWS README > > > -- > 2.8.4 >
diff --git a/ethtool.spec.in b/ethtool.spec.in index 9c01b07abf2b..75f9be6aafa6 100644 --- a/ethtool.spec.in +++ b/ethtool.spec.in @@ -34,6 +34,7 @@ make install DESTDIR=${RPM_BUILD_ROOT} %defattr(-,root,root) %{_sbindir}/ethtool %{_mandir}/man8/ethtool.8* +%{_datadir}/bash-completion/completions/ethtool %doc AUTHORS COPYING NEWS README
After the additon of the bash completion script, packaging using the default spec file fails for installed but not packaged error. so package it. Fixes: 9b802643d7bd ("ethtool: Add bash-completion script") Signed-off-by: Roi Dayan <roid@mellanox.com> --- ethtool.spec.in | 1 + 1 file changed, 1 insertion(+)