diff mbox series

um: syscall.c: include <asm/unistd.h>

Message ID 20200415095152.85794f817f97.I289cb72f130c19e850d70eacca9e68eb84832600@changeid
State Not Applicable
Headers show
Series um: syscall.c: include <asm/unistd.h> | expand

Commit Message

Johannes Berg April 15, 2020, 7:51 a.m. UTC
From: Johannes Berg <johannes.berg@intel.com>

Without CONFIG_SECCOMP, we don't get this include recursively
through the existing includes, thus failing the build on not
having __NR_syscall_max defined. Add the necessary include to
fix this.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 arch/um/kernel/skas/syscall.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Anton Ivanov April 15, 2020, 9:39 a.m. UTC | #1
On 15/04/2020 08:51, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> Without CONFIG_SECCOMP, we don't get this include recursively
> through the existing includes, thus failing the build on not
> having __NR_syscall_max defined. Add the necessary include to
> fix this.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>   arch/um/kernel/skas/syscall.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c
> index 0a12d5a09217..3d91f89fd852 100644
> --- a/arch/um/kernel/skas/syscall.c
> +++ b/arch/um/kernel/skas/syscall.c
> @@ -11,6 +11,7 @@
>   #include <sysdep/ptrace_user.h>
>   #include <sysdep/syscalls.h>
>   #include <linux/time-internal.h>
> +#include <asm/unistd.h>
>   
>   void handle_syscall(struct uml_pt_regs *r)
>   {
> 

Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Richard Weinberger April 29, 2020, 7:24 p.m. UTC | #2
On Wed, Apr 15, 2020 at 11:39 AM Anton Ivanov
<anton.ivanov@kot-begemot.co.uk> wrote:
>
>
>
> On 15/04/2020 08:51, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > Without CONFIG_SECCOMP, we don't get this include recursively
> > through the existing includes, thus failing the build on not
> > having __NR_syscall_max defined. Add the necessary include to
> > fix this.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > ---
> >   arch/um/kernel/skas/syscall.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c
> > index 0a12d5a09217..3d91f89fd852 100644
> > --- a/arch/um/kernel/skas/syscall.c
> > +++ b/arch/um/kernel/skas/syscall.c
> > @@ -11,6 +11,7 @@
> >   #include <sysdep/ptrace_user.h>
> >   #include <sysdep/syscalls.h>
> >   #include <linux/time-internal.h>
> > +#include <asm/unistd.h>
> >
> >   void handle_syscall(struct uml_pt_regs *r)
> >   {
> >
>
> Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
>
> --
> Anton R. Ivanov
> https://www.kot-begemot.co.uk/
>
> _______________________________________________
> linux-um mailing list
> linux-um@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-um

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c
index 0a12d5a09217..3d91f89fd852 100644
--- a/arch/um/kernel/skas/syscall.c
+++ b/arch/um/kernel/skas/syscall.c
@@ -11,6 +11,7 @@ 
 #include <sysdep/ptrace_user.h>
 #include <sysdep/syscalls.h>
 #include <linux/time-internal.h>
+#include <asm/unistd.h>
 
 void handle_syscall(struct uml_pt_regs *r)
 {