| Message ID | 20200324082235.27980-3-kuhn.chenqun@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | redundant code: Fix warnings reported by Clang static code analyzer | expand |
Le 24/03/2020 à 09:22, Chen Qun a écrit : > Clang static code analyzer show warning: > hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read > data >>= 5; > ^ ~ > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > Cc: Andrzej Zaborowski <balrogg@gmail.com> > Cc: Peter Maydell <peter.maydell@linaro.org> > --- > hw/display/blizzard.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c > index 359e399c2a..62517bdf75 100644 > --- a/hw/display/blizzard.c > +++ b/hw/display/blizzard.c > @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest, > g = (data & 0x3f) << 2; > data >>= 6; > r = (data & 0x1f) << 3; > - data >>= 5; > *dest++ = rgb_to_pixel32(r, g, b); > } > } > Perhaps it would be clearer to use extract32() to compute r, g and b? Thanks, Laurent
Le 24/03/2020 à 09:38, Laurent Vivier a écrit : > Le 24/03/2020 à 09:22, Chen Qun a écrit : >> Clang static code analyzer show warning: >> hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read >> data >>= 5; >> ^ ~ >> Reported-by: Euler Robot <euler.robot@huawei.com> >> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> >> --- >> Cc: Andrzej Zaborowski <balrogg@gmail.com> >> Cc: Peter Maydell <peter.maydell@linaro.org> >> --- >> hw/display/blizzard.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c >> index 359e399c2a..62517bdf75 100644 >> --- a/hw/display/blizzard.c >> +++ b/hw/display/blizzard.c >> @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest, >> g = (data & 0x3f) << 2; >> data >>= 6; >> r = (data & 0x1f) << 3; >> - data >>= 5; >> *dest++ = rgb_to_pixel32(r, g, b); >> } >> } >> > > Perhaps it would be clearer to use extract32() to compute r, g and b? in fact extract16() as data is uint16_t... Thanks, Laurent
>-----Original Message----- >From: Laurent Vivier [mailto:laurent@vivier.eu] >Sent: Tuesday, March 24, 2020 4:40 PM >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu-devel@nongnu.org; >qemu-trivial@nongnu.org >Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>; philmd@redhat.com; >Euler Robot <euler.robot@huawei.com>; Andrzej Zaborowski ><balrogg@gmail.com>; Peter Maydell <peter.maydell@linaro.org> >Subject: Re: [PATCH v4 2/3] display/blizzard: Remove redundant statement in >blizzard_draw_line16_32() > >Le 24/03/2020 à 09:38, Laurent Vivier a écrit : >> Le 24/03/2020 à 09:22, Chen Qun a écrit : >>> Clang static code analyzer show warning: >>> hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read >>> data >>= 5; >>> ^ ~ >>> Reported-by: Euler Robot <euler.robot@huawei.com> >>> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> >>> --- >>> Cc: Andrzej Zaborowski <balrogg@gmail.com> >>> Cc: Peter Maydell <peter.maydell@linaro.org> >>> --- >>> hw/display/blizzard.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index >>> 359e399c2a..62517bdf75 100644 >>> --- a/hw/display/blizzard.c >>> +++ b/hw/display/blizzard.c >>> @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest, >>> g = (data & 0x3f) << 2; >>> data >>= 6; >>> r = (data & 0x1f) << 3; >>> - data >>= 5; >>> *dest++ = rgb_to_pixel32(r, g, b); >>> } >>> } >>> >> >> Perhaps it would be clearer to use extract32() to compute r, g and b? > >in fact extract16() as data is uint16_t... Good Point, I will update it next verison. Thanks.
diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 359e399c2a..62517bdf75 100644 --- a/hw/display/blizzard.c +++ b/hw/display/blizzard.c @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest, g = (data & 0x3f) << 2; data >>= 6; r = (data & 0x1f) << 3; - data >>= 5; *dest++ = rgb_to_pixel32(r, g, b); } }
Clang static code analyzer show warning: hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read data >>= 5; ^ ~ Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> --- Cc: Andrzej Zaborowski <balrogg@gmail.com> Cc: Peter Maydell <peter.maydell@linaro.org> --- hw/display/blizzard.c | 1 - 1 file changed, 1 deletion(-)