| Message ID | 20200221025535.30311-1-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] dt-bindings: i2c: Convert UniPhier I2C controller to json-schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 2 warnings, 50 lines checked" |
| robh/dt-meta-schema | success |
On Fri, 21 Feb 2020 11:55:33 +0900, Masahiro Yamada wrote: > Convert the UniPhier I2C controller (FIFO-less) binding to DT schema > format. > > There are two types of I2C controllers used on the UniPhier platform. > This is the legacy one without FIFO support, which is used on the > sLD8 SoC or older. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > When I search for a subsystem-common schema, I need to > look in both dt-schema project and the kernel tree. > > For example, > the i2c-controller.yaml is located in the dt-schema project. > dt-schema/schemas/i2c/i2c-controller.yaml > > The dma-controller.yaml is located in the kernel tree. > Documentation/devicetree/bindings/dma/dma-controller.yaml > > I am still wondering about the policy... > > As far as I understood, the schema written by Rob > tend to go in the dt-schma project. Is this correct? > > > .../devicetree/bindings/i2c/i2c-uniphier.txt | 25 ---------- > .../bindings/i2c/socionext,uniphier-i2c.yaml | 50 +++++++++++++++++++ > 2 files changed, 50 insertions(+), 25 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-uniphier.txt > create mode 100644 Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml > Applied, thanks. Rob
diff --git a/Documentation/devicetree/bindings/i2c/i2c-uniphier.txt b/Documentation/devicetree/bindings/i2c/i2c-uniphier.txt deleted file mode 100644 index 26f9d95b3436..000000000000 --- a/Documentation/devicetree/bindings/i2c/i2c-uniphier.txt +++ /dev/null @@ -1,25 +0,0 @@ -UniPhier I2C controller (FIFO-less) - -Required properties: -- compatible: should be "socionext,uniphier-i2c". -- #address-cells: should be 1. -- #size-cells: should be 0. -- reg: offset and length of the register set for the device. -- interrupts: a single interrupt specifier. -- clocks: phandle to the input clock. - -Optional properties: -- clock-frequency: desired I2C bus frequency in Hz. The maximum supported - value is 400000. Defaults to 100000 if not specified. - -Examples: - - i2c0: i2c@58400000 { - compatible = "socionext,uniphier-i2c"; - reg = <0x58400000 0x40>; - #address-cells = <1>; - #size-cells = <0>; - interrupts = <0 41 1>; - clocks = <&i2c_clk>; - clock-frequency = <100000>; - }; diff --git a/Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml b/Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml new file mode 100644 index 000000000000..ef998def554e --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i2c/socionext,uniphier-i2c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: UniPhier I2C controller (FIFO-less) + +maintainers: + - Masahiro Yamada <yamada.masahiro@socionext.com> + +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + +properties: + compatible: + const: socionext,uniphier-i2c + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-frequency: + minimum: 100000 + maximum: 400000 + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + - interrupts + - clocks + +examples: + - | + i2c0: i2c@58400000 { + compatible = "socionext,uniphier-i2c"; + reg = <0x58400000 0x40>; + #address-cells = <1>; + #size-cells = <0>; + interrupts = <0 41 1>; + clocks = <&i2c_clk>; + clock-frequency = <100000>; + };
Convert the UniPhier I2C controller (FIFO-less) binding to DT schema format. There are two types of I2C controllers used on the UniPhier platform. This is the legacy one without FIFO support, which is used on the sLD8 SoC or older. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- When I search for a subsystem-common schema, I need to look in both dt-schema project and the kernel tree. For example, the i2c-controller.yaml is located in the dt-schema project. dt-schema/schemas/i2c/i2c-controller.yaml The dma-controller.yaml is located in the kernel tree. Documentation/devicetree/bindings/dma/dma-controller.yaml I am still wondering about the policy... As far as I understood, the schema written by Rob tend to go in the dt-schma project. Is this correct? .../devicetree/bindings/i2c/i2c-uniphier.txt | 25 ---------- .../bindings/i2c/socionext,uniphier-i2c.yaml | 50 +++++++++++++++++++ 2 files changed, 50 insertions(+), 25 deletions(-) delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-uniphier.txt create mode 100644 Documentation/devicetree/bindings/i2c/socionext,uniphier-i2c.yaml